Move event types into separate crate #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xpr03
approved these changes
Jan 25, 2024
|
Please merge it. |
|
I'll do a crate push / release once I'm back home today. |
Sounds good. I've just seen a lot of PRs where in the time it took me to actually review them, they got additional commits for fixups. So I would've prematurely merged stuff if I would've been faster. (Finding typos is something I always do afterwards..) |
|
That's true. Happens to me all the time. And if I can, I fix those issues immediately. But if you merge my PR "too quick", it's still my fault for requesting bad code to be merged. So don't worry - and it can always be fixed later. |
Maybe hold back on that and check #560. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move event types into separate crate.
Closes #487.