-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: split Event structure into its own crate (notify-events?) #487
Comments
I don't see a problem with doing that. Some people will probably defend against a multi-crate setup, but if that helps, why not. Only incoming breaking change would be one proposal for making #478 possible. |
Only bikeshed is the crate name. notify-events is fine-ish ? notify-types is probably more fitting |
Oops, I just noticed that the debouncer crates have their own DebouncedEvent types. What should we do about those?
|
Option 2 should be fine. Not perfect but also it doesn't hurt anyone. |
This is a proposal to only split out the
notify/src/event.rs
file into its own crate, which would have no required dependencies, and serde only when the feature is enabled.The
Event
struct and child enums are pretty infrequently changed, and it would be helpful to downstream crates/users to be able to use the notify event types without pulling the entire notify runtime.My specific motivation is for a usage across an IPC or network barrier, where one side does the file watching and the other wants to deserialize into the proper types.
The text was updated successfully, but these errors were encountered: