Release 1.4.0 #337
Merged
Release 1.4.0 #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…get size) with null value on `size` argument for `NOverlayImage.fromWidget` (resolve #304)
…ndler.onMapLoaded` too.
…r`, `NaverMapViewEventDelegate`)
…rolSender`, `NaverMapView.setMapEventListeners`)
…olHandler.onMapLongTapped` too.
…ender`, `NaverMapViewEventDelegate`)
…ControlSender`, `NaverMapView.setMapEventListeners`)
…Tapped`) with snackbar
…th `NPolylineOverlay.pattern`)
(cherry picked from commit 64999e3)
…tion to prevent GITHUB_TOKEN workflow trigger limitations
…tion to prevent GITHUB_TOKEN workflow trigger limitations
…tion to prevent GITHUB_TOKEN workflow trigger limitations (cherry picked from commit 7a45af8)
# Conflicts: # .github/workflows/package_publish.yml # ios/.gitignore
Contributor
📋 Changelog for v1.4.0Breaking Change
Add (New Features)
Update
Fix
This is an automated comment showing the changelog entry for this release. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the plugin to version 1.4.0, adds new map lifecycle and style callbacks, and refactors several internal APIs for message serialization.
- Bumped package/version to 1.4.0 and synchronized native dependency versions.
- Introduced onMapLoaded, onMapLongTapped, onCustomStyleLoaded, and onCustomStyleLoadFailed callbacks.
- Refactored
NMessageabledeserialization methods and improved version reporting in the info dialog.
Reviewed Changes
Copilot reviewed 140 out of 173 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| version.json | Updated auto-generated version and native dependency versions. |
| tool/update_version.dart | Added JSON generation logic and better error messages. |
| pubspec.yaml | Bumped plugin version and lints version; updated assets list. |
| lib/src/widget/map_widget.dart | Added new UI layer, lifecycle callbacks, and control widgets (scale bar, location). |
| lib/src/widget/info/info_dialog.dart | Switched to reading version.json for plugin & native versions; added dependency map. |
| lib/src/util/widget_to_image.dart | Made size parameter optional and handled null case. |
| lib/src/util/location/my_location_tracker.dart | New location tracker abstraction with lifecycle management. |
| lib/src/type/.../overlay & geo & camera files | Migrated _fromMessageable to fromMessageable, added @internal markers. |
| ios/flutter_naver_map/... | Added Swift callbacks for new events; updated custom style handling. |
Comments suppressed due to low confidence (5)
lib/src/widget/map_widget.dart:117
- [nitpick] The flag name
isUpdatedBeforeMapReadyWithUpdateQueueis very long and unclear; consider renaming to something likehasAppliedPendingUpdatesfor readability.
bool isUpdatedBeforeMapReadyWithUpdateQueue = false;
version.json:3
- The
package_versioninversion.jsonremains a-dev.5suffix whilepubspec.yamlis1.4.0; synchronize these to avoid confusion for consumers.
"package_version": "1.4.0-dev.5",
lib/src/widget/map_widget.dart:281
- New
onCustomStyleLoadedandonCustomStyleLoadFailedcallbacks lack associated unit or integration tests for failure and success paths.
void onMapLoaded() async {
tool/update_version.dart:37
- Throwing raw strings reduces stack trace clarity; consider throwing a specific Exception subclass (e.g.,
FileSystemException) with a descriptive message.
throw "Could not find pubspec.yaml";
lib/src/widget/map_widget.dart:165
- Original code applied both
contentPaddingandlogoMargin; replacing with zero may misalign the logo. Restore appropriate padding when positioning the logo.
left: align.isLeft ? 0 : null,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.