Skip to content

Conversation

@note11g
Copy link
Owner

@note11g note11g commented May 30, 2025

Add New sdk features.

  • NaverMap.onMapLongTapped
  • NPolygonOverlay.outlinePattern

*NaverMap.onMapLoaded is already added with #315

@note11g note11g requested a review from Copilot May 30, 2025 00:19
@note11g note11g mentioned this pull request May 29, 2025
11 tasks
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for long-tap map events and customizable polygon outline patterns across iOS, Android, and Dart.

  • Introduce onMapLongTapped callback in platform event delegates and controllers
  • Add DisplayUtil for consistent dp↔px conversion and migrate image scaling
  • Support outlinePattern for polygon and polyline overlays (iOS & Android)

Reviewed Changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ios/Classes/view/NaverMapViewEventDelegate.swift Handle long-tap events and forward to Flutter
ios/Classes/util/DisplayUtil.swift New utility for screen-scale–aware dp↔px conversion
ios/Classes/util/CalcUtil.swift Convert class to struct for consistency
ios/Classes/model/map/overlay/overlay/NPolylineOverlay.swift Switch pattern conversion to use double values
ios/Classes/model/map/overlay/overlay/NPolygonOverlay.swift Add outlinePatternPx and apply to polygon overlay
ios/Classes/model/map/overlay/NOverlayImage.swift Use DisplayUtil.scale when scaling overlay images
ios/Classes/controller/overlay/handler/PolygonOverlayHandler.swift Extend protocol to support outline pattern
ios/Classes/controller/overlay/OverlayController.swift Implement setOutlinePattern for polygon and adjust polyline pattern
ios/Classes/controller/NaverMapController.swift Forward onMapLongTapped to Dart channel
ios/Classes/controller/NaverMapControlSender.swift Declare onMapLongTapped in sender protocol
example/lib/main.dart Wire onMapLongTapped callback in example app
example/lib/design/theme.dart Update snackbar theme for example app
android/.../view/NaverMapView.kt Register/unregister long-tap listener
android/.../overlay/overlay/NPolylineOverlay.kt Change patternDp from Int to Double
android/.../overlay/overlay/NPolygonOverlay.kt Add outlinePatternDp and set it on overlay
android/.../converter/DefaultTypeConverter.kt Enhance asDouble to accept Int
android/.../controller/overlay/handler/PolygonOverlayHandler.kt Add handler entry for outlinePattern
android/.../controller/overlay/OverlayController.kt Override setOutlinePattern for polygon
android/.../controller/NaverMapController.kt Invoke Dart for onMapLongTapped
android/.../controller/NaverMapControlSender.kt Add onMapLongTapped to control-sender interface
Comments suppressed due to low confidence (2)

ios/Classes/util/DisplayUtil.swift:15

  • Consider adding a unit test for dpToPx to verify correct conversion across different screen scales.
static func dpToPx(dp: Double) -> Double {

ios/Classes/util/DisplayUtil.swift:16

  • In Swift, multiplying a Double by a CGFloat isn’t allowed directly—cast scale to Double (e.g. return dp * Double(scale)) to avoid a compile error.
return dp * scale

@note11g note11g merged commit bcdc6e3 into dev/1.4.0 May 30, 2025
@note11g note11g deleted the feature/sdk branch May 30, 2025 01:56
@note11g note11g restored the feature/sdk branch May 30, 2025 01:57
@note11g note11g mentioned this pull request Jul 12, 2025
@note11g note11g deleted the feature/sdk branch July 12, 2025 16:36
@note11g note11g mentioned this pull request Jul 14, 2025
@github-actions github-actions bot mentioned this pull request Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants