-
Notifications
You must be signed in to change notification settings - Fork 83
Add new sdk features (3.21.0) #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olHandler.onMapLongTapped` too.
…ender`, `NaverMapViewEventDelegate`)
…ControlSender`, `NaverMapView.setMapEventListeners`)
…Tapped`) with snackbar
…th `NPolylineOverlay.pattern`)
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for long-tap map events and customizable polygon outline patterns across iOS, Android, and Dart.
- Introduce
onMapLongTappedcallback in platform event delegates and controllers - Add
DisplayUtilfor consistent dp↔px conversion and migrate image scaling - Support
outlinePatternfor polygon and polyline overlays (iOS & Android)
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ios/Classes/view/NaverMapViewEventDelegate.swift | Handle long-tap events and forward to Flutter |
| ios/Classes/util/DisplayUtil.swift | New utility for screen-scale–aware dp↔px conversion |
| ios/Classes/util/CalcUtil.swift | Convert class to struct for consistency |
| ios/Classes/model/map/overlay/overlay/NPolylineOverlay.swift | Switch pattern conversion to use double values |
| ios/Classes/model/map/overlay/overlay/NPolygonOverlay.swift | Add outlinePatternPx and apply to polygon overlay |
| ios/Classes/model/map/overlay/NOverlayImage.swift | Use DisplayUtil.scale when scaling overlay images |
| ios/Classes/controller/overlay/handler/PolygonOverlayHandler.swift | Extend protocol to support outline pattern |
| ios/Classes/controller/overlay/OverlayController.swift | Implement setOutlinePattern for polygon and adjust polyline pattern |
| ios/Classes/controller/NaverMapController.swift | Forward onMapLongTapped to Dart channel |
| ios/Classes/controller/NaverMapControlSender.swift | Declare onMapLongTapped in sender protocol |
| example/lib/main.dart | Wire onMapLongTapped callback in example app |
| example/lib/design/theme.dart | Update snackbar theme for example app |
| android/.../view/NaverMapView.kt | Register/unregister long-tap listener |
| android/.../overlay/overlay/NPolylineOverlay.kt | Change patternDp from Int to Double |
| android/.../overlay/overlay/NPolygonOverlay.kt | Add outlinePatternDp and set it on overlay |
| android/.../converter/DefaultTypeConverter.kt | Enhance asDouble to accept Int |
| android/.../controller/overlay/handler/PolygonOverlayHandler.kt | Add handler entry for outlinePattern |
| android/.../controller/overlay/OverlayController.kt | Override setOutlinePattern for polygon |
| android/.../controller/NaverMapController.kt | Invoke Dart for onMapLongTapped |
| android/.../controller/NaverMapControlSender.kt | Add onMapLongTapped to control-sender interface |
Comments suppressed due to low confidence (2)
ios/Classes/util/DisplayUtil.swift:15
- Consider adding a unit test for
dpToPxto verify correct conversion across different screen scales.
static func dpToPx(dp: Double) -> Double {
ios/Classes/util/DisplayUtil.swift:16
- In Swift, multiplying a Double by a CGFloat isn’t allowed directly—cast
scaleto Double (e.g.return dp * Double(scale)) to avoid a compile error.
return dp * scale
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add New sdk features.
NaverMap.onMapLongTappedNPolygonOverlay.outlinePattern*
NaverMap.onMapLoadedis already added with #315