Miscellaneous Fixes

LabApi/Features/Permissions/PermissionsExtensions.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using CommandSystem;
 using LabApi.Features.Wrappers;
+using RemoteAdmin;
 
 namespace LabApi.Features.Permissions;
 
@@ -20,11 +21,11 @@ public static string[] GetPermissions(this ICommandSender sender) =>
 
     /// <inheritdoc cref="IPermissionsProvider.HasPermissions"/>
     public static bool HasPermissions(this ICommandSender sender, params string[] permissions) =>
-        Player.Get(sender)?.HasPermissions(permissions) ?? false;
+        Player.Get(sender)?.HasPermissions(permissions) ?? sender is not PlayerCommandSender;
 
     /// <inheritdoc cref="IPermissionsProvider.HasAnyPermission"/>
     public static bool HasAnyPermission(this ICommandSender sender, params string[] permissions) =>
-        Player.Get(sender)?.HasAnyPermission(permissions) ?? false;
+        Player.Get(sender)?.HasAnyPermission(permissions) ?? sender is not PlayerCommandSender;
 
     /// <inheritdoc cref="IPermissionsProvider.AddPermissions"/>
     public static void AddPermissions(this ICommandSender sender, params string[] permissions) =>

LabApi/Features/Permissions/Providers/DefaultPermissionsProvider.cs

@@ -167,14 +167,14 @@ private void ReloadPermissions()
             permissionsGroup.SpecialPermissionsSuperset.Clear();
             foreach (string permission in permissionsGroup.Permissions)
             {
-                if (permission == "*")
+                if (permission == ".*")
                 {
                     permissionsGroup.IsRoot = true;
                     // We don't have to continue.
-                    return;
+                    break;
                 }
 
-                if (!permission.Contains("."))
+                if (!permission.Contains(".*"))
                     continue;
 
                 int index = permission.LastIndexOf(".", StringComparison.Ordinal);

LabApi/Features/Wrappers/Players/Player.cs

@@ -463,7 +463,7 @@ public Item? CurrentItem
     /// <summary>
     /// Gets the <see cref="Item">items</see> in the player's inventory.
     /// </summary>
-    public IEnumerable<Item?> Items => Inventory.UserInventory.Items.Values.Select(Item.Get);
+    public IEnumerable<Item> Items => Inventory.UserInventory.Items.Values.Select(Item.Get)!;
 
     /// <summary>
     /// Gets the player's Reserve Ammo.
@@ -1169,7 +1169,7 @@ public void RemoveItem(ItemType item, int maxAmount = 1)
     public List<Pickup> DropAllItems()
     {
         List<Pickup> items = ListPool<Pickup>.Shared.Rent();
-        foreach (Item item in Items)
+        foreach (Item item in Items.ToArray())
             items.Add(DropItem(item));
 
         return items;
@@ -1221,7 +1221,7 @@ public List<AmmoPickup> DropAllAmmo()
     /// </summary>
     public void ClearItems()
     {
-        foreach (Item item in Items)
+        foreach (Item item in Items.ToArray())
             RemoveItem(item);
     }