Skip to content

Miscellaneous Fixes - #84

Merged
ImBeryl merged 6 commits into
devfrom
misc-fixes
May 13, 2025
Merged

Miscellaneous Fixes #84
ImBeryl merged 6 commits into
devfrom
misc-fixes

Conversation

@x3rt

@x3rt x3rt commented Apr 27, 2025

Copy link
Copy Markdown
Contributor

Changes

  • Player#DropAllItems no longer throws an InvalidOperationException
  • Player#ClearItems no longer throws an InvalidOperationException
  • Player#Items no longer returns an Enumerable of nullable Items - as ItemBase itself is not null in InventoryInfo
    • Setting a groups permission to just * would previously throw an error
    • Using "*" or '*' would not work as it would interpret the entire string
  • DefaultPermissionsProvider now uses .* for root permission
  • DefaultPermissionsProvider ReloadPermissions now breaks out of the current for-loop instead of returning early out of the entire method
  • PermissionsExtensions now allows the server-console to run commands

@x3rt x3rt self-assigned this Apr 27, 2025

@ImBeryl ImBeryl left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would look into maybe replacing the array conversion but otherwise great!

Comment thread LabApi/Features/Wrappers/Players/Player.cs
Comment thread LabApi/Features/Wrappers/Players/Player.cs
@ImBeryl
ImBeryl merged commit 8586c75 into dev May 13, 2025
@ImBeryl
ImBeryl deleted the misc-fixes branch May 13, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants