Skip to content

fix: update to gcc-12 #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix: update to gcc-12 #74

merged 1 commit into from
Feb 4, 2025

Conversation

richardlau
Copy link
Member

gcc-12 is the minimum supported compiler version since Node.js 23.

Refs: nodejs/node#54338
Fixes: #72

gcc-12 is the minimum supported compiler version since Node.js 23.

Refs: nodejs/node#54338
@richardlau
Copy link
Member Author

(Untested, just did a global replace of -10 to -12.)

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's test it then! thanks @richardlau

@rvagg rvagg merged commit 9fa4bee into main Feb 4, 2025
5 checks passed
@rvagg rvagg deleted the gcc-12 branch February 4, 2025 01:29
@rvagg
Copy link
Member

rvagg commented Feb 4, 2025

seems to have worked as of now anyway; a failure on armhf that I can't see logs for so I don't know about that one https://launchpad.net/~openjs/+snap/nodeedge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edge (main branch) builds failing, needs investigation
2 participants