Add benchmark script #156
Merged
Add benchmark script #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarking: Commit script for running subset of benchmarks to test a PR Squashing commits: * Adding prototype for running test against a pr * Setting to use default RUNS too * Addressing points and also setting default runs to 30 to match the scripts in node/benchmark * Updating usage * Rework to make it less hacky
PR-URL: nodejs/benchmarking#194 Reviewed-By: Michael Dawson <mhdawson@ca.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* src: allow 3 way merge for bench runs Add 3 way merge option so that more PR's can be tested with this job https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/ PR-URL: nodejs/benchmarking#287 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
* add compiler selection Fixes: nodejs/benchmarking#301
rluvaton
force-pushed
the
add-benchmark-script
branch
from
d7f3492
to
dc76c1e
Compare
mcollina
requested changes
Apr 8, 2024
| fileName=output`date +%d%m%y-%H%M%S`.csv | ||
| echo "Output will be saved to $fileName" | ||
| pwd | ||
| ./node-master benchmark/compare.js --old ./node-master --new ./node-pr $FILTER $RUNS -- $CATEGORY | tee $fileName |
There was a problem hiding this comment.
Please add the CPUSET instruction.
There was a problem hiding this comment.
I wanted to add in different pr, just creating this with the history of the original file
rluvaton
force-pushed
the
add-benchmark-script
branch
from
dc76c1e
to
d0958c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from https://github.com/nodejs/benchmarking/blob/59861388c1c66a3b91b2696a9c1709f4767be672/experimental/benchmarks/community-benchmark/run.sh
Ref: nodejs/build#3657 (comment)
Next pr will add the CPU pinning