Skip to content
This repository has been archived by the owner on Nov 28, 2020. It is now read-only.

select-compiler in benchmark script #301

Closed
rvagg opened this issue Nov 20, 2019 · 2 comments · Fixed by #302
Closed

select-compiler in benchmark script #301

rvagg opened this issue Nov 20, 2019 · 2 comments · Fixed by #302

Comments

@rvagg
Copy link
Member

rvagg commented Nov 20, 2019

microbenchmark runs are now failing since the V8 upgrade, see nodejs/node#30547 (comment), e.g. https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/458/

It needs select-compiler.sh to be run after checking out nodejs/node (since it checks Node version) so it can't be done in Jenkins and needs to be done here.

This file: https://github.com/nodejs/benchmarking/blob/master/experimental/benchmarks/community-benchmark/run.sh

Needs to have this somewhere after nodejs/node clone:

# select the appropriate compiler
curl -sLO https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/select-compiler.sh
. ./select-compiler.sh
mhdawson added a commit to mhdawson/benchmarking that referenced this issue Nov 21, 2019
@mhdawson
Copy link
Member

The benchmark job turns out to be a bit of a snowflake. Took me a while to figure out why the right compiler was not being selected.

It does not use a configuration matrix. For x64 select compiler uses the $nodes value which ends up not being set if you don't have a configuration matrix.

Going to manually set $nodes in the job for now.

We should probably refactor the job to make it more consistent with the other community jobs, but I don't have the cycles to do that now.

mhdawson added a commit that referenced this issue Nov 21, 2019
* add compiler selection

Fixes: #301
@mhdawson
Copy link
Member

@rvagg I think I've fixed it. The PR's you'd tried to run it on before did not run but it looked like an issue applying the PR. Doing a run against master on a current PR seemed ok.

rluvaton pushed a commit to nodejs/performance that referenced this issue Apr 8, 2024
rluvaton pushed a commit to nodejs/performance that referenced this issue Apr 8, 2024
rluvaton pushed a commit to nodejs/performance that referenced this issue Apr 8, 2024
rluvaton pushed a commit to nodejs/performance that referenced this issue Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants