Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove &socket from test_inspector_socket #8717

Closed
wants to merge 1 commit into from
Closed

test: remove &socket from test_inspector_socket #8717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: remove &socket from test_inspector_socket 
What is `socket`, where did it came from? We don't know.

On a more serious note: `socket` is function from `sys/socket.h`. There
is no way casting it to structure could yield any useful results.
  • Loading branch information
@indutny
indutny committed Sep 22, 2016
commit f651625f748ace91ccd1cefe8fa84a5d13c6ed94
3 changes: 0 additions & 3 deletions test/cctest/test_inspector_socket.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,6 @@ TEST_F(InspectorSocketTest, ExtraTextBeforeRequest) {
SPIN_WHILE(last_event != kInspectorHandshakeFailed);
expect_handshake_failure();
EXPECT_EQ(uv_is_active(reinterpret_cast<uv_handle_t*>(&client_socket)), 0);
EXPECT_EQ(uv_is_active(reinterpret_cast<uv_handle_t*>(&socket)), 0);
}

TEST_F(InspectorSocketTest, ExtraLettersBeforeRequest) {
Expand All @@ -516,7 +515,6 @@ TEST_F(InspectorSocketTest, ExtraLettersBeforeRequest) {
SPIN_WHILE(last_event != kInspectorHandshakeFailed);
expect_handshake_failure();
EXPECT_EQ(uv_is_active(reinterpret_cast<uv_handle_t*>(&client_socket)), 0);
EXPECT_EQ(uv_is_active(reinterpret_cast<uv_handle_t*>(&socket)), 0);
}

TEST_F(InspectorSocketTest, RequestWithoutKey) {
Expand All @@ -531,7 +529,6 @@ TEST_F(InspectorSocketTest, RequestWithoutKey) {
SPIN_WHILE(last_event != kInspectorHandshakeFailed);
expect_handshake_failure();
EXPECT_EQ(uv_is_active(reinterpret_cast<uv_handle_t*>(&client_socket)), 0);
EXPECT_EQ(uv_is_active(reinterpret_cast<uv_handle_t*>(&socket)), 0);
}

TEST_F(InspectorSocketTest, KillsConnectionOnProtocolViolation) {
Expand Down