Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove &socket from test_inspector_socket #8717

Closed
wants to merge 1 commit into from

Conversation

indutny
Copy link
Member

@indutny indutny commented Sep 22, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

What is socket, where did it came from? We don't know.

On a more serious note: socket is function from sys/socket.h. There
is no way casting it to structure could yield any useful results.

R= @nodejs/v8

What is `socket`, where did it came from? We don't know.

On a more serious note: `socket` is function from `sys/socket.h`. There
is no way casting it to structure could yield any useful results.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 22, 2016
@indutny
Copy link
Member Author

indutny commented Sep 22, 2016

Please let me know if I missed something obvious here...

@indutny
Copy link
Member Author

indutny commented Sep 22, 2016

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don’t think you’re missing anything, the address of socket(3) does end up in the cctest executable here.

@indutny
Copy link
Member Author

indutny commented Sep 22, 2016

Thanks!

@ofrobots
Copy link
Contributor

/cc @nodejs/v8-inspector

@mscdex mscdex added the inspector Issues and PRs related to the V8 inspector protocol label Sep 22, 2016
@eugeneo
Copy link
Contributor

eugeneo commented Sep 22, 2016

This is a pending CL that also fixes this: #8505

(There used to be a variable socket that got removed at some point in the refactorings - that's when the function pointer came into the play)

@indutny
Copy link
Member Author

indutny commented Sep 22, 2016

Oh, cool! Closing this in a favor of #8505 then!

@indutny indutny closed this Sep 22, 2016
@indutny indutny deleted the fix/inspector-cctest-failure branch September 22, 2016 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants