Skip to content

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 30, 2025

Opening as draft to test it. Nix changes will be taken to a separate PR.

Triggered by #60902

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Nov 30, 2025
@aduh95 aduh95 marked this pull request as draft November 30, 2025 16:04
@aduh95 aduh95 marked this pull request as ready for review November 30, 2025 16:14
@aduh95 aduh95 marked this pull request as draft November 30, 2025 16:15
@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.42%. Comparing base (768f3ba) to head (490651f).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/process/pre_execution.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60906      +/-   ##
==========================================
- Coverage   88.56%   88.42%   -0.14%     
==========================================
  Files         703      703              
  Lines      208291   208293       +2     
  Branches    40169    40161       -8     
==========================================
- Hits       184472   184187     -285     
- Misses      15831    16188     +357     
+ Partials     7988     7918      -70     
Files with missing lines Coverage Δ
src/node_config.cc 96.66% <100.00%> (+0.11%) ⬆️
lib/internal/process/pre_execution.js 98.27% <0.00%> (-0.27%) ⬇️

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 force-pushed the fix-nosqlite-tests branch from 7d9e358 to 98213cb Compare November 30, 2025 18:12
@aduh95 aduh95 marked this pull request as ready for review November 30, 2025 18:12
@aduh95 aduh95 marked this pull request as draft November 30, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants