Skip to content

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 30, 2025

Triggered by #60902 and #60906

  • adding withAmaro, withSQLite, and withSSL parameters (to be consistent with the withTemporal one that was recently added, and analogeous to --without-amaro, --without-sqlite, and --without-ssl configure.py flags). There are many other configure.py flags that do not have equivalent Nix parameter, however those 3 are special as they require a different build environment (that's not yet true for Amaro, but the long term goal is to include it as a native library instead of the current WASM approach)
  • reorganizing the list of parameters (the current order doesn't have much logic to it, the file becomes much more readable when the parameters are grouped by their purpose)
  • fixing a bug when passing --arg ccache null would not work as expected
  • making use of lib.optional, lib.optionals, and lib.optionalString more consistent
  • introducing a local needsRustCompiler as I expect we'll add more Rust compiled dependencies (currently it's only temporal_capi)

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 30, 2025
@aduh95 aduh95 added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants