build: add flag to compile V8 with Temporal support

[targos]

It won't work until we build temporal_capi, but is a step forward.

Refs: #58730

[nodejs-github-bot]

Review requested:

• @nodejs/gyp
• @nodejs/v8-update

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70153/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6852/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6852/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6852/

[aduh95]

I'm getting ../../deps/v8/src/objects/js-temporal-objects.h:27:10: fatal error: 'torque-generated/src/objects/js-temporal-objects-tq.inc' file not found, do we need to add an instruction, in v8.gyp maybe?

[targos]

As written in the commit message, this won't work.

[targos]

I don't want to be blocking progress on this work, so I'm trying to include the results of my experiments in small steps so that someone else can build on it (and doesn't have to start from scratch)

[aduh95]

The commit message makes it sound like the only thing I need to do is to provide a build version of temporal_rs, which is what I've done but I'm getting the error above, so I do think something's missing here. I'm suggesting v8.gyp in case this was somewhat similar to the wasm and icu integration:

node/tools/v8_gypfiles/v8.gyp

Lines 24 to 35 in a201250

	'conditions': [
	['v8_enable_i18n_support==1', {
	'torque_files': [
	'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "torque_files =.*?v8_enable_i18n_support.*?torque_files \\+= ")',
	],
	}],
	['v8_enable_webassembly==1', {
	'torque_files': [
	'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "torque_files =.*?v8_enable_webassembly.*?torque_files \\+= ")',
	],
	}],
	],

[targos]

There are many things missing, and I intend to do other PRs after this one. I thought it would be easier to get the changes in small steps 😄.
I don't have enough time to argue on this. If someone wants to bring Temporal in Node.js, feel free to look at the commits I made in https://github.com/targos/node/tree/v8-temporal

[aduh95]

FWIW if I apply the following diff:

diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp
index c3ec7e3ee92..71d27300d66 100644
--- a/tools/v8_gypfiles/v8.gyp
+++ b/tools/v8_gypfiles/v8.gyp
@@ -27,6 +27,11 @@
           '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn"  "torque_files =.*?v8_enable_i18n_support.*?torque_files \\+= ")',
         ],
       }],
+      ['v8_enable_temporal_support==1', {
+        'torque_files': [
+          '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn"  "torque_files =.*?v8_enable_temporal_support.*?torque_files \\+= ")',
+        ],
+      }],
       ['v8_enable_webassembly==1', {
         'torque_files': [
           '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn"  "torque_files =.*?v8_enable_webassembly.*?torque_files \\+= ")',

I get further, but I'm getting another error: deps/v8/src/objects/js-date-time-format.cc:949:10: error: use of undeclared identifier 'HijriSimulatedMecca'

[targos]

https://github.com/targos/node/tree/v8-temporal contains this change and other similar ones.

[legendecas]

HijriSimulatedMecca was removed in temporal_rs 0.1.1. We should continue use temporal_rs 0.1.0 in this V8 version.

[aduh95]

Chromium is already using v0.1.2, I expect V8 will catch up soon if they haven't already: chromium/chromium@f700ec5

EDIT: indeed, v8/v8@0cbecc1