deps: add support of temporal_rs

[legendecas]

Checked in temporal_rs and build it as a static library with ./configure --v8-enable-temporal-support. The dependencies of temporal_rs are locked with Cargo.lock. Temporal is enabled at runtime with cli flag --harmony-temporal.

This does not use V8's default temporal_rs checkout from https://chromium.googlesource.com/chromium/src/third_party/rust/ as it contains all the crates that chromium uses, but V8 may not use them.

For follow-ups, the temporal_capi needs to respect Node's ICU and toolchain settings. Additionally, we may want to force cargo to work in offline mode.

Refs: #58730
Refs: #60693

[nodejs-github-bot]

Review requested:

• @nodejs/security-wg
• @nodejs/build

[marco-ippolito]

I dont know if its a good idea,
might be a terrible idea, I'm not a rust expert, but I know technically we could vendor the rust dependencies with https://doc.rust-lang.org/cargo/commands/cargo-vendor.html
so we keep dont have to download them from the internet?

[richardlau]

Yeah, I think ultimately (not necessarily to start with if it is opt-in but definitely before it becomes enabled by default) we need a way to be able to build temporal offline (e.g. from the Node.js source tarball).

[legendecas]

I agree. It's in the roadmap as the OP mentioned.

[legendecas]

Blocked on #60701 to get the v8.gyp change landed first.

[joyeecheung]

Just curious, have you checked the binary size difference?

[legendecas]

Just curious, have you checked the binary size difference?

For release builds on macOS locally, the size difference between with temporal_rs and without is 129 MB vs 125 MB, that is about 4MB increase.

@marco-ippolito @richardlau @joyeecheung @nodejs/build please take a look again, thanks!

[marco-ippolito]

LGTM

[aduh95]

8eaa243 could also include the following diff:

diff --git a/.github/workflows/test-shared.yml b/.github/workflows/test-shared.yml
index 7558b1633eb..23a8e09f4f1 100644
--- a/.github/workflows/test-shared.yml
+++ b/.github/workflows/test-shared.yml
@@ -22,2 +22,3 @@ on:
       - deps/sqlite/**
+      - deps/temporal/**
       - deps/uv/**
@@ -53,2 +54,3 @@ on:
       - deps/sqlite/**
+      - deps/temporal/**
       - deps/uv/**
diff --git a/Makefile b/Makefile
index bccbac90bca..95df702bdd0 100644
--- a/Makefile
+++ b/Makefile
@@ -1235,2 +1235,3 @@ ifeq ($(SKIP_SHARED_DEPS), 1)
 	$(RM) -r $(TARNAME)/deps/sqlite
+	$(RM) -r $(TARNAME)/deps/temporal
 	$(RM) -r $(TARNAME)/deps/uv

And 804c425:

diff --git a/shell.nix b/shell.nix
index b22e3d6d11e..faa3446d80c 100644
--- a/shell.nix
+++ b/shell.nix
@@ -33,5 +33,9 @@ pkgs.mkShell {
   ]
   ++ devTools
-  ++ benchmarkTools;
+  ++ benchmarkTools
+  ++ pkgs.lib.optionals (withTemporal && !builtins.hasAttr "temporal_capi" sharedLibDeps) [
+    pkgs.cargo
+    pkgs.rustc
+  ];
 
   shellHook =

Not blocking, can happen in a follow up

[joyeecheung]

temporal_rs uses ICU4X (rust-based components) not ICU4C (the big ICU library we link to for Intl)

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70276/

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.03%. Comparing base (7fd3688) to head (a02f7dc).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #60703      +/-   ##
==========================================
- Coverage   88.56%   88.03%   -0.53%     
==========================================
  Files         703      703              
  Lines      208254   208247       -7     
  Branches    40156    40075      -81     
==========================================
- Hits       184430   183321    -1109     
- Misses      15828    16883    +1055     
- Partials     7996     8043      +47     

see 116 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70288/

[nodejs-github-bot]

Landed in 189a0a7...482b191