2025-11-11, Version 24.11.1 'Krypton' (LTS) #60622
Merged
+39,026
−18,341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #60467 Refs: nodejs/nodejs.org#8280 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
PR-URL: #59999 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #60120 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Add file attribute normalization in JUnit test output transform to support upcoming file attribute feature in JUnit XML reporter. PR-URL: #59432 Fixes: #59422 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
PR-URL: #60134 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
PR-URL: #60135 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #59853 Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
PR-URL: #60144 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #60148 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Corrects the misspelling of "privateSynbol" to "privateSymbol". PR-URL: #60155 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #59890 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #60163 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #60173 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #60065 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
...and other minor cleanups PR-URL: #60061 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
* Track memory held by the Lock instance * Clean up some Utf8/TwoByteString handling PR-URL: #60061 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #60179 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #60168 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #60182 Refs: https://discord.com/channels/425824580918181889/425824580918181891/1425966053242048584 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #60209 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #60208 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
Fixes the constructor name in the stack tree for _errnoException. PR-URL: #60156 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
PR-URL: #60219 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
PR-URL: #60224 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
PR-URL: #60225 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #60318 Fixes: #59031 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #60379 Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #60364 Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7003082 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
PR-URL: #60243 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
PR-URL: #59734 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The previous cpu.sh script was minimal. This change makes it a more robust and safe utility for managing CPU governors during benchmarks. The script now includes: - Checks to ensure it only runs on Linux with root privileges. - A `reset` command to restore the CPU governor to a dynamically detected system default. - A `get` command to check the current governor for all cores. - An improved usage guide and clearer feedback messages. PR-URL: #60162 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #59883 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Corrects the misspelling of "proecss" to "process". PR-URL: #60132 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Previously the addAfterUserSerailizeCallback() wasn't ready to be used for building the built-in snapshot. This patch initializes the callbacks at the time lib/internal/v8/start_snapshot.js is loaded, so that these callbacks get run correctly when building the built-in snapshot. Currently when building the built-in snapshot, addAfterUserSerializeCallback() is only used by createUnsafeBuffer(), other usages can only come from user-land snapshots, which is covered by tests, but what gets run by the built-in snapshot building process is less visible, and the path used by createUnsafeBuffer() isn't reliably visible in user land either. This adds an internal usage counter in debug builds to verify this path when building the built-in snapshot. PR-URL: #60434 Fixes: #60423 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
PR-URL: #60550 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
nodejs-github-bot
added a commit
that referenced
this pull request
Nov 7, 2025
Notable changes: PR-URL: #60622
github-actions
bot
added
release
Collaborator
|
Review requested:
|
aduh95
force-pushed
the
v24.11.1-proposal
branch
from
2a93bbb to
18aefb2
Compare
aduh95
approved these changes
Nov 7, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
cjihrig
approved these changes
Nov 8, 2025
richardlau
approved these changes
Nov 10, 2025
aduh95
pushed a commit
that referenced
this pull request
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The known issue relating to
Buffer.allocUnsafeincorrectly zero-filling buffers has now been addressed and now returns uninitialized memory as documented in theBuffer.allocUnsafedocumentation.Commits
0a15ccf3f4] - benchmark: improve cpu.sh for safety and usability (Nam Yooseong) #60162a1c7d1dac9] - benchmark: add benchmark for leaf source text modules (Joyee Cheung) #6020599e2acf46b] - benchmark: add vm.SourceTextModule benchmark (Joyee Cheung) #59396c01c72b407] - benchmark: use non-deprecated WriteUtf8V2 method (Michaël Zasso) #60173a42dbd138e] - build: ibmi follow aix visibility (SRAVANI GUNDEPALLI) #603605673a54a5d] - build: use call command when calling python configure (Jacob Nichols) #60098c67cb727cb] - build: build v8 with -fvisibility=hidden -fvisibility-inlines-hidden (Joyee Cheung) #56290b03f7b93b1] - build: remove V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE defs (Joyee Cheung) #602962505568531] - build, src: fix include paths for vtune files (Rahul) #5999995330b036f] - crypto: update root certificates to NSS 3.116 (Node.js GitHub Bot) #59956c221d892ef] - deps: update corepack to 0.34.2 (Node.js GitHub Bot) #60550bc00aa4c77] - deps: update simdjson to 4.0.7 (Node.js GitHub Bot) #59883d03b89ec53] - deps: update corepack to 0.34.1 (Node.js GitHub Bot) #60314b7882090de] - deps: update inspector_protocol to af7f5a8173fdbc29f0835ec94395932e328b (Node.js GitHub Bot) #603127007f9dd65] - deps: update googletest to 279f847 (Node.js GitHub Bot) #60219a56aa9ffa8] - deps: upgrade npm to 11.6.2 (npm team) #601680bf8952721] - doc: mention more codemods indeprecations.md(Augustin Mauroy) #602432473ca77f6] - doc: add missing CAA type to dns.resolveAny() & dnsPromises.resolveAny() (Jimmy Leung) #5889939ddd8522e] - doc: useanyforworker_threads.Worker'error' event argumenterr(Jonas Geiler) #60300eaa825fd97] - doc: update decorator documentation to reflect actual policy (Muhammad Salman Aziz) #60288a744e42282] - doc: document wildcard supported by tools/test.py (Joyee Cheung) #60265ec0d5beb09] - doc: add --heap-snapshot-on-oom to useful v8 flag (jakecastelli) #6026013da0df12a] - doc: fixblob.bytes()heading level (XTY) #602528e771632b7] - doc: fix not working code example in vm docs (Artur Gawlik) #6022470c2080bff] - doc: improve code snippet alternative of url.parse() using WHATWG URL (Steven) #60209beadcf176e] - doc:createSQLTagStore->createTagStore(Aviv Keller) #60182b0da3b9c6a] - doc: use markdown when branch-diff major release (Rafael Gonzaga) #60179688115aa6b] - doc: update teams in collaborator-guide.md and add links (Bart Louwers) #60065923082a064] - doc: disambiguate top-levelworker_threadsmodule exports (René) #598907be4330870] - doc: add known issue to v24.11.0 release notes (Richard Lau) #604674d8f62aeaf] - doc, module: change async customization hooks to experimental (Gerhard Stöbich) #60302d86a118bbd] - http: lazy allocate cookies array (Robert Nagy) #597348c256d4139] - http: fix http client leaky with double response (theanarkh) #60062265e9d59fa] - http2: rename variable to additionalPseudoHeaders (Tobias Nießen) #6020865bec037e2] - http2: do not crash on mismatched ping buffer length (René) #601359b83ef53b7] - inspector: add network payload buffer size limits (Chengzhong Wu) #6023603ac05c458] - inspector: support handshake response for websocket inspection (Shima Ryuhei) #60225aa04f06190] - lib: fix typo in createBlobReaderStream (SeokHun) #601325aea1a429e] - lib: fix constructor in _errnoException stack tree (SeokHun) #601564f7745acc7] - lib: fix typo in QuicSessionStats (SeokHun) #60155f8725861ea] - lib: remove redundant destroyHook checks (Gürgün Dayıoğlu) #60120696c20bf3f] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #6032590434ff99a] - meta: loop userland-migrations in deprecations (Chengzhong Wu) #60299ffbc0ae60a] - module: refactor and clarify async loader hook customizations (Joyee Cheung) #602786ed6062f7d] - module: handle null source from async loader hooks in sync hooks (Joyee Cheung) #59929a2871baed2] - msi: fix WiX warnings (Stefan Stojanovic) #602516199541d67] - src: fix timing of snapshot serialize callback (Joyee Cheung) #6043413b687959a] - src: add COUNT_GENERIC_USAGE utility for tests (Joyee Cheung) #60434a587623b4f] - src: conditionally disable source phase imports by default (Shelley Vohr) #60364e483267995] - src: use cached primordials_string (Sohyeon Kim) #602554c9a64fbaf] - src: replace Environment::GetCurrent with args.GetIsolate (Sohyeon Kim) #60256eb8a0493d1] - src: initial enablement of IsolateGroups (James M Snell) #60254463c6450cf] - src: useUtf8ValueandTwoByteValueinstead of V8 helpers (Anna Henningsen) #60244b370e02789] - src: add a default branch for module phase (Chengzhong Wu) #602614e1c5c5601] - src: make additional cleanups in node locks impl (James M Snell) #60061f00d4c10fc] - src: update locks to use DictionaryTemplate (James M Snell) #600611c8716e97c] - test: increase debugger waitFor timeout on macOS (Chengzhong Wu) #6036717b4f38e9c] - test: put helper in test-runner-output into common (Joyee Cheung) #6033043b9ea8389] - test: fix small compile warning in test_network_requests_buffer.cc (xiaocainiao633) #6028138a62980ad] - test: split test-runner-watch-mode-kill-signal (Joyee Cheung) #6029834e4c8c84f] - test: fix incorrect calculation in test-perf-hooks.js (Joyee Cheung) #602714481feb17b] - test: parallelize test-without-async-context-frame correctly (Joyee Cheung) #6027391ea9b06e0] - test: skip sea tests on x64 macOS (Joyee Cheung) #60250cedba09e60] - test: move sea tests into test/sea (Joyee Cheung) #60250635af55e12] - Revert "test: ensure message event fires in worker message port test" (Luigi Pinca) #6012668f678028e] - test: skip tests that cause timeouts on IBM i (SRAVANI GUNDEPALLI) #60148cc3a70598c] - test: deflake test-fs-promises-watch-iterator (Luigi Pinca) #600603d784dd766] - test: prepare junit file attribute normalization (sangwook) #5943284974d97ad] - test: skip failing test on macOS 15.7+ (Antoine du Hamel) #60419fabf8e4975] - test,crypto: fix conditional SHA3-* skip on BoringSSL (Filip Skokan) #603798faa494bf2] - test,crypto: sha3 algorithms aren't supported with BoringSSL (Shelley Vohr) #60374538a00c0f6] - test,doc: skip --max-old-space-size-percentage on 32-bit platforms (Asaf Federman) #601449ac5dbb694] - test_runner: use module.registerHooks in module mocks (Joyee Cheung) #60326f6ff6e7166] - test_runner: fix suite timeout (Moshe Atlow) #59853455bfeb52d] - test_runner: add junit file attribute support (sangwook) #59432223c5e105d] - tools: update gyp-next to 0.20.5 (Node.js GitHub Bot) #603132949408fc1] - tools: limit inspector protocol PR title length (Chengzhong Wu) #60324b36a898650] - tools: fix inspector_protocol updater (Chengzhong Wu) #60277d60f002b62] - tools: optimize wildcard execution in tools/test.py (Joyee Cheung) #602669d4e422419] - tools: add inspector_protocol updater (Chengzhong Wu) #602452f93a9894f] - tools: use cooldown property correctly (Rafael Gonzaga) #601349468ade95d] - typings: add missing properties and method in Worker (Woohyun Sung) #60257f611ec0a9e] - typings: add missing properties in HTTPParser (Woohyun Sung) #60257301c1347a1] - typings: delete undefined property in ConfigBinding (Woohyun Sung) #6025780fdb3d39b] - typings: add buffer internalBinding typing (방진혁) #601638cb3b77039] - util: use more defensive code when inspecting error objects (Antoine du Hamel) #60139748d4f6430] - util: mark special properties when inspecting them (Ruben Bridgewater) #601316183a759d7] - vm: make vm.Module.evaluate() conditionally synchronous (Joyee Cheung) #602054b8506628f] - win: upgrade Visual Studio workload from 2019 to 2022 (Jiawen Geng) #60318