Skip to content

test: skip failing test on macOS 15.7+ #60419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2025
Merged

test: skip failing test on macOS 15.7+ #60419

merged 2 commits into from
Oct 26, 2025
+2 −0

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 26, 2025

The GHA runners have been updated to the version impacted, blocking PRs from landing.

Refs: #60050

@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x labels Oct 26, 2025
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 26, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov
Copy link

codecov bot commented Oct 26, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.59%. Comparing base (9bfff20) to head (3303b21).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #60419   +/-   ##
=======================================
  Coverage   88.58%   88.59%           
=======================================
  Files         704      704           
  Lines      207777   207777           
  Branches    40033    40025    -8     
=======================================
+ Hits       184068   184085   +17     
+ Misses      15755    15746    -9     
+ Partials     7954     7946    -8

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richardlau richardlau mentioned this pull request Oct 26, 2025
Merged
5 tasks
aduh95
aduh95 commented Oct 26, 2025
View reviewed changes
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69890/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69891/

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 26, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2025
@nodejs-github-bot nodejs-github-bot merged commit 27892ec into nodejs:main Oct 26, 2025
73 of 75 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 27892ec

@aduh95 aduh95 deleted the nodejs-skip-test branch October 26, 2025 18:49
aduh95 added a commit that referenced this pull request Oct 26, 2025
@aduh95
test: skip failing test on macOS 15.7+
7a6542c 
PR-URL: #60419
Refs: #60050
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@github-actions github-actions bot mentioned this pull request Oct 27, 2025
Merged
richardlau pushed a commit that referenced this pull request Oct 29, 2025
@aduh95 @richardlau
test: skip failing test on macOS 15.7+
84974d9 
PR-URL: #60419
Refs: #60050
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@MoLow MoLow MoLow approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 48 hours to land. lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aduh95 @nodejs-github-bot @cjihrig @richardlau @MoLow @jakecastelli