Skip to content

lib: support glob on --watch-path #59478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

lib: support glob on --watch-path #59478

wants to merge 1 commit into from

Conversation

louiellan
Copy link

@louiellan louiellan commented Aug 15, 2025 •
edited by MoLow
Loading

Closes #45182
Closes #59345

This allows glob patterns to be included in the --watch-path option but it does introduce breaking change since there might be instances where developers might have used glob characters when using --watch-path (e.g., file[1].js)

An alternative, non-breaking change would be to add a cli option --watch-pattern in which the PR is here #59345

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Aug 15, 2025
@louiellan louiellan mentioned this pull request Aug 15, 2025
Open
@MoLow MoLow added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 16, 2025
MoLow
MoLow approved these changes Aug 16, 2025
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im in favor of this variaton

@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 16, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68673/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68675/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support file globs with --watch-path
3 participants
@louiellan @nodejs-github-bot @MoLow