-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
lib: adding --watch-pattern to support watching files/dirs with glob
#59345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
louiellan
wants to merge
5
commits into
nodejs:main
Choose a base branch
from
louiellan:glob-on-watch-path
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+134
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59345 +/- ##
==========================================
- Coverage 89.97% 89.36% -0.61%
==========================================
Files 649 654 +5
Lines 192189 192701 +512
Branches 37679 37461 -218
==========================================
- Hits 172915 172212 -703
- Misses 11864 13004 +1140
- Partials 7410 7485 +75
🚀 New features to boost your workflow:
|
0c53c42 to
46be19d
Compare
MoLow
reviewed
Aug 5, 2025
Co-authored-by: Moshe Atlow <moshe@atlow.co.il>
1e1b859 to
c29982b
Compare
--watch-pattern to support watching files/dirs with glob
Author
|
I've added another PR for supporting glob on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45182
This adds the
--watch-patterncli option to Node.js, which allows to watch files and directories with the use of globs. This PR is a non-breaking change opposed to--watch-pathoption supporting globs since there could be instances where some glob characters are used (e.g.,file[1].js) which could be treated as a glob and may cause breakage on existing scripts.