util: hide duplicated stack frames when using util.inspect #59447
Conversation
Long stack traces often have duplicated stack frames from recursive calls. These make it difficult to identify important parts of the stack. This hides the duplicated ones and notifies the user which lines were hidden.
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59447 +/- ##
==========================================
- Coverage 89.88% 89.87% -0.01%
==========================================
Files 656 656
Lines 192947 193266 +319
Branches 37841 37927 +86
==========================================
+ Hits 173427 173699 +272
- Misses 12054 12098 +44
- Partials 7466 7469 +3
🚀 New features to boost your workflow:
|
|
@legendecas it is reflected in form of a comment and the frames are of course kept once. Just the duplicates are removed. |
BridgeAR
added
author ready
github-actions
bot
removed
the
request-ci
|
PTAL |
BridgeAR
removed
the
author ready
| function getDuplicateErrorFrameRanges(frames) { | ||
| // Build a map: frame line -> sorted list of indices where it occurs | ||
| const result = []; | ||
| const lineToPositions = new Map(); |
There was a problem hiding this comment.
these are strings, is Map significantly faster than a null object or SafeMap (or even a $-key-salted normal object) such that this is the best choice?
| } | ||
|
|
||
| // Theoretical maximum range, adjusted while iterating | ||
| let range = positions.at(-1) - i; |
There was a problem hiding this comment.
| let range = positions.at(-1) - i; | |
| let range = positions[positions.length - 1] - i; |
i assume this is faster, and avoids the need for a primordial
| if (gcdRange !== 0) { | ||
| // Add other possible ranges as fallback | ||
| extraSteps ??= new Set(); | ||
| extraSteps.add(gcdRange); |
There was a problem hiding this comment.
similarly, this seems like it could be an object, with ObjectKeys at the end, and it'd be faster than spreading a Set into an array?
There was a problem hiding this comment.
I would be surprised if that's faster, while it will likely not be the major issue (this path is only triggered for some cases and for those, the set / object would contain normally never more than five entries).
There was a problem hiding this comment.
If it's not an issue, can we use SafeMap/SafeSet instead?
Long stack traces often have duplicated stack frames from recursive calls. These make it difficult to identify important parts of the stack. This hides the duplicated ones and notifies the user which lines were hidden.
I believe the wording might still be improved, it would be great to get some input about that.