Skip to content

crypto: move deprecated hash and mgf1Hash options to EOL #58706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jun 14, 2025

Runtime deprecation for ~3 years.

@jasnell jasnell requested review from panva, addaleax and aduh95 June 14, 2025 21:33
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Jun 14, 2025
@jasnell jasnell added semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels Jun 14, 2025
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented Jun 14, 2025

Codecov Report

Attention: Patch coverage is 13.04348% with 20 lines in your changes missing coverage. Please review.

Project coverage is 90.14%. Comparing base (3f6ad56) to head (2eca463).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/crypto/keygen.js 13.04% 18 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58706      +/-   ##
==========================================
- Coverage   90.15%   90.14%   -0.01%     
==========================================
  Files         637      637              
  Lines      188122   188121       -1     
  Branches    36886    36892       +6     
==========================================
- Hits       169595   169584      -11     
- Misses      11271    11278       +7     
- Partials     7256     7259       +3     
Files with missing lines Coverage Δ
lib/internal/crypto/keygen.js 92.59% <13.04%> (-5.44%) ⬇️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

panva and others added 2 commits June 15, 2025 08:45
Co-authored-by: Livia Medeiros <livia@cirno.name>
@panva panva added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jun 15, 2025
Copy link
Member

@panva panva Jun 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may repurpose these tests, drop the "new" options, keep the old ones and assert the message in addition with /is no longer supported/. Update the block comment.

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 16, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 16, 2025
@nodejs-github-bot
Copy link
Collaborator

@bjohansebas bjohansebas added the needs-citgm PRs that need a CITGM CI run. label Jun 16, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. crypto Issues and PRs related to the crypto subsystem. deprecations Issues and PRs related to deprecations. needs-ci PRs that need a full CI run. needs-citgm PRs that need a CITGM CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants