-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
crypto: move deprecated hash and mgf1Hash options to EOL #58706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Runtime deprecation for ~3 years.
Review requested:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58706 +/- ##
==========================================
- Coverage 90.15% 90.14% -0.01%
==========================================
Files 637 637
Lines 188122 188121 -1
Branches 36886 36892 +6
==========================================
- Hits 169595 169584 -11
- Misses 11271 11278 +7
- Partials 7256 7259 +3
🚀 New features to boost your workflow:
|
Co-authored-by: Livia Medeiros <livia@cirno.name>
test/parallel/test-crypto-keygen.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may repurpose these tests, drop the "new" options, keep the old ones and assert the message in addition with /is no longer supported/
. Update the block comment.
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Runtime deprecation for ~3 years.