assert,util: handle invalid dates as equal in deep comparison

[BridgeAR]

Invalid dates are now handled as equal in all deep comparisons.

This is more of a usability improvement than a breaking change, since all invalid dates have always thrown errors when being compared until now.

[nodejs-github-bot]

Review requested:

• @nodejs/performance

[ljharb]

what would have thrown before when comparing two invalid dates? it seems like comparing two invalid dates would have compared as false before, and now will compare as true, which does seem breaking.

[BridgeAR]

@ljharb

> assert.deepStrictEqual(new Date('foo'), new Date('foo'))
Uncaught:
AssertionError [ERR_ASSERTION]: Values have same structure but are not reference-equal:

Invalid Date

    at REPL11:1:8  {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: Invalid Date,
  expected: Invalid Date,
  operator: 'deepStrictEqual'
}

[ljharb]

ohhh right, because it's an assert api, not a predicate. fair enough :-)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.21%. Comparing base (8d603d5) to head (0702320).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57627      +/-   ##
==========================================
- Coverage   90.22%   90.21%   -0.02%     
==========================================
  Files         635      635              
  Lines      187171   187176       +5     
  Branches    36749    36748       -1     
==========================================
- Hits       168877   168852      -25     
- Misses      11069    11115      +46     
+ Partials     7225     7209      -16     

Files with missing lines	Coverage Δ
lib/internal/util/comparisons.js	100.00% <100.00%> (ø)

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65982/

[aduh95]

This needs a rebase

[mcollina]

Lgtm

[mcollina]

lgtm