test: use common.skipIfInspectorDisabled() to skip tests
#58675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
dario-piotrowicz
force-pushed
the
dario/use-skipIfInspectorDisabled-in-tests
branch
from
71324d3 to
da7d9a6
Compare
RaisinTen
approved these changes
Jun 11, 2025
dario-piotrowicz
added
the
request-ci
legendecas
approved these changes
Jun 11, 2025
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58675 +/- ##
==========================================
+ Coverage 90.14% 90.15% +0.01%
==========================================
Files 636 636
Lines 188057 188061 +4
Branches 36897 36903 +6
==========================================
+ Hits 169525 169555 +30
+ Misses 11277 11244 -33
- Partials 7255 7262 +7 🚀 New features to boost your workflow:
|
some test files manually check for `!process.features.inspector` to see if the tests should be skipped, the changes here update those checks to instead use the more appropriate `common.skipIfInspectorDisabled()`
dario-piotrowicz
force-pushed
the
dario/use-skipIfInspectorDisabled-in-tests
branch
from
da7d9a6 to
f6bb399
Compare
dario-piotrowicz
changed the title
common.skipIfInspectorDisable() to skip testscommon.skipIfInspectorDisabled() to skip tests
dario-piotrowicz
added
the
author ready
Ethan-Arrowood
approved these changes
Jun 11, 2025
github-actions
bot
removed
the
request-ci
dario-piotrowicz
added
the
commit-queue
lpinca
approved these changes
Jun 11, 2025
LiviaMedeiros
approved these changes
Jun 12, 2025
nodejs-github-bot
removed
the
commit-queue
|
Landed in 431c04d |
targos
pushed a commit
that referenced
this pull request
Jun 16, 2025
some test files manually check for `!process.features.inspector` to see if the tests should be skipped, the changes here update those checks to instead use the more appropriate `common.skipIfInspectorDisabled()` PR-URL: #58675 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some test files manually check for
!process.features.inspectorto to see if the tests should be skipped, the changes here update those checks to instead use the more appropriatecommon.skipIfInspectorDisabled()