Skip to content

test: use common.skipIfInspectorDisabled() to skip tests #58675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/parallel/test-source-map-enable.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
'use strict';

if (!process.features.inspector) return;

const common = require('../common');
const assert = require('assert');
const { dirname } = require('path');
Expand All @@ -10,6 +8,8 @@ const path = require('path');
const { spawnSync } = require('child_process');
const { pathToFileURL } = require('url');

common.skipIfInspectorDisabled();

const tmpdir = require('../common/tmpdir');
tmpdir.refresh();

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-v8-coverage.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
'use strict';

if (!process.features.inspector) return;

const common = require('../common');
const assert = require('assert');
const fs = require('fs');
const path = require('path');
const { spawnSync } = require('child_process');

common.skipIfInspectorDisabled();

const tmpdir = require('../common/tmpdir');
tmpdir.refresh();

Expand Down
6 changes: 3 additions & 3 deletions test/parallel/test-v8-stop-coverage.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
'use strict';

if (!process.features.inspector) return;

require('../common');
const common = require('../common');
const fixtures = require('../common/fixtures');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fs = require('fs');
const { spawnSync } = require('child_process');

common.skipIfInspectorDisabled();

tmpdir.refresh();
const intervals = 20;

Expand Down
6 changes: 3 additions & 3 deletions test/parallel/test-v8-take-coverage-noop.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
'use strict';

if (!process.features.inspector) return;

require('../common');
const common = require('../common');
const fixtures = require('../common/fixtures');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fs = require('fs');
const { spawnSync } = require('child_process');

common.skipIfInspectorDisabled();

tmpdir.refresh();

// v8.takeCoverage() should be a noop if NODE_V8_COVERAGE is not set.
Expand Down
6 changes: 3 additions & 3 deletions test/parallel/test-v8-take-coverage.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
'use strict';

if (!process.features.inspector) return;

require('../common');
const common = require('../common');
const fixtures = require('../common/fixtures');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fs = require('fs');
const { spawnSync } = require('child_process');

common.skipIfInspectorDisabled();

tmpdir.refresh();
const intervals = 40;
// Outputs coverage when v8.takeCoverage() is invoked.
Expand Down
Loading