Skip to content

src: add web locks api #58666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

src: add web locks api #58666

wants to merge 17 commits into from
+5,030 −0

Conversation

IlyasShabi
Copy link
Contributor

@IlyasShabi IlyasShabi commented Jun 10, 2025 •
edited
Loading

This PR implements the Web Locks API, Locks are used to coordinate access to shared resources across multiple threads.

This implementation is based on previous work in #22719 and #36502, but takes a C++ native approach for better performance and reliability, this solution uses a singleton LockManager with thread-safe data structures to coordinate locks across all workers.

  • Support exclusive and shared modes
  • Support steal option
  • Support ifAvailable option
  • Support signal option
  • Documentation
  • WPT tests
  • Add missing query.https.any.js tests as unit tests
  • Add basic tests

Closes: #22702
Refs: https://w3c.github.io/web-locks

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/startup
  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 10, 2025
@IlyasShabi IlyasShabi changed the title Add web locks api src: add web locks api Jun 10, 2025
@IlyasShabi IlyasShabi marked this pull request as ready for review June 10, 2025 19:47
@codecov Codecov
Copy link

codecov bot commented Jun 10, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 79.20904% with 184 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.02%. Comparing base (fc4a8af) to head (214a58e).
⚠️ Report is 114 commits behind head on main.

Files with missing lines Patch % Lines
src/node_locks.cc 69.41% 100 Missing and 67 partials ⚠️
lib/internal/locks.js 95.22% 14 Missing ⚠️
src/node_locks.h 90.90% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58666      +/-   ##
==========================================
- Coverage   90.09%   90.02%   -0.07%     
==========================================
  Files         645      648       +3     
  Lines      189930   190815     +885     
  Branches    37217    37392     +175     
==========================================
+ Hits       171125   171790     +665     
- Misses      11512    11674     +162     
- Partials     7293     7351      +58
Files with missing lines Coverage Δ
lib/internal/navigator.js 99.37% <100.00%> (+0.04%) ⬆️
lib/worker_threads.js 100.00% <100.00%> (ø)
src/node_binding.cc 82.67% <ø> (ø)
src/node_external_reference.h 100.00% <ø> (ø)
src/node_locks.h 90.90% <90.90%> (ø)
lib/internal/locks.js 95.22% <95.22%> (ø)
src/node_locks.cc 69.41% <69.41%> (ø)

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnell jasnell requested a review from addaleax June 10, 2025 21:00
@jasnell jasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label Jun 10, 2025
jasnell
jasnell reviewed Jun 10, 2025
View reviewed changes
panva
panva reviewed Jun 11, 2025
View reviewed changes
atlowChemi
atlowChemi reviewed Jun 11, 2025
View reviewed changes
mcollina
mcollina approved these changes Jun 14, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Ethan-Arrowood
Ethan-Arrowood approved these changes Jun 16, 2025
View reviewed changes
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm. I looked through the WPT and other tests and they look all good. I reviewed the JS api to make sure it aligns with expectations and analyzed its source. All is good for a first implementation. I did a cursory review of the C++ part as I'm less experienced there, but in general it looks okay too. Nice work!

@panva panva added semver-major PRs that contain breaking changes and should be released in the next major version. and removed semver-minor PRs that contain new features and should be released in the next minor version. labels Jun 16, 2025
@panva
Copy link
Member

panva commented Jun 16, 2025

Adding semver-major PRs that contain breaking changes and should be released in the next major version. as this adds new globals (Lock, LockManager)

@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 16, 2025
panva
panva reviewed Jun 16, 2025
View reviewed changes
@panva panva added web-standards Issues and PRs related to Web APIs and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 16, 2025
@IlyasShabi IlyasShabi requested a review from panva June 17, 2025 09:53
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 17, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 17, 2025
@IlyasShabi
Copy link
Contributor Author

@jasnell @addaleax The CI looks happy after I rebased on main and fix JSDoc. could you approve it again please ? I think it's ready to land

@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 18, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 18, 2025
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/58666
✔  Done loading data for nodejs/node/pull/58666
----------------------------------- PR info ------------------------------------
Title      src: add web locks api (#58666)
Author     Ilyas Shabi <ilyasshabi94@gmail.com> (@IlyasShabi)
Branch     IlyasShabi:web-locks-api -> nodejs:main
Labels     semver-minor, lib / src, notable-change, needs-ci, commit-queue-squash, web-standards
Commits    17
 - worker: add web locks api
 - use WebIDL convertors
 - add lock and lockmanager to globals doc
 - remove lock and lockmanager from globals
 - attemp to atach catch on c++ by defering to next microtask
 - separate promise fulfillment and rejection handlers
 - add cjs/esm code in locks doc
 - add more tests and doc
 - update bootstrap modules
 - fix race condition in wpt and pr comments
 - mark held wpt test as flaky
 - better memory mngmt and error handling
 - fix linter
 - remove unnecessary external and global
 - fix js linter
 - use baseObject
 - fix jsdoc
Committers 1
 - ishabi <ilyasshabi94@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/58666
Fixes: https://github.com/nodejs/node/pull/36502
Refs: https://w3c.github.io/web-locks
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/58666
Fixes: https://github.com/nodejs/node/pull/36502
Refs: https://w3c.github.io/web-locks
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 10 Jun 2025 19:40:42 GMT
   ✔  Approvals: 8
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/58666#pullrequestreview-2928334034
   ✔  - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/58666#pullrequestreview-2932670431
   ✔  - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/58666#pullrequestreview-2935756262
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/58666#pullrequestreview-2962635799
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58666#pullrequestreview-3033790815
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/58666#pullrequestreview-2952109057
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/58666#pullrequestreview-2960196108
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/58666#pullrequestreview-3026973866
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-07-18T13:10:48Z: https://ci.nodejs.org/job/node-test-pull-request/68011/
- Querying data for job/node-test-pull-request/68011/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 58666
From https://github.com/nodejs/node
 * branch                  refs/pull/58666/merge -> FETCH_HEAD
✔  Fetched commits as 0629a175c0fa..214a58e6d7b8
--------------------------------------------------------------------------------
[main 5deb1f6bec] worker: add web locks api
 Author: ishabi <ilyasshabi94@gmail.com>
 Date: Fri May 30 00:57:31 2025 +0200
 70 files changed, 4611 insertions(+)
 create mode 100644 lib/internal/locks.js
 create mode 100644 src/node_locks.cc
 create mode 100644 src/node_locks.h
 create mode 100644 test/fixtures/wpt/interfaces/web-locks.idl
 create mode 100644 test/fixtures/wpt/web-locks/META.yml
 create mode 100644 test/fixtures/wpt/web-locks/README.md
 create mode 100644 test/fixtures/wpt/web-locks/WEB_FEATURES.yml
 create mode 100644 test/fixtures/wpt/web-locks/acquire.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/bfcache/abort.tentative.https.html
 create mode 100644 test/fixtures/wpt/web-locks/bfcache/held.tentative.https.html
 create mode 100644 test/fixtures/wpt/web-locks/bfcache/helpers.js
 create mode 100644 test/fixtures/wpt/web-locks/bfcache/release-across-thread.tentative.https.html
 create mode 100644 test/fixtures/wpt/web-locks/bfcache/release.tentative.https.html
 create mode 100644 test/fixtures/wpt/web-locks/bfcache/sharedworker-multiple.tentative.https.html
 create mode 100644 test/fixtures/wpt/web-locks/clientids.https.html
 create mode 100644 test/fixtures/wpt/web-locks/crashtests/after-worker-termination.https.html
 create mode 100644 test/fixtures/wpt/web-locks/crashtests/iframe-append-2.https.html
 create mode 100644 test/fixtures/wpt/web-locks/crashtests/iframe-append.https.html
 create mode 100644 test/fixtures/wpt/web-locks/crashtests/settle-after-steal.https.html
 create mode 100644 test/fixtures/wpt/web-locks/crashtests/worker-termination.https.html
 create mode 100644 test/fixtures/wpt/web-locks/frames.https.html
 create mode 100644 test/fixtures/wpt/web-locks/held.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/idlharness.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/ifAvailable.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/lock-attributes.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/mode-exclusive.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/mode-mixed.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/mode-shared.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/non-fully-active.https.html
 create mode 100644 test/fixtures/wpt/web-locks/non-secure-context.any.js
 create mode 100644 test/fixtures/wpt/web-locks/opaque-origin.https.html
 create mode 100644 test/fixtures/wpt/web-locks/partitioned-web-locks.tentative.https.html
 create mode 100644 test/fixtures/wpt/web-locks/query-empty.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/query-ordering.https.html
 create mode 100644 test/fixtures/wpt/web-locks/query.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/resource-names.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/resources/helpers.js
 create mode 100644 test/fixtures/wpt/web-locks/resources/iframe-parent.html
 create mode 100644 test/fixtures/wpt/web-locks/resources/iframe.html
 create mode 100644 test/fixtures/wpt/web-locks/resources/parentworker.js
 create mode 100644 test/fixtures/wpt/web-locks/resources/partitioned-parent.html
 create mode 100644 test/fixtures/wpt/web-locks/resources/service-worker.js
 create mode 100644 test/fixtures/wpt/web-locks/resources/sw-controlled-iframe.html
 create mode 100644 test/fixtures/wpt/web-locks/resources/worker.js
 create mode 100644 test/fixtures/wpt/web-locks/secure-context.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/signal.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/steal.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/storage-buckets.tentative.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/workers.https.html
 create mode 100644 test/parallel/test-web-locks-query.js
 create mode 100644 test/parallel/test-web-locks.js
 create mode 100644 test/wpt/status/web-locks.json
 create mode 100644 test/wpt/test-web-locks.js
 create mode 100644 typings/internalBinding/locks.d.ts
[main 62d5507b41] use WebIDL convertors
 Author: ishabi <ilyasshabi94@gmail.com>
 Date: Wed Jun 11 21:10:41 2025 +0200
 5 files changed, 212 insertions(+), 114 deletions(-)
[main 0b4429422d] add lock and lockmanager to globals doc
 Author: ishabi <ilyasshabi94@gmail.com>
 Date: Tue Jun 17 11:52:00 2025 +0200
 1 file changed, 1 insertion(+)
[main eadb345f96] remove lock and lockmanager from globals
 Author: ishabi <ilyasshabi94@gmail.com>
 Date: Wed Jun 18 15:29:44 2025 +0200
 3 files changed, 25 insertions(+), 4 deletions(-)
[main d6c201a6ca] attemp to atach catch on c++ by defering to next microtask
 Author: ishabi <ilyasshabi94@gmail.com>
 Date: Fri Jun 20 15:58:21 2025 +0200
 1 file changed, 3 insertions(+), 1 deletion(-)
[main c3d378b7f6] separate promise fulfillment and rejection handlers
 Author: ishabi <ilyasshabi94@gmail.com>
 Date: Sat Jun 21 11:07:20 2025 +0200
 3 files changed, 54 insertions(+), 38 deletions(-)
[main 53528e74d9] add cjs/esm code in locks doc
 Author: ishabi <ilyasshabi94@gmail.com>
 Date: Sun Jun 22 00:06:08 2025 +0200
 1 file changed, 11 insertions(+), 1 deletion(-)
[main 431cc7c24d] add more tests and doc
 Author: ishabi <ilyasshabi94@gmail.com>
 Date: Sun Jun 22 20:31:50 2025 +0200
 3 files changed, 63 insertions(+), 8 deletions(-)
[main 4ab15d8719] update bootstrap modules
 Author: ishabi <ilyasshabi94@gmail.com>
 Date: Mon Jun 23 17:59:46 2025 +0200
 1 file changed, 2 insertions(+), 1 deletion(-)
[main 16afe6d3ef] fix race condition in wpt and pr comments
 Author: ishabi <ilyasshabi94@gmail.com>
 Date: Thu Jun 26 00:44:24 2025 +0200
 1 file changed, 283 insertions(+), 120 deletions(-)
[main 61a69288ac] mark held wpt test as flaky
 Author: ishabi <ilyasshabi94@gmail.com>
 Date: Thu Jun 26 12:24:57 2025 +0200
 3 files changed, 27 insertions(+), 36 deletions(-)
[main b9c3601618] better memory mngmt and error handling
 Author: ishabi <ilyasshabi94@gmail.com>
 Date: Sun Jun 29 21:38:07 2025 +0200
 3 files changed, 112 insertions(+), 80 deletions(-)
[main 8423174599] fix linter
 Author: ishabi <ilyasshabi94@gmail.com>
 Date: Sun Jun 29 21:44:56 2025 +0200
 1 file changed, 50 insertions(+), 36 deletions(-)
[main eb60ba3cac] remove unnecessary external and global
 Author: ishabi <ilyasshabi94@gmail.com>
 Date: Wed Jul 16 16:38:58 2025 +0200
 1 file changed, 10 insertions(+), 35 deletions(-)
[main 153e27db43] fix js linter
 Author: ishabi <ilyasshabi94@gmail.com>
 Date: Wed Jul 16 16:51:28 2025 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
[main 4b7c781d09] use baseObject
 Author: ishabi <ilyasshabi94@gmail.com>
 Date: Wed Jul 16 23:21:40 2025 +0200
 3 files changed, 65 insertions(+), 25 deletions(-)
[main 1acdfd57cb] fix jsdoc
 Author: ishabi <ilyasshabi94@gmail.com>
 Date: Fri Jul 18 13:55:43 2025 +0200
 1 file changed, 3 insertions(+), 3 deletions(-)
   ✔  Patches applied
There are 17 commits in the PR. Attempting to fixup everything into first commit.
[main 1304cbf740] worker: add web locks api
 Author: ishabi <ilyasshabi94@gmail.com>
 Date: Fri May 30 00:57:31 2025 +0200
 70 files changed, 5030 insertions(+)
 create mode 100644 lib/internal/locks.js
 create mode 100644 src/node_locks.cc
 create mode 100644 src/node_locks.h
 create mode 100644 test/fixtures/wpt/interfaces/web-locks.idl
 create mode 100644 test/fixtures/wpt/web-locks/META.yml
 create mode 100644 test/fixtures/wpt/web-locks/README.md
 create mode 100644 test/fixtures/wpt/web-locks/WEB_FEATURES.yml
 create mode 100644 test/fixtures/wpt/web-locks/acquire.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/bfcache/abort.tentative.https.html
 create mode 100644 test/fixtures/wpt/web-locks/bfcache/held.tentative.https.html
 create mode 100644 test/fixtures/wpt/web-locks/bfcache/helpers.js
 create mode 100644 test/fixtures/wpt/web-locks/bfcache/release-across-thread.tentative.https.html
 create mode 100644 test/fixtures/wpt/web-locks/bfcache/release.tentative.https.html
 create mode 100644 test/fixtures/wpt/web-locks/bfcache/sharedworker-multiple.tentative.https.html
 create mode 100644 test/fixtures/wpt/web-locks/clientids.https.html
 create mode 100644 test/fixtures/wpt/web-locks/crashtests/after-worker-termination.https.html
 create mode 100644 test/fixtures/wpt/web-locks/crashtests/iframe-append-2.https.html
 create mode 100644 test/fixtures/wpt/web-locks/crashtests/iframe-append.https.html
 create mode 100644 test/fixtures/wpt/web-locks/crashtests/settle-after-steal.https.html
 create mode 100644 test/fixtures/wpt/web-locks/crashtests/worker-termination.https.html
 create mode 100644 test/fixtures/wpt/web-locks/frames.https.html
 create mode 100644 test/fixtures/wpt/web-locks/held.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/idlharness.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/ifAvailable.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/lock-attributes.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/mode-exclusive.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/mode-mixed.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/mode-shared.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/non-fully-active.https.html
 create mode 100644 test/fixtures/wpt/web-locks/non-secure-context.any.js
 create mode 100644 test/fixtures/wpt/web-locks/opaque-origin.https.html
 create mode 100644 test/fixtures/wpt/web-locks/partitioned-web-locks.tentative.https.html
 create mode 100644 test/fixtures/wpt/web-locks/query-empty.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/query-ordering.https.html
 create mode 100644 test/fixtures/wpt/web-locks/query.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/resource-names.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/resources/helpers.js
 create mode 100644 test/fixtures/wpt/web-locks/resources/iframe-parent.html
 create mode 100644 test/fixtures/wpt/web-locks/resources/iframe.html
 create mode 100644 test/fixtures/wpt/web-locks/resources/parentworker.js
 create mode 100644 test/fixtures/wpt/web-locks/resources/partitioned-parent.html
 create mode 100644 test/fixtures/wpt/web-locks/resources/service-worker.js
 create mode 100644 test/fixtures/wpt/web-locks/resources/sw-controlled-iframe.html
 create mode 100644 test/fixtures/wpt/web-locks/resources/worker.js
 create mode 100644 test/fixtures/wpt/web-locks/secure-context.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/signal.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/steal.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/storage-buckets.tentative.https.any.js
 create mode 100644 test/fixtures/wpt/web-locks/workers.https.html
 create mode 100644 test/parallel/test-web-locks-query.js
 create mode 100644 test/parallel/test-web-locks.js
 create mode 100644 test/wpt/status/web-locks.json
 create mode 100644 test/wpt/test-web-locks.js
 create mode 100644 typings/internalBinding/locks.d.ts
--------------------------------- New Message ----------------------------------
worker: add web locks api

PR-URL: #58666

Fixes: #36502

Refs: https://w3c.github.io/web-locks

Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>

Reviewed-By: Filip Skokan <panva.ip@gmail.com>

Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Reviewed-By: James M Snell <jasnell@gmail.com>

Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Reviewed-By: Anna Henningsen <anna@addaleax.net>


[main d860f3f54a] worker: add web locks api

Author: ishabi <ilyasshabi94@gmail.com>

Date: Fri May 30 00:57:31 2025 +0200

70 files changed, 5030 insertions(+)

create mode 100644 lib/internal/locks.js

create mode 100644 src/node_locks.cc

create mode 100644 src/node_locks.h

create mode 100644 test/fixtures/wpt/interfaces/web-locks.idl

create mode 100644 test/fixtures/wpt/web-locks/META.yml

create mode 100644 test/fixtures/wpt/web-locks/README.md

create mode 100644 test/fixtures/wpt/web-locks/WEB_FEATURES.yml

create mode 100644 test/fixtures/wpt/web-locks/acquire.https.any.js

create mode 100644 test/fixtures/wpt/web-locks/bfcache/abort.tentative.https.html

create mode 100644 test/fixtures/wpt/web-locks/bfcache/held.tentative.https.html

create mode 100644 test/fixtures/wpt/web-locks/bfcache/helpers.js

create mode 100644 test/fixtures/wpt/web-locks/bfcache/release-across-thread.tentative.https.html

create mode 100644 test/fixtures/wpt/web-locks/bfcache/release.tentative.https.html

create mode 100644 test/fixtures/wpt/web-locks/bfcache/sharedworker-multiple.tentative.https.html

create mode 100644 test/fixtures/wpt/web-locks/clientids.https.html

create mode 100644 test/fixtures/wpt/web-locks/crashtests/after-worker-termination.https.html

create mode 100644 test/fixtures/wpt/web-locks/crashtests/iframe-append-2.https.html

create mode 100644 test/fixtures/wpt/web-locks/crashtests/iframe-append.https.html

create mode 100644 test/fixtures/wpt/web-locks/crashtests/settle-after-steal.https.html

create mode 100644 test/fixtures/wpt/web-locks/crashtests/worker-termination.https.html

create mode 100644 test/fixtures/wpt/web-locks/frames.https.html

create mode 100644 test/fixtures/wpt/web-locks/held.https.any.js

create mode 100644 test/fixtures/wpt/web-locks/idlharness.https.any.js

create mode 100644 test/fixtures/wpt/web-locks/ifAvailable.https.any.js

create mode 100644 test/fixtures/wpt/web-locks/lock-attributes.https.any.js

create mode 100644 test/fixtures/wpt/web-locks/mode-exclusive.https.any.js

create mode 100644 test/fixtures/wpt/web-locks/mode-mixed.https.any.js

create mode 100644 test/fixtures/wpt/web-locks/mode-shared.https.any.js

create mode 100644 test/fixtures/wpt/web-locks/non-fully-active.https.html

create mode 100644 test/fixtures/wpt/web-locks/non-secure-context.any.js

create mode 100644 test/fixtures/wpt/web-locks/opaque-origin.https.html

create mode 100644 test/fixtures/wpt/web-locks/partitioned-web-locks.tentative.https.html

create mode 100644 test/fixtures/wpt/web-locks/query-empty.https.any.js

create mode 100644 test/fixtures/wpt/web-locks/query-ordering.https.html

create mode 100644 test/fixtures/wpt/web-locks/query.https.any.js

create mode 100644 test/fixtures/wpt/web-locks/resource-names.https.any.js

create mode 100644 test/fixtures/wpt/web-locks/resources/helpers.js

create mode 100644 test/fixtures/wpt/web-locks/resources/iframe-parent.html

create mode 100644 test/fixtures/wpt/web-locks/resources/iframe.html

create mode 100644 test/fixtures/wpt/web-locks/resources/parentworker.js

create mode 100644 test/fixtures/wpt/web-locks/resources/partitioned-parent.html

create mode 100644 test/fixtures/wpt/web-locks/resources/service-worker.js

create mode 100644 test/fixtures/wpt/web-locks/resources/sw-controlled-iframe.html

create mode 100644 test/fixtures/wpt/web-locks/resources/worker.js

create mode 100644 test/fixtures/wpt/web-locks/secure-context.https.any.js

create mode 100644 test/fixtures/wpt/web-locks/signal.https.any.js

create mode 100644 test/fixtures/wpt/web-locks/steal.https.any.js

create mode 100644 test/fixtures/wpt/web-locks/storage-buckets.tentative.https.any.js

create mode 100644 test/fixtures/wpt/web-locks/workers.https.html

create mode 100644 test/parallel/test-web-locks-query.js

create mode 100644 test/parallel/test-web-locks.js

create mode 100644 test/wpt/status/web-locks.json

create mode 100644 test/wpt/test-web-locks.js

create mode 100644 typings/internalBinding/locks.d.ts

✖  d860f3f54a8abc2636a9709af128f1f553f96e20

✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer

✖  2:7      Pull request URL must reference a comment or discussion. fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  1:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✔  0:0      valid subsystems                          subsystem

✔  0:0      Title is formatted correctly.             title-format

✔  0:0      Title is <= 50 columns.                   title-length


ℹ  Please fix the commit message and try again.

Please manually ammend the commit message, by running

git commit --amend

Once commit message is fixed, finish the landing command running

git node land --continue
https://github.com/nodejs/node/actions/runs/16373241092

jasnell pushed a commit that referenced this pull request Jul 18, 2025
@IlyasShabi @jasnell
worker: add web locks api
062e8b5 
PR-URL: #58666
Fixes: #36502
Refs: https://w3c.github.io/web-locks
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell
Copy link
Member

jasnell commented Jul 18, 2025

Landed in 062e8b5

@jasnell jasnell closed this Jul 18, 2025
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@IlyasShabi @aduh95
worker: add web locks api
9791ff3 
PR-URL: #58666
Fixes: #36502
Refs: https://w3c.github.io/web-locks
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@joyeecheung
Copy link
Member

wpt/test-web-locks has been flaky and failed at least 5 PRs out of the last 100 CI runs: #59142

@jasnell
Copy link
Member

jasnell commented Jul 21, 2025

Yeah, been noticing that. Let's mark it flaky. @IlyasShabi do you think you'd be able to investigate?

@IlyasShabi
Copy link
Contributor Author

@jasnell I have a PR to mark it flaky #59144. I will do investigate this later

@github-actions github-actions bot mentioned this pull request Jul 28, 2025
Merged
nodejs-github-bot added a commit that referenced this pull request Jul 28, 2025
@nodejs-github-bot
2025-07-29, Version 24.5.0 (Current)
22ba5cc 
Notable changes:

cli:
  * (SEMVER-MINOR) support `${pid}` placeholder in --cpu-prof-name (Haram Jeong) #59072
crypto:
  * (SEMVER-MINOR) add tls.setDefaultCACertificates() (Joyee Cheung) #58822
dns:
  * (SEMVER-MINOR) support max timeout (theanarkh) #58440
doc:
  * update the instruction on how to verify releases (Antoine du Hamel) #59113
esm:
  * (SEMVER-MINOR) unflag --experimental-wasm-modules (Guy Bedford) #57038
http,https:
  * (SEMVER-MINOR) add built-in proxy support in http/https.request and Agent (Joyee Cheung) #58980
net:
  * (SEMVER-MINOR) update net.blocklist to allow file save and file management (alphaleadership) #58087
test:
  * (SEMVER-MINOR) move http proxy tests to test/client-proxy (Joyee Cheung) #58980
worker:
  * (SEMVER-MINOR) add web locks api (ishabi) #58666

PR-URL: #59257
aduh95 added a commit that referenced this pull request Jul 29, 2025
@aduh95
2025-07-29, Version 24.5.0 (Current)
2540459 
Notable changes:

cli:
  * (SEMVER-MINOR) support `${pid}` placeholder in `--cpu-prof-name` (Haram Jeong) #59072
crypto:
  * (SEMVER-MINOR) add `tls.setDefaultCACertificates()` (Joyee Cheung) #58822
deps:
  * upgrade to openssl-3.5.1 (Node.js GitHub Bot) #59234
dns:
  * (SEMVER-MINOR) support max timeout (theanarkh) #58440
doc:
  * update the instruction on how to verify releases (Antoine du Hamel) #59113
esm:
  * (SEMVER-MINOR) unflag `--experimental-wasm-modules` (Guy Bedford) #57038
http,https:
  * (SEMVER-MINOR) add built-in proxy support in http/https.request and `Agent` (Joyee Cheung) #58980
net:
  * (SEMVER-MINOR) update net.blocklist to allow file save and file management (alphaleadership) #58087
test:
  * (SEMVER-MINOR) move http proxy tests to test/client-proxy (Joyee Cheung) #58980
worker:
  * (SEMVER-MINOR) add web locks api (ishabi) #58666

PR-URL: #59257
aduh95 added a commit that referenced this pull request Jul 29, 2025
@aduh95
2025-07-29, Version 24.5.0 (Current)
2507c52 
Notable changes:

cli:
  * (SEMVER-MINOR) support `${pid}` placeholder in `--cpu-prof-name` (Haram Jeong) #59072
crypto:
  * (SEMVER-MINOR) add `tls.setDefaultCACertificates()` (Joyee Cheung) #58822
deps:
  * upgrade to openssl-3.5.1 (Node.js GitHub Bot) #59234
dns:
  * (SEMVER-MINOR) support max timeout (theanarkh) #58440
doc:
  * update the instruction on how to verify releases (Antoine du Hamel) #59113
esm:
  * (SEMVER-MINOR) unflag `--experimental-wasm-modules` (Guy Bedford) #57038
http,https:
  * (SEMVER-MINOR) add built-in proxy support in http/https.request and `Agent` (Joyee Cheung) #58980
net:
  * (SEMVER-MINOR) update net.blocklist to allow file save and file management (alphaleadership) #58087
test:
  * (SEMVER-MINOR) move http proxy tests to test/client-proxy (Joyee Cheung) #58980
worker:
  * (SEMVER-MINOR) add web locks api (ishabi) #58666

PR-URL: #59257
@aduh95 aduh95 mentioned this pull request Jul 29, 2025
Merged
aduh95 added a commit that referenced this pull request Jul 29, 2025
@aduh95
2025-07-29, Version 24.5.0 (Current)
f6a312d 
Notable changes:

cli:
  * (SEMVER-MINOR) support `${pid}` placeholder in `--cpu-prof-name` (Haram Jeong) #59072
crypto:
  * (SEMVER-MINOR) add `tls.setDefaultCACertificates()` (Joyee Cheung) #58822
deps:
  * upgrade to openssl-3.5.1 (Node.js GitHub Bot) #59234
dns:
  * (SEMVER-MINOR) support max timeout (theanarkh) #58440
doc:
  * update the instruction on how to verify releases (Antoine du Hamel) #59113
esm:
  * (SEMVER-MINOR) unflag `--experimental-wasm-modules` (Guy Bedford) #57038
http,https:
  * (SEMVER-MINOR) add built-in proxy support in http/https.request and `Agent` (Joyee Cheung) #58980
net:
  * (SEMVER-MINOR) update net.blocklist to allow file save and file management (alphaleadership) #58087
test:
  * (SEMVER-MINOR) move http proxy tests to test/client-proxy (Joyee Cheung) #58980
worker:
  * (SEMVER-MINOR) add web locks api (ishabi) #58666

PR-URL: #59257
aduh95 added a commit that referenced this pull request Jul 29, 2025
@aduh95
2025-07-29, Version 24.5.0 (Current)
5b65243 
Notable changes:

cli:
  * (SEMVER-MINOR) support `${pid}` placeholder in `--cpu-prof-name` (Haram Jeong) #59072
crypto:
  * (SEMVER-MINOR) add `tls.setDefaultCACertificates()` (Joyee Cheung) #58822
deps:
  * upgrade to openssl-3.5.1 (Node.js GitHub Bot) #59234
dns:
  * (SEMVER-MINOR) support max timeout (theanarkh) #58440
doc:
  * update the instruction on how to verify releases (Antoine du Hamel) #59113
esm:
  * (SEMVER-MINOR) unflag `--experimental-wasm-modules` (Guy Bedford) #57038
http,https:
  * (SEMVER-MINOR) add built-in proxy support in http/https.request and `Agent` (Joyee Cheung) #58980
net:
  * (SEMVER-MINOR) update net.blocklist to allow file save and file management (alphaleadership) #58087
test:
  * (SEMVER-MINOR) move http proxy tests to test/client-proxy (Joyee Cheung) #58980
worker:
  * (SEMVER-MINOR) add web locks api (ishabi) #58666

PR-URL: #59257
aduh95 added a commit that referenced this pull request Jul 29, 2025
@aduh95
2025-07-29, Version 24.5.0 (Current)
47dfe77 
Notable changes:

cli:
  * (SEMVER-MINOR) support `${pid}` placeholder in `--cpu-prof-name` (Haram Jeong) #59072
crypto:
  * (SEMVER-MINOR) add `tls.setDefaultCACertificates()` (Joyee Cheung) #58822
deps:
  * upgrade to openssl-3.5.1 (Node.js GitHub Bot) #59234
dns:
  * (SEMVER-MINOR) support max timeout (theanarkh) #58440
doc:
  * update the instruction on how to verify releases (Antoine du Hamel) #59113
esm:
  * (SEMVER-MINOR) unflag `--experimental-wasm-modules` (Guy Bedford) #57038
http,https:
  * (SEMVER-MINOR) add built-in proxy support in http/https.request and `Agent` (Joyee Cheung) #58980
net:
  * (SEMVER-MINOR) update net.blocklist to allow file save and file management (alphaleadership) #58087
test:
  * (SEMVER-MINOR) move http proxy tests to test/client-proxy (Joyee Cheung) #58980
worker:
  * (SEMVER-MINOR) add web locks api (ishabi) #58666

PR-URL: #59257
aduh95 added a commit that referenced this pull request Jul 31, 2025
@aduh95
2025-07-31, Version 24.5.0 (Current)
22bd082 
Notable changes:

cli:
  * (SEMVER-MINOR) support `${pid}` placeholder in `--cpu-prof-name` (Haram Jeong) #59072
crypto:
  * (SEMVER-MINOR) add `tls.setDefaultCACertificates()` (Joyee Cheung) #58822
deps:
  * upgrade to openssl-3.5.1 (Node.js GitHub Bot) #59234
dns:
  * (SEMVER-MINOR) support max timeout (theanarkh) #58440
doc:
  * update the instruction on how to verify releases (Antoine du Hamel) #59113
esm:
  * (SEMVER-MINOR) unflag `--experimental-wasm-modules` (Guy Bedford) #57038
http,https:
  * (SEMVER-MINOR) add built-in proxy support in http/https.request and `Agent` (Joyee Cheung) #58980
net:
  * (SEMVER-MINOR) update net.blocklist to allow file save and file management (alphaleadership) #58087
test:
  * (SEMVER-MINOR) move http proxy tests to test/client-proxy (Joyee Cheung) #58980
worker:
  * (SEMVER-MINOR) add web locks api (ishabi) #58666

PR-URL: #59257
aduh95 added a commit that referenced this pull request Jul 31, 2025
@aduh95
2025-07-31, Version 24.5.0 (Current)
8f6b7d7 
Notable changes:

cli:
  * (SEMVER-MINOR) support `${pid}` placeholder in `--cpu-prof-name` (Haram Jeong) #59072
crypto:
  * (SEMVER-MINOR) add `tls.setDefaultCACertificates()` (Joyee Cheung) #58822
deps:
  * upgrade to openssl-3.5.1 (Node.js GitHub Bot) #59234
dns:
  * (SEMVER-MINOR) support max timeout (theanarkh) #58440
doc:
  * update the instruction on how to verify releases (Antoine du Hamel) #59113
esm:
  * (SEMVER-MINOR) unflag `--experimental-wasm-modules` (Guy Bedford) #57038
http,https:
  * (SEMVER-MINOR) add built-in proxy support in http/https.request and `Agent` (Joyee Cheung) #58980
net:
  * (SEMVER-MINOR) update net.blocklist to allow file save and file management (alphaleadership) #58087
test:
  * (SEMVER-MINOR) move http proxy tests to test/client-proxy (Joyee Cheung) #58980
worker:
  * (SEMVER-MINOR) add web locks api (ishabi) #58666

PR-URL: #59257
aduh95 added a commit that referenced this pull request Jul 31, 2025
@aduh95
2025-07-31, Version 24.5.0 (Current)
931ec10 
Notable changes:

cli:
  * (SEMVER-MINOR) support `${pid}` placeholder in `--cpu-prof-name` (Haram Jeong) #59072
crypto:
  * (SEMVER-MINOR) add `tls.setDefaultCACertificates()` (Joyee Cheung) #58822
deps:
  * upgrade to openssl-3.5.1 (Node.js GitHub Bot) #59234
dns:
  * (SEMVER-MINOR) support max timeout (theanarkh) #58440
doc:
  * update the instruction on how to verify releases (Antoine du Hamel) #59113
esm:
  * (SEMVER-MINOR) unflag `--experimental-wasm-modules` (Guy Bedford) #57038
http,https:
  * (SEMVER-MINOR) add built-in proxy support in http/https.request and `Agent` (Joyee Cheung) #58980
net:
  * (SEMVER-MINOR) update net.blocklist to allow file save and file management (alphaleadership) #58087
test:
  * (SEMVER-MINOR) move http proxy tests to test/client-proxy (Joyee Cheung) #58980
worker:
  * (SEMVER-MINOR) add web locks api (ishabi) #58666

PR-URL: #59257
aduh95 added a commit that referenced this pull request Jul 31, 2025
@aduh95
2025-07-31, Version 24.5.0 (Current)
c836bd6 
Notable changes:

cli:
  * (SEMVER-MINOR) support `${pid}` placeholder in `--cpu-prof-name` (Haram Jeong) #59072
crypto:
  * (SEMVER-MINOR) add `tls.setDefaultCACertificates()` (Joyee Cheung) #58822
deps:
  * upgrade to openssl-3.5.1 (Node.js GitHub Bot) #59234
dns:
  * (SEMVER-MINOR) support max timeout (theanarkh) #58440
doc:
  * update the instruction on how to verify releases (Antoine du Hamel) #59113
esm:
  * (SEMVER-MINOR) unflag `--experimental-wasm-modules` (Guy Bedford) #57038
http,https:
  * (SEMVER-MINOR) add built-in proxy support in http/https.request and `Agent` (Joyee Cheung) #58980
net:
  * (SEMVER-MINOR) update net.blocklist to allow file save and file management (alphaleadership) #58087
test:
  * (SEMVER-MINOR) move http proxy tests to test/client-proxy (Joyee Cheung) #58980
worker:
  * (SEMVER-MINOR) add web locks api (ishabi) #58666

PR-URL: #59257
meteorqz6 pushed a commit to meteorqz6/node that referenced this pull request Aug 2, 2025
@aduh95 @meteorqz6
2025-07-31, Version 24.5.0 (Current)
97d979a 
Notable changes:

cli:
  * (SEMVER-MINOR) support `${pid}` placeholder in `--cpu-prof-name` (Haram Jeong) nodejs#59072
crypto:
  * (SEMVER-MINOR) add `tls.setDefaultCACertificates()` (Joyee Cheung) nodejs#58822
deps:
  * upgrade to openssl-3.5.1 (Node.js GitHub Bot) nodejs#59234
dns:
  * (SEMVER-MINOR) support max timeout (theanarkh) nodejs#58440
doc:
  * update the instruction on how to verify releases (Antoine du Hamel) nodejs#59113
esm:
  * (SEMVER-MINOR) unflag `--experimental-wasm-modules` (Guy Bedford) nodejs#57038
http,https:
  * (SEMVER-MINOR) add built-in proxy support in http/https.request and `Agent` (Joyee Cheung) nodejs#58980
net:
  * (SEMVER-MINOR) update net.blocklist to allow file save and file management (alphaleadership) nodejs#58087
test:
  * (SEMVER-MINOR) move http proxy tests to test/client-proxy (Joyee Cheung) nodejs#58980
worker:
  * (SEMVER-MINOR) add web locks api (ishabi) nodejs#58666

PR-URL: nodejs#59257
@aduh95
Copy link
Contributor

aduh95 commented Aug 4, 2025

This doesn't land cleanly on v22.x-staging, we would need a manual backport PR if we want it on v22.x.

@aduh95 aduh95 added backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 4, 2025
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Aug 4, 2025
@tmeijn
build(deps): update node to v24.5.0
6f8dc5d 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | minor | `24.4.1` -> `24.5.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>nodejs/node (node)</summary>

### [`v24.5.0`](https://github.com/nodejs/node/releases/tag/v24.5.0): 2025-07-31, Version 24.5.0 (Current), @&#8203;aduh95

[Compare Source](nodejs/node@v24.4.1...v24.5.0)

##### Notable Changes

##### Upgrade to OpenSSL 3.5

This release is distributed with OpenSSL 3.5.1, following the announcement that
OpenSSL 3.5 will be supported until April 2030, while Node.js 24 will be
supported until April 2028. Read more about OpenSSL support in their blog post:
<https://openssl-library.org/post/2025-02-20-openssl-3.5-lts/>.

Contributed by Richard Lau in [#&#8203;58100](nodejs/node#58100).

##### Unflag `--experimental-wasm-modules`

Node.js supports both source phase imports and instance phase imports to WebAssembly
modules and for WASM imports to JavaScript, in line with the current Phase 3
WebAssembly [ESM Integration](https://github.com/webassembly/esm-integration) proposal.
The implementation and the specification are still subject to change.

Contributed by Guy Bedford in [#&#8203;57038](nodejs/node#57038).

##### Built-in proxy support in `request()` and `Agent`

`node:http` and `node:https` now support proxies. When `NODE_USE_ENV_PROXY`
is set to `1`, the default global agent would parse the `http_proxy`/`HTTP_PROXY`,
`https_proxy`/`HTTPS_PROXY`, `no_proxy`/`NO_PROXY` settings from the
environment variables, and proxy the requests sent through the built-in http/https
client accordingly.

To use global proxy support from the command line:

```bash
NODE_USE_ENV_PROXY=1 HTTP_PROXY=http://proxy.example.com:8080 HTTPS_PROXY=http://proxy.example.com:8080 NO_PROXY=localhost,127.0.0.1 node client.js
```

In addition, `http.Agent` and `https.Agent` now support the custom `proxyEnv` options.

```js
const agent = new https.Agent({ proxyEnv: { HTTPS_PROXY: 'http://proxy.example.com:8080' } });
```

For reference, `fetch()` already supports `NODE_USE_ENV_PROXY` as of Node.js 24.0.0.

Contributed by Joyee Cheung in [#&#8203;58980](nodejs/node#58980).

##### Add `setDefaultCACertificates()` to `node:tls`

This API allows dynamically configuring CA certificates that will be used by the
Node.js TLS clients by default.

Once called, the provided certificates will become the default CA certificate list
returned by `tls.getCACertificates('default')` and used by TLS connections that
don't specify their own CA certificates.

To add system CA certificates to the default bundle (which includes the Mozilla
CA certificates):

```js
tls.setDefaultCACertificates(tls.getCACertificates('default').concat(tls.getCACertificates('system')));
```

Contributed by Joyee Cheung in [#&#8203;58822](nodejs/node#58822).

##### Other notable changes

- \[[`d5640ca58a`](nodejs/node@d5640ca58a)] - **(SEMVER-MINOR)** **cli**: support `${pid}` placeholder in `--cpu-prof-name` (Haram Jeong) [#&#8203;59072](nodejs/node#59072)
- \[[`c52aaacfc5`](nodejs/node@c52aaacfc5)] - **(SEMVER-MINOR)** **dns**: support max timeout (theanarkh) [#&#8203;58440](nodejs/node#58440)
- \[[`927742b342`](nodejs/node@927742b342)] - **doc**: update the instruction on how to verify releases (Antoine du Hamel) [#&#8203;59113](nodejs/node#59113)
- \[[`f753645cd8`](nodejs/node@f753645cd8)] - **(SEMVER-MINOR)** **net**: update net.blocklist to allow file save and file management (alphaleadership) [#&#8203;58087](nodejs/node#58087)
- \[[`9791ff3480`](nodejs/node@9791ff3480)] - **(SEMVER-MINOR)** **worker**: add web locks api (ishabi) [#&#8203;58666](nodejs/node#58666)

##### Commits

- \[[`5457c7a8a1`](nodejs/node@5457c7a8a1)] - **benchmark**: adjust configuration for string-decoder bench (Rafael Gonzaga) [#&#8203;59187](nodejs/node#59187)
- \[[`28538f2255`](nodejs/node@28538f2255)] - **benchmark**: add --track to benchmark (Rafael Gonzaga) [#&#8203;59174](nodejs/node#59174)
- \[[`a28d804497`](nodejs/node@a28d804497)] - **benchmark**: small lint fix on \_cli.js (Rafael Gonzaga) [#&#8203;59172](nodejs/node#59172)
- \[[`09717eb68e`](nodejs/node@09717eb68e)] - **benchmark**: drop misc/punycode benchmark (Rafael Gonzaga) [#&#8203;59171](nodejs/node#59171)
- \[[`ad6757ef02`](nodejs/node@ad6757ef02)] - **benchmark**: fix sqlite-is-transaction (Rafael Gonzaga) [#&#8203;59170](nodejs/node#59170)
- \[[`7fc3143f61`](nodejs/node@7fc3143f61)] - **benchmark**: reduce N for diagnostics\_channel subscribe benchmark (Arthur Angelo) [#&#8203;59116](nodejs/node#59116)
- \[[`f2812723a0`](nodejs/node@f2812723a0)] - **buffer**: cache Environment::GetCurrent to avoid repeated calls (Mert Can Altin) [#&#8203;59043](nodejs/node#59043)
- \[[`e3e729ca60`](nodejs/node@e3e729ca60)] - **build**: remove suppressions.supp (Rafael Gonzaga) [#&#8203;59079](nodejs/node#59079)
- \[[`dc66422768`](nodejs/node@dc66422768)] - **build,deps,tools**: prepare to update to OpenSSL 3.5 (Richard Lau) [#&#8203;58100](nodejs/node#58100)
- \[[`f5da4947d9`](nodejs/node@f5da4947d9)] - **cli**: add --use-env-proxy (Joyee Cheung) [#&#8203;59151](nodejs/node#59151)
- \[[`d5640ca58a`](nodejs/node@d5640ca58a)] - **(SEMVER-MINOR)** **cli**: support `${pid}` placeholder in --cpu-prof-name (Haram Jeong) [#&#8203;59072](nodejs/node#59072)
- \[[`eeeb40e95b`](nodejs/node@eeeb40e95b)] - **(SEMVER-MINOR)** **crypto**: add tls.setDefaultCACertificates() (Joyee Cheung) [#&#8203;58822](nodejs/node#58822)
- \[[`135fca5b72`](nodejs/node@135fca5b72)] - **crypto**: avoid copying buffers to UTF-8 strings in `crypto.hash()` (Renegade334) [#&#8203;59067](nodejs/node#59067)
- \[[`998cef10e3`](nodejs/node@998cef10e3)] - **deps**: update archs files for openssl-3.5.1 (Node.js GitHub Bot) [#&#8203;59234](nodejs/node#59234)
- \[[`1f06ca956a`](nodejs/node@1f06ca956a)] - **deps**: upgrade openssl sources to openssl-3.5.1 (Node.js GitHub Bot) [#&#8203;59234](nodejs/node#59234)
- \[[`55a90eed8d`](nodejs/node@55a90eed8d)] - **deps**: upgrade npm to 11.5.1 (npm team) [#&#8203;59199](nodejs/node#59199)
- \[[`2b5d451ae0`](nodejs/node@2b5d451ae0)] - **deps**: update amaro to 1.1.1 (Node.js GitHub Bot) [#&#8203;59141](nodejs/node#59141)
- \[[`af789d9b5c`](nodejs/node@af789d9b5c)] - **deps**: update undici to 7.12.0 (Node.js GitHub Bot) [#&#8203;59135](nodejs/node#59135)
- \[[`a34e44545e`](nodejs/node@a34e44545e)] - **deps**: update sqlite to 3.50.3 (Node.js GitHub Bot) [#&#8203;59132](nodejs/node#59132)
- \[[`bfe4781c7d`](nodejs/node@bfe4781c7d)] - **deps**: update googletest to [`7e17b15`](nodejs/node@7e17b15) (Node.js GitHub Bot) [#&#8203;59131](nodejs/node#59131)
- \[[`72adf52e51`](nodejs/node@72adf52e51)] - **deps**: update ada to 3.2.6 (Node.js GitHub Bot) [#&#8203;58966](nodejs/node#58966)
- \[[`2a5f35b589`](nodejs/node@2a5f35b589)] - **deps**: V8: cherry-pick [`3d750c2`](nodejs/node@3d750c2aa9ef) (Michaël Zasso) [#&#8203;58750](nodejs/node#58750)
- \[[`3f813eaba7`](nodejs/node@3f813eaba7)] - **deps**: update archs files for openssl-3.0.17 (Node.js GitHub Bot) [#&#8203;59134](nodejs/node#59134)
- \[[`fb52d0d8df`](nodejs/node@fb52d0d8df)] - **deps**: upgrade openssl sources to openssl-3.0.17 (Node.js GitHub Bot) [#&#8203;59134](nodejs/node#59134)
- \[[`f122602f9d`](nodejs/node@f122602f9d)] - **deps**: update corepack to 0.34.0 (Node.js GitHub Bot) [#&#8203;59133](nodejs/node#59133)
- \[[`c52aaacfc5`](nodejs/node@c52aaacfc5)] - **(SEMVER-MINOR)** **dns**: support max timeout (theanarkh) [#&#8203;58440](nodejs/node#58440)
- \[[`927742b342`](nodejs/node@927742b342)] - **doc**: update the instruction on how to verify releases (Antoine du Hamel) [#&#8203;59113](nodejs/node#59113)
- \[[`9a8d2020ad`](nodejs/node@9a8d2020ad)] - **doc**: copyedit SECURITY.md (Rich Trott) [#&#8203;59190](nodejs/node#59190)
- \[[`3da5bc0668`](nodejs/node@3da5bc0668)] - **doc**: fix broken sentence in `URL.parse` (Superchupu) [#&#8203;59164](nodejs/node#59164)
- \[[`06cd7461e0`](nodejs/node@06cd7461e0)] - **doc**: improve onboarding instructions (Joyee Cheung) [#&#8203;59159](nodejs/node#59159)
- \[[`dfb72d158b`](nodejs/node@dfb72d158b)] - **doc**: add constraints for mem leak to threat model (Rafael Gonzaga) [#&#8203;58917](nodejs/node#58917)
- \[[`51b8dfd5c6`](nodejs/node@51b8dfd5c6)] - **doc**: add Aditi-1400 to collaborators (Aditi) [#&#8203;59157](nodejs/node#59157)
- \[[`4ffa756ce3`](nodejs/node@4ffa756ce3)] - **doc**: avoid suggesting testing fast api with intense loop (Chengzhong Wu) [#&#8203;59111](nodejs/node#59111)
- \[[`6f81b274f7`](nodejs/node@6f81b274f7)] - **doc**: fix typo in writing-test.md (SeokHun) [#&#8203;59123](nodejs/node#59123)
- \[[`88e434e687`](nodejs/node@88e434e687)] - **doc**: add new environment variables doc page (Dario Piotrowicz) [#&#8203;59052](nodejs/node#59052)
- \[[`b1a318d706`](nodejs/node@b1a318d706)] - **doc**: update release key for aduh95 (Antoine du Hamel) [#&#8203;58877](nodejs/node#58877)
- \[[`34c49000c9`](nodejs/node@34c49000c9)] - **doc**: add missing section for `setReturnArrays` in `sqlite.md` (Edy Silva) [#&#8203;59074](nodejs/node#59074)
- \[[`9b2e965aff`](nodejs/node@9b2e965aff)] - **doc**: add RafaelGSS as steward July 25 (Rafael Gonzaga) [#&#8203;59078](nodejs/node#59078)
- \[[`2d1dcb87e6`](nodejs/node@2d1dcb87e6)] - **doc**: clarify ERR\_FS\_FILE\_TOO\_LARGE to reflect fs.readFile() I/O limit (Haram Jeong) [#&#8203;59050](nodejs/node#59050)
- \[[`999b5e51e7`](nodejs/node@999b5e51e7)] - **doc**: run license-builder (github-actions\[bot]) [#&#8203;59056](nodejs/node#59056)
- \[[`1940a2cb46`](nodejs/node@1940a2cb46)] - **doc**: fix typed list formatting (Aviv Keller) [#&#8203;59019](nodejs/node#59019)
- \[[`6cb5e0d22f`](nodejs/node@6cb5e0d22f)] - **doc**: refine `util.parseArgs` `default` definition (Slayer95) [#&#8203;58958](nodejs/node#58958)
- \[[`d2e7f8e13a`](nodejs/node@d2e7f8e13a)] - **doc**: remove unused import in `zlib.md` (coderaiser) [#&#8203;59041](nodejs/node#59041)
- \[[`9d02960149`](nodejs/node@9d02960149)] - **doc**: add missing environment variables to manpage (amir lavasani) [#&#8203;58963](nodejs/node#58963)
- \[[`45ffdb34fb`](nodejs/node@45ffdb34fb)] - **doc**: add stability index to the `--watch-kill-signal` flag (Dario Piotrowicz) [#&#8203;58997](nodejs/node#58997)
- \[[`3924c43600`](nodejs/node@3924c43600)] - **doc**: add missing `<code>` blocks (Antoine du Hamel) [#&#8203;58995](nodejs/node#58995)
- \[[`cb95e183f3`](nodejs/node@cb95e183f3)] - **doc**: add scroll margin to links (Roman Reiss) [#&#8203;58982](nodejs/node#58982)
- \[[`c9ded6ba15`](nodejs/node@c9ded6ba15)] - **doc**: add sponsorship link to RafaelGSS (Rafael Gonzaga) [#&#8203;58983](nodejs/node#58983)
- \[[`b919fe0447`](nodejs/node@b919fe0447)] - **(SEMVER-MINOR)** **esm**: unflag --experimental-wasm-modules (Guy Bedford) [#&#8203;57038](nodejs/node#57038)
- \[[`71bb6cd077`](nodejs/node@71bb6cd077)] - **esm**: js-string Wasm builtins in ESM Integration (Guy Bedford) [#&#8203;59020](nodejs/node#59020)
- \[[`8d869e6d62`](nodejs/node@8d869e6d62)] - **fs**: fix return value of fs APIs (theanarkh) [#&#8203;58996](nodejs/node#58996)
- \[[`7f654cee9e`](nodejs/node@7f654cee9e)] - **(SEMVER-MINOR)** **http,https**: add built-in proxy support in http/https.request and Agent (Joyee Cheung) [#&#8203;58980](nodejs/node#58980)
- \[[`85d6a28f4f`](nodejs/node@85d6a28f4f)] - **inspector**: initial support for Network.loadNetworkResource (Shima Ryuhei) [#&#8203;58077](nodejs/node#58077)
- \[[`cfaa299f2e`](nodejs/node@cfaa299f2e)] - **lib**: fix incorrect `ArrayBufferPrototypeGetDetached` primordial type (Dario Piotrowicz) [#&#8203;58978](nodejs/node#58978)
- \[[`d555db22ad`](nodejs/node@d555db22ad)] - **lib**: flag to conditionally modify proto on deprecate (Rafael Gonzaga) [#&#8203;58928](nodejs/node#58928)
- \[[`96c9dd79e6`](nodejs/node@96c9dd79e6)] - **meta**: move one or more collaborators to emeritus (Node.js GitHub Bot) [#&#8203;59140](nodejs/node#59140)
- \[[`324d9fc9d4`](nodejs/node@324d9fc9d4)] - **meta**: enable jsdoc/check-tag-names rule (Yagiz Nizipli) [#&#8203;58521](nodejs/node#58521)
- \[[`04c751463b`](nodejs/node@04c751463b)] - **meta**: add marco-ippolito to security release stewards (Marco Ippolito) [#&#8203;58944](nodejs/node#58944)
- \[[`fe0195fdcc`](nodejs/node@fe0195fdcc)] - **module**: fix conditions override in synchronous resolve hooks (Joyee Cheung) [#&#8203;59011](nodejs/node#59011)
- \[[`515b581d47`](nodejs/node@515b581d47)] - **module**: throw error when re-runing errored module jobs (Joyee Cheung) [#&#8203;58957](nodejs/node#58957)
- \[[`f753645cd8`](nodejs/node@f753645cd8)] - **(SEMVER-MINOR)** **net**: update net.blocklist to allow file save and file management (alphaleadership) [#&#8203;58087](nodejs/node#58087)
- \[[`15e6c28d82`](nodejs/node@15e6c28d82)] - **node-api,doc**: update links to ecma262 with section names (Chengzhong Wu) [#&#8203;59087](nodejs/node#59087)
- \[[`f67b686551`](nodejs/node@f67b686551)] - **perf\_hooks**: do not expose SafeMap via Histogram wrapper (René) [#&#8203;59094](nodejs/node#59094)
- \[[`3d2f919f7c`](nodejs/node@3d2f919f7c)] - **process**: make execve's args argument optional (Allon Murienik) [#&#8203;58412](nodejs/node#58412)
- \[[`1a44265810`](nodejs/node@1a44265810)] - **repl**: handle errors from getters during completion (Shima Ryuhei) [#&#8203;59044](nodejs/node#59044)
- \[[`467dbd31e6`](nodejs/node@467dbd31e6)] - **repl**: fix repl crashing on variable declarations without init (Dario Piotrowicz) [#&#8203;59032](nodejs/node#59032)
- \[[`3a3eb6852d`](nodejs/node@3a3eb6852d)] - **repl**: improve REPL disabling completion on proxies and getters (Dario Piotrowicz) [#&#8203;58891](nodejs/node#58891)
- \[[`55838e79b8`](nodejs/node@55838e79b8)] - **src**: call unmask after install signal handler (theanarkh) [#&#8203;59059](nodejs/node#59059)
- \[[`77649ad93b`](nodejs/node@77649ad93b)] - **src**: use `FastStringKey` for `TrackV8FastApiCall` (Anna Henningsen) [#&#8203;59148](nodejs/node#59148)
- \[[`86babf9c4b`](nodejs/node@86babf9c4b)] - **src**: use C++20 `consteval` for `FastStringKey` (Anna Henningsen) [#&#8203;59148](nodejs/node#59148)
- \[[`88b99eeae1`](nodejs/node@88b99eeae1)] - **src**: remove declarations of removed BaseObject static fns (Anna Henningsen) [#&#8203;59093](nodejs/node#59093)
- \[[`d89390fc8f`](nodejs/node@d89390fc8f)] - **src**: add cache to nearest parent package json (Ilyas Shabi) [#&#8203;59086](nodejs/node#59086)
- \[[`21780075e4`](nodejs/node@21780075e4)] - **src**: check import attributes value types as strings (Chengzhong Wu) [#&#8203;58986](nodejs/node#58986)
- \[[`ef89c2fac9`](nodejs/node@ef89c2fac9)] - **src,test**: fix config file parsing for flags defaulted to true (Edy Silva) [#&#8203;59110](nodejs/node#59110)
- \[[`1e990866e0`](nodejs/node@1e990866e0)] - **test**: mark web lock held test as flaky (Ilyas Shabi) [#&#8203;59144](nodejs/node#59144)
- \[[`ba8e95a785`](nodejs/node@ba8e95a785)] - **test**: use mustSucceed in test-fs-read (Sungwon) [#&#8203;59204](nodejs/node#59204)
- \[[`39978f507f`](nodejs/node@39978f507f)] - **test**: prepare test-crypto-rsa-dsa for newer OpenSSL (Richard Lau) [#&#8203;58100](nodejs/node#58100)
- \[[`1c3aadb9d6`](nodejs/node@1c3aadb9d6)] - **test**: fix flaky test-worker-message-port-transfer-filehandle test (Alex Yang) [#&#8203;59158](nodejs/node#59158)
- \[[`a0d22e9c51`](nodejs/node@a0d22e9c51)] - **test**: remove timeout in test-https-proxy-request-handshake-failure (Joyee Cheung) [#&#8203;59165](nodejs/node#59165)
- \[[`7e0a0fccc1`](nodejs/node@7e0a0fccc1)] - **test**: expand linting rules around `assert` w literal messages (Anna Henningsen) [#&#8203;59147](nodejs/node#59147)
- \[[`c6070046c3`](nodejs/node@c6070046c3)] - **test**: update WPT for WebCryptoAPI to [`ab08796`](nodejs/node@ab08796857) (Node.js GitHub Bot) [#&#8203;59129](nodejs/node#59129)
- \[[`15d8cc908e`](nodejs/node@15d8cc908e)] - **test**: update WPT for WebCryptoAPI to [`19d82c5`](nodejs/node@19d82c57ab) (Node.js GitHub Bot) [#&#8203;59129](nodejs/node#59129)
- \[[`83023e5144`](nodejs/node@83023e5144)] - **test**: skip tests that cause timeouts on IBM i (Abdirahim Musse) [#&#8203;59014](nodejs/node#59014)
- \[[`82d4175ec3`](nodejs/node@82d4175ec3)] - **test**: update `startCLI` to set `--port=0` by default (Dario Piotrowicz) [#&#8203;59042](nodejs/node#59042)
- \[[`16dc53c143`](nodejs/node@16dc53c143)] - **(SEMVER-MINOR)** **test**: move http proxy tests to test/client-proxy (Joyee Cheung) [#&#8203;58980](nodejs/node#58980)
- \[[`a9511a6066`](nodejs/node@a9511a6066)] - **test**: mark test-inspector-network-fetch as flaky on Windows (Joyee Cheung) [#&#8203;59091](nodejs/node#59091)
- \[[`1cffcc02a3`](nodejs/node@1cffcc02a3)] - **test**: add missing port=0 arg in test-debugger-extract-function-name (Dario Piotrowicz) [#&#8203;58977](nodejs/node#58977)
- \[[`83cdf1701b`](nodejs/node@83cdf1701b)] - **test\_runner**: clean up promisified interval generation (René) [#&#8203;58824](nodejs/node#58824)
- \[[`195d6038dc`](nodejs/node@195d6038dc)] - **tools**: clarify README linter error message (Joyee Cheung) [#&#8203;59160](nodejs/node#59160)
- \[[`51f578a3bf`](nodejs/node@51f578a3bf)] - **tools**: add support for URLs to MR commits in `merge.sh` (Antoine du Hamel) [#&#8203;59162](nodejs/node#59162)
- \[[`20be9012eb`](nodejs/node@20be9012eb)] - **tools**: bump [@&#8203;eslint/plugin-kit](https://github.com/eslint/plugin-kit) from 0.3.1 to 0.3.3 in /tools/eslint (dependabot\[bot]) [#&#8203;59119](nodejs/node#59119)
- \[[`623e264e93`](nodejs/node@623e264e93)] - **tools**: ignore CVE mention when linting release proposals (Antoine du Hamel) [#&#8203;59037](nodejs/node#59037)
- \[[`0e547e09ab`](nodejs/node@0e547e09ab)] - **tools,test**: enforce best practices to detect never settling promises (Antoine du Hamel) [#&#8203;58992](nodejs/node#58992)
- \[[`075d1968db`](nodejs/node@075d1968db)] - **util**: respect nested formats in styleText (Alex Yang) [#&#8203;59098](nodejs/node#59098)
- \[[`9791ff3480`](nodejs/node@9791ff3480)] - **(SEMVER-MINOR)** **worker**: add web locks api (ishabi) [#&#8203;58666](nodejs/node#58666)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS40Ni4zIiwidXBkYXRlZEluVmVyIjoiNDEuNDYuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi left review comments

@mcollina mcollina mcollina approved these changes

@panva panva panva approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@benjamingr benjamingr benjamingr approved these changes

@anonrig anonrig anonrig approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@KhafraDev KhafraDev Awaiting requested review from KhafraDev

Assignees
No one assigned
Labels
backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. semver-minor PRs that contain new features and should be released in the next minor version. web-standards Issues and PRs related to Web APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.