-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
build,deps,tools: prepare to update to OpenSSL 3.5 #58100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
Update `parallel/test-crypto-rsa-dsa` to prepare for updating `deps/openssl` to later versions of OpenSSL which support implicit rejections with `RSA_PKCS1_PADDING`.
Update the updater script and files under `deps/openssl/config` in preparation for updating `deps/openssl` to OpenSSL 3.5. Co-Authored-By: Richard Lau <rlau@redhat.com>
f44bef3
to
6abfd51
Compare
Can we backport this to LTS? Should we add the lts-watch labels? |
I've stuck a watch label for Node.js 22 as we have to update that at some point because OpenSSL 3.0 reaches End-of-Life in September 2026 which is before the End-of-Life of Node.js 22 (end of April 2027). For Node.js 20 we could stay on OpenSSL 3.0 as Node.js 20 will reach End-of-Life at the end of April 2026 which is prior to End-of-Life of OpenSSL 3.0. But we can have a separate discussion about how we would manage updates of OpenSSL across all of our LTS versions. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58100 +/- ##
=======================================
Coverage 90.20% 90.21%
=======================================
Files 630 630
Lines 186446 186446
Branches 36619 36624 +5
=======================================
+ Hits 168190 168196 +6
+ Misses 11053 11047 -6
Partials 7203 7203 🚀 New features to boost your workflow:
|
Moving this to draft. I ran a CI on https://github.com/richardlau/node-1/tree/openssl-3.5 (from which the commits in this PR are based) and that has failed to build on Windows: https://ci.nodejs.org/job/node-test-commit/79522/ I suspect we'll need to add even more entries into |
Update
parallel/test-crypto-rsa-dsa
to prepare for updatingdeps/openssl
to later versions of OpenSSL which support implicitrejections with
RSA_PKCS1_PADDING
.Update the updater script and files under
deps/openssl/config
inpreparation for updating
deps/openssl
to OpenSSL 3.5.Note that this PR does not do the actual upgrade -- that should be handled by running the workflow after this lands.
This co-depends on #58099, which needs to land before the updater script is run (it shouldn't matter in which order they land, but both that PR and this one are needed for the files in
deps/openssl/config
to be regenerated).