Skip to content

test: remove Float16Array flag #58184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ export default [
DecompressionStream: 'readonly',
EventSource: 'readable',
fetch: 'readonly',
Float16Array: 'readonly',
FormData: 'readonly',
navigator: 'readonly',
ReadableStream: 'readonly',
Expand Down
5 changes: 0 additions & 5 deletions test/parallel/test-assert-partial-deep-equal.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,10 @@
// Flags: --js-float16array
// TODO(LiviaMedeiros): once `Float16Array` is unflagged in v8, remove the line above
'use strict';

const common = require('../common');
const vm = require('node:vm');
const assert = require('node:assert');
const { describe, it } = require('node:test');

// TODO(LiviaMedeiros): once linter recognizes `Float16Array`, remove next line
const { Float16Array } = globalThis;

const x = ['x'];

function createCircularObject() {
Expand Down
5 changes: 0 additions & 5 deletions test/parallel/test-assert-typedarray-deepequal.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,9 @@
// Flags: --js-float16array
// TODO(LiviaMedeiros): once `Float16Array` is unflagged in v8, remove the line above
'use strict';

require('../common');
const assert = require('assert');
const { test, suite } = require('node:test');

// TODO(LiviaMedeiros): once linter recognizes `Float16Array`, remove next line
const { Float16Array } = globalThis;

function makeBlock(f) {
const args = Array.prototype.slice.call(arguments, 1);
return function() {
Expand Down
6 changes: 1 addition & 5 deletions test/parallel/test-util-types.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// Flags: --experimental-vm-modules --expose-internals --allow-natives-syntax --js-float16array
// TODO(LiviaMedeiros): once `Float16Array` is unflagged in v8, remove `--js-float16array` above
// Flags: --experimental-vm-modules --expose-internals --allow-natives-syntax
'use strict';
const common = require('../common');
const assert = require('assert');
Expand All @@ -10,9 +9,6 @@ const { JSStream } = internalBinding('js_stream');

const external = (new JSStream())._externalStream;

// TODO(LiviaMedeiros): once linter recognizes `Float16Array`, remove next line
const { Float16Array } = globalThis;

for (const [ value, _method ] of [
[ external, 'isExternal' ],
[ new Date() ],
Expand Down
5 changes: 1 addition & 4 deletions test/parallel/test-v8-serdes.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Flags: --expose-internals --js-float16array
// Flags: --expose-internals

'use strict';

Expand All @@ -7,9 +7,6 @@ const { internalBinding } = require('internal/test/binding');
const assert = require('assert');
const v8 = require('v8');
const os = require('os');
// TODO(bartlomieju): once `Float16Array` is available in stable V8,
// remove this line and `--js-float16array` flag up top
const { Float16Array } = globalThis;

const circular = {};
circular.circular = circular;
Expand Down
2 changes: 0 additions & 2 deletions test/wpt/test-webcrypto.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// Flags: --js-float16array
// TODO(LiviaMedeiros): once `Float16Array` is unflagged in v8, remove the line above
'use strict';

const common = require('../common');
Expand Down
Loading