-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
deps: update OpenSSL to 3.0.17 #58097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-Authored-By: Richard Lau <rlau@redhat.com>
Review requested:
|
FYI I'm testing the automation. |
This was opened by https://github.com/nodejs/node/actions/runs/14779389322/job/41494768590, running on the branch for #58098. |
https://ci.nodejs.org/job/node-test-commit-linux/nodes=rhel8-x64/64390/console
So the build failures are a surprise as I wasn't seeing those locally (Linux x64). On further investigation it looks like some of the config files, specifically some of the assembly For example, compare
I think this is partly due to openssl/openssl#25751 and e.g. node/deps/openssl/openssl/crypto/bn/asm/rsaz-2k-avxifma.pl Lines 30 to 34 in 8573b4a
The version of GNU assembler in the Dockerfile (Ubuntu 20.04) is 2.34. My RHEL 9 build environment has GNU assembler 2.38. Both of those are less than 2.40. Ubuntu 24.04 appears to have GNU assembler 2.42, which passes the above check. The build in Jenkins will be running with different versions of GNU assembler depending on the installed version of |
This is an automated update of OpenSSL to 3.0.17.