sqlite: add location method #57860

geeksilva97 · 2025-04-13T03:45:55Z

nodejs-github-bot · 2025-04-13T03:46:00Z

Review requested:

@nodejs/sqlite

geeksilva97 · 2025-04-13T03:48:34Z

This would simplify the sharing of connections between modules. When needed, they could retrieve the database location using only the object.

I'm aware some of you might find this useless. Whatever you guys decide, I'm okay with it. I just needed something like this and decided to implement.

codecov · 2025-04-13T04:38:24Z

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.27%. Comparing base (422529a) to head (0e82ee2).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	82.60%	0 Missing and 4 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #57860   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files         630      630           
  Lines      186124   186147   +23     
  Branches    36469    36481   +12     
=======================================
+ Hits       168021   168050   +29     
+ Misses      10974    10972    -2     
+ Partials     7129     7125    -4

Files with missing lines	Coverage Δ
src/node_sqlite.h	`68.00% <ø> (ø)`
src/node_sqlite.cc	`80.56% <82.60%> (+0.02%)`	⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

src/node_sqlite.cc

test/parallel/test-sqlite-database-sync.js

doc/api/sqlite.md

src/node_sqlite.cc

test/parallel/test-sqlite-database-sync.js

doc/api/sqlite.md

src/node_sqlite.cc

cjihrig

LGTM besides the one unrelated change.

src/node_sqlite.cc

nodejs-github-bot · 2025-04-14T18:50:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66268/

nodejs-github-bot · 2025-04-16T17:42:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66318/

nodejs-github-bot · 2025-04-19T09:25:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66360/

cjihrig · 2025-04-20T16:01:59Z

This has conflicts.

geeksilva97 · 2025-04-21T01:52:20Z

This has conflicts.

Fixed

nodejs-github-bot · 2025-04-21T14:07:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66402/

nodejs-github-bot · 2025-04-21T14:57:16Z

Landed in e9b286c

PR-URL: #57860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Apr 13, 2025

geeksilva97 force-pushed the sqlite-add-location-function branch from 6de740a to b42a338 Compare April 13, 2025 03:49

jasnell reviewed Apr 13, 2025

View reviewed changes

src/node_sqlite.cc Outdated Show resolved Hide resolved

jasnell reviewed Apr 13, 2025

View reviewed changes

test/parallel/test-sqlite-database-sync.js Outdated Show resolved Hide resolved

anonrig reviewed Apr 13, 2025

View reviewed changes

doc/api/sqlite.md Outdated Show resolved Hide resolved

anonrig reviewed Apr 13, 2025

View reviewed changes

src/node_sqlite.cc Show resolved Hide resolved

cjihrig reviewed Apr 13, 2025

View reviewed changes

test/parallel/test-sqlite-database-sync.js Show resolved Hide resolved

doc/api/sqlite.md Outdated Show resolved Hide resolved

doc/api/sqlite.md Outdated Show resolved Hide resolved

jasnell reviewed Apr 13, 2025

View reviewed changes

src/node_sqlite.cc Outdated Show resolved Hide resolved

geeksilva97 force-pushed the sqlite-add-location-function branch 2 times, most recently from f46394b to e7817bf Compare April 13, 2025 20:59

cjihrig reviewed Apr 13, 2025

View reviewed changes

src/node_sqlite.cc Outdated Show resolved Hide resolved

tniessen reviewed Apr 13, 2025

View reviewed changes

src/node_sqlite.cc Show resolved Hide resolved

src/node_sqlite.cc Outdated Show resolved Hide resolved

geeksilva97 force-pushed the sqlite-add-location-function branch 2 times, most recently from 48a8353 to e0418ab Compare April 13, 2025 22:49

jasnell reviewed Apr 14, 2025

View reviewed changes

src/node_sqlite.cc Outdated Show resolved Hide resolved

jasnell approved these changes Apr 14, 2025

View reviewed changes

geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2025

geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 16, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 16, 2025

geeksilva97 force-pushed the sqlite-add-location-function branch from a489f6f to e68a1b3 Compare April 20, 2025 04:36

geeksilva97 requested a review from cjihrig April 20, 2025 04:36

geeksilva97 added 4 commits April 20, 2025 22:48

sqlite: add location method

d1b44a1

test: handle unusual chars

edef77a

apply review suggestions

bb758ed

fixup: apply review suggestions

0e82ee2

geeksilva97 force-pushed the sqlite-add-location-function branch from e68a1b3 to 0e82ee2 Compare April 21, 2025 01:52

cjihrig approved these changes Apr 21, 2025

View reviewed changes

geeksilva97 added request-ci Add this label to start a Jenkins CI on a PR. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 21, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 21, 2025

nodejs-github-bot merged commit e9b286c into nodejs:main Apr 21, 2025
63 checks passed

RafaelGSS pushed a commit that referenced this pull request May 1, 2025

sqlite: add location method

b45da5b

PR-URL: #57860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

RafaelGSS mentioned this pull request May 1, 2025

2025-05-06, Version 24.0.0 (Current) #57609

Merged

RafaelGSS pushed a commit that referenced this pull request May 2, 2025

sqlite: add location method

10eb2b0

PR-URL: #57860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request May 6, 2025

sqlite: add location method

3499b9a

PR-URL: #57860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request May 6, 2025

sqlite: add location method

3bb7085

PR-URL: #57860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

RafaelGSS pushed a commit that referenced this pull request May 14, 2025

sqlite: add location method

8ade3ce

PR-URL: #57860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request May 16, 2025

sqlite: add location method

a2f804e

PR-URL: #57860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request May 17, 2025

sqlite: add location method

6a402df

PR-URL: #57860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request May 17, 2025

sqlite: add location method

43350cd

PR-URL: #57860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request May 17, 2025

sqlite: add location method

95c3785

PR-URL: #57860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request May 18, 2025

sqlite: add location method

53f4354

PR-URL: #57860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

github-actions bot mentioned this pull request May 19, 2025

2025-05-21, Version 22.16.0 'Jod' (LTS) #58388

Merged

aduh95 pushed a commit that referenced this pull request May 19, 2025

sqlite: add location method

7485309

PR-URL: #57860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

geeksilva97 deleted the sqlite-add-location-function branch May 20, 2025 00:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sqlite: add location method #57860

sqlite: add location method #57860

geeksilva97 commented Apr 13, 2025

nodejs-github-bot commented Apr 13, 2025

geeksilva97 commented Apr 13, 2025

codecov bot commented Apr 13, 2025 •

edited

Loading

cjihrig left a comment

nodejs-github-bot commented Apr 14, 2025

nodejs-github-bot commented Apr 16, 2025

nodejs-github-bot commented Apr 19, 2025

cjihrig commented Apr 20, 2025

geeksilva97 commented Apr 21, 2025

nodejs-github-bot commented Apr 21, 2025

nodejs-github-bot commented Apr 21, 2025

sqlite: add location method #57860

sqlite: add location method #57860

Conversation

geeksilva97 commented Apr 13, 2025

nodejs-github-bot commented Apr 13, 2025

geeksilva97 commented Apr 13, 2025

codecov bot commented Apr 13, 2025 • edited Loading

Codecov Report

cjihrig left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Apr 14, 2025

nodejs-github-bot commented Apr 16, 2025

nodejs-github-bot commented Apr 19, 2025

cjihrig commented Apr 20, 2025

geeksilva97 commented Apr 21, 2025

nodejs-github-bot commented Apr 21, 2025

nodejs-github-bot commented Apr 21, 2025

codecov bot commented Apr 13, 2025 •

edited

Loading