Skip to content

Commit e68a1b3

Browse files
committed
fixup: apply review suggestions
1 parent c7dba18 commit e68a1b3

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/node_sqlite.cc

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1181,20 +1181,19 @@ void DatabaseSync::Location(const FunctionCallbackInfo<Value>& args) {
11811181
Environment* env = Environment::GetCurrent(args);
11821182
THROW_AND_RETURN_ON_BAD_STATE(env, !db->IsOpen(), "database is not open");
11831183

1184-
std::string_view db_name = "main";
1184+
std::string db_name = "main";
11851185
if (!args[0]->IsUndefined()) {
11861186
if (!args[0]->IsString()) {
11871187
THROW_ERR_INVALID_ARG_TYPE(env->isolate(),
11881188
"The \"dbName\" argument must be a string.");
11891189
return;
11901190
}
11911191

1192-
Utf8Value db_name_utf8(env->isolate(), args[0].As<String>());
1193-
db_name = *db_name_utf8 ? *db_name_utf8 : "";
1192+
db_name = Utf8Value(env->isolate(), args[0].As<String>()).ToString();
11941193
}
11951194

11961195
const char* db_filename =
1197-
sqlite3_db_filename(db->connection_, std::string(db_name).c_str());
1196+
sqlite3_db_filename(db->connection_, db_name.c_str());
11981197
if (!db_filename || db_filename[0] == '\0') {
11991198
args.GetReturnValue().Set(Null(env->isolate()));
12001199
return;

0 commit comments

Comments
 (0)