-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
module: remove extra padding from ts errors #57704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 2 commits into
nodejs:main
from
marco-ippolito:more-improvements
Apr 3, 2025
Merged
module: remove extra padding from ts errors #57704
nodejs-github-bot
merged 2 commits into
nodejs:main
from
marco-ippolito:more-improvements
Apr 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57704 +/- ##
==========================================
- Coverage 90.22% 90.22% -0.01%
==========================================
Files 630 630
Lines 185073 185073
Branches 36222 36215 -7
==========================================
- Hits 166990 166983 -7
- Misses 11044 11047 +3
- Partials 7039 7043 +4
🚀 New features to boost your workflow:
|
JakobJingleheimer
approved these changes
Apr 1, 2025
jasnell
approved these changes
Apr 1, 2025
bjohansebas
approved these changes
Apr 1, 2025
aduh95
approved these changes
Apr 2, 2025
Landed in 0dc4725 |
JonasBa
pushed a commit
to JonasBa/node
that referenced
this pull request
Apr 11, 2025
PR-URL: nodejs#57704 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
PR-URL: #57704 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
PR-URL: #57704 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito
added a commit
to marco-ippolito/node
that referenced
this pull request
Jun 25, 2025
PR-URL: nodejs#57704 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
backport-open-v22.x
Indicate that the PR has an open backport
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
strip-types
Issues or PRs related to strip-types support
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finally removed the extra padding from errors and this is the final result: