Fixing typo in URLPattern parameters #57466
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
jasnell
approved these changes
Mar 14, 2025
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
anonrig
approved these changes
Mar 14, 2025
There was a problem hiding this comment.
Thanks for the contribution!
You folks opened PR almost exactly at the same time! @lawlight-org @mureinik (#57467)
May I purpose to add each other as a co-author when landing?
Also, this PR will need to fix the commit message to adhere to the commit guide line. As the Github Action is currently failing.
e.g doc: fix typo for URLPattern first arg
daeyeon
approved these changes
Mar 15, 2025
daeyeon
added
author ready
|
Landed in 2affc3a, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #57464