timers: set several methods EOL #56966

anonrig · 2025-02-08T19:54:12Z

Make _unrefActive, active, unenroll and enroll EOL. They have been runtime deprecated since v10 and v11, and not even mentioned on Node.js documentation page

cc @nodejs/tsc for visibility

Thanks to @RafaelGSS, here's the CITGM run: https://ci.nodejs.org/job/citgm-smoker/3547/

nodejs-github-bot · 2025-02-08T20:11:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65063/

codecov · 2025-02-08T21:20:30Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.14%. Comparing base (b181535) to head (f94223f).
Report is 19 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #56966   +/-   ##
=======================================
  Coverage   89.13%   89.14%           
=======================================
  Files         665      665           
  Lines      193165   193144   -21     
  Branches    37191    37187    -4     
=======================================
- Hits       172181   172174    -7     
+ Misses      13729    13726    -3     
+ Partials     7255     7244   -11

Files with missing lines	Coverage Δ
lib/timers.js	`100.00% <ø> (ø)`

... and 37 files with indirect coverage changes

anonrig · 2025-02-08T23:10:23Z

@RafaelGSS would you mind running the citgm for this pull-request? I am not sure what to write to git ref label on jenkins ui for this branch (since this is a branch in a fork)

RafaelGSS · 2025-02-08T23:18:43Z

https://ci.nodejs.org/job/citgm-smoker/3547/

atlowChemi · 2025-02-09T17:34:21Z

test/parallel/test-timers-unenroll-unref-interval.js

the file name seems wrong now?

I think it's ok since unenroll is the function that these functions are calling. They're un-enrolling the timers.

nodejs-github-bot · 2025-02-09T17:56:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65093/

doc/api/deprecations.md

marco-ippolito

Blocking because the description and the deprecation type needs to be updated (I'm in favor of this change)

anonrig · 2025-02-09T19:17:39Z

@marco-ippolito Appreciate a re-review if you don't mind.

doc/api/deprecations.md

Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com>

nodejs-github-bot · 2025-02-09T19:39:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65097/ 💛

nodejs-github-bot · 2025-02-10T19:59:33Z

Commit Queue failed

- Loading data for nodejs/node/pull/56966 ✔ Done loading data for nodejs/node/pull/56966 ----------------------------------- PR info ------------------------------------ Title timers: set several methods EOL (#56966) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch anonrig:yagiz/eol-timers-fns -> nodejs:main Labels timers, semver-major, deprecations, needs-ci Commits 6 - timers: set several methods EOL - fixup! timers: set several methods EOL - Update doc/api/deprecations.md - Update doc/api/deprecations.md - Update doc/api/deprecations.md - Update doc/api/deprecations.md Committers 2 - Yagiz Nizipli <yagiz@nizipli.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/56966 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56966 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 08 Feb 2025 19:54:12 GMT ✔ Approvals: 5 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56966#pullrequestreview-2604018082 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/56966#pullrequestreview-2604053067 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/56966#pullrequestreview-2604066665 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/56966#pullrequestreview-2604321043 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/56966#pullrequestreview-2604442341 ✔ Last GitHub CI successful ℹ Last CITGM CI on 2025-02-08T23:18:43Z: https://ci.nodejs.org/job/citgm-smoker/3547/ ℹ Last Full PR CI on 2025-02-09T19:39:54Z: https://ci.nodejs.org/job/node-test-pull-request/65097/ - Querying data for job/node-test-pull-request/65097/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 56966 From https://github.com/nodejs/node * branch refs/pull/56966/merge -> FETCH_HEAD ✔ Fetched commits as 3ea97d5c2513..f94223f1e5a1 -------------------------------------------------------------------------------- [main 2ebbf340e3] timers: set several methods EOL Author: Yagiz Nizipli <yagiz@nizipli.com> Date: Sat Feb 8 14:52:40 2025 -0500 10 files changed, 14 insertions(+), 254 deletions(-) delete mode 100644 test/parallel/test-timers-active.js delete mode 100644 test/parallel/test-timers-enroll-invalid-msecs.js delete mode 100644 test/parallel/test-timers-enroll-second-time.js delete mode 100644 test/parallel/test-timers-unref-active.js delete mode 100644 test/parallel/test-timers-unref-remove-other-unref-timers-only-one-fires.js delete mode 100644 test/parallel/test-timers-unref-remove-other-unref-timers.js [main 75817d3c9b] fixup! timers: set several methods EOL Author: Yagiz Nizipli <yagiz@nizipli.com> Date: Sun Feb 9 14:16:36 2025 -0500 1 file changed, 4 insertions(+), 4 deletions(-) [main 55ae74a2db] Update doc/api/deprecations.md Author: Yagiz Nizipli <yagiz@nizipli.com> Date: Sun Feb 9 14:34:20 2025 -0500 1 file changed, 1 insertion(+), 1 deletion(-) [main 419f84c3c3] Update doc/api/deprecations.md Author: Yagiz Nizipli <yagiz@nizipli.com> Date: Sun Feb 9 14:34:28 2025 -0500 1 file changed, 1 insertion(+), 1 deletion(-) [main 905f8b5875] Update doc/api/deprecations.md Author: Yagiz Nizipli <yagiz@nizipli.com> Date: Sun Feb 9 14:34:36 2025 -0500 1 file changed, 1 insertion(+), 1 deletion(-) [main f91c2cffb6] Update doc/api/deprecations.md Author: Yagiz Nizipli <yagiz@nizipli.com> Date: Sun Feb 9 14:34:43 2025 -0500 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 6 commits in the PR. Attempting autorebase. Rebasing (2/11) Rebasing (3/11) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- timers: set several methods EOL

PR-URL: #56966
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

[detached HEAD dd76d08c37] timers: set several methods EOL
Author: Yagiz Nizipli <yagiz@nizipli.com>
Date: Sat Feb 8 14:52:40 2025 -0500
10 files changed, 18 insertions(+), 258 deletions(-)
delete mode 100644 test/parallel/test-timers-active.js
delete mode 100644 test/parallel/test-timers-enroll-invalid-msecs.js
delete mode 100644 test/parallel/test-timers-enroll-second-time.js
delete mode 100644 test/parallel/test-timers-unref-active.js
delete mode 100644 test/parallel/test-timers-unref-remove-other-unref-timers-only-one-fires.js
delete mode 100644 test/parallel/test-timers-unref-remove-other-unref-timers.js
Rebasing (4/11)
Rebasing (5/11)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/deprecations.md

Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #56966
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

[detached HEAD 8695ca90da] Update doc/api/deprecations.md
Author: Yagiz Nizipli <yagiz@nizipli.com>
Date: Sun Feb 9 14:34:20 2025 -0500
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (6/11)
Rebasing (7/11)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/deprecations.md

Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #56966
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

[detached HEAD 425e3e75d3] Update doc/api/deprecations.md
Author: Yagiz Nizipli <yagiz@nizipli.com>
Date: Sun Feb 9 14:34:28 2025 -0500
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (8/11)
Rebasing (9/11)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/deprecations.md

Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #56966
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

[detached HEAD dd17d296f4] Update doc/api/deprecations.md
Author: Yagiz Nizipli <yagiz@nizipli.com>
Date: Sun Feb 9 14:34:36 2025 -0500
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (10/11)
Rebasing (11/11)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/deprecations.md

Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #56966
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

[detached HEAD 935381ce72] Update doc/api/deprecations.md
Author: Yagiz Nizipli <yagiz@nizipli.com>
Date: Sun Feb 9 14:34:43 2025 -0500
1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/13249312889

nodejs-github-bot · 2025-02-10T21:09:43Z

Landed in 5d7091f

PR-URL: nodejs#56966 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Semver-Major Commits: buffer: * (SEMVER-MAJOR) make `buflen` in integer range (zhenweijin) #51821 build: * (SEMVER-MAJOR) bump supported macOS version to 13.5 (Michaël Zasso) #57115 * (SEMVER-MAJOR) increase minimum Xcode version to 16.1 (Michaël Zasso) #56824 * (SEMVER-MAJOR) link V8 with atomic library (Michaël Zasso) #55014 * (SEMVER-MAJOR) remove support for ppc 32-bit (Michaël Zasso) #55014 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #55014 child_process: * (SEMVER-MAJOR) deprecate passing `args` to `spawn` and `execFile` (Daniel Venable) #57199 deps: * (SEMVER-MAJOR) V8: cherry-pick f915fa4c9f41 (Olivier Flückiger) #55014 * (SEMVER-MAJOR) V8: cherry-pick 0d5d6e71bbb0 (Yagiz Nizipli) #55014 * (SEMVER-MAJOR) V8: cherry-pick 0c11feeeca4a (Michaël Zasso) #55014 * (SEMVER-MAJOR) define V8_PRESERVE_MOST as no-op on Windows (Stefan Stojanovic) #55014 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #55014 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #55014 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #55014 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #55014 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #55014 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #55014 * (SEMVER-MAJOR) update V8 to 13.0.245.25 (Michaël Zasso) #55014 * (SEMVER-MAJOR) upgrade npm to 11.0.0 (npm team) #56274 * (SEMVER-MAJOR) update undici to 7.0.0 (Node.js GitHub Bot) #56070 fs: * (SEMVER-MAJOR) remove ability to call truncate with fd (Yagiz Nizipli) #57567 * (SEMVER-MAJOR) remove `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #55862 * (SEMVER-MAJOR) deprecate passing invalid types in `fs.existsSync` (Carlos Espa) #55753 * (SEMVER-MAJOR) runtime deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #49686 * (SEMVER-MAJOR) remove `dirent.path` (Antoine du Hamel) #55548 lib: * (SEMVER-MAJOR) remove obsolete Cipher export (James M Snell) #57266 * (SEMVER-MAJOR) unexpose six process bindings (Michaël Zasso) #57149 * (SEMVER-MAJOR) make ALS default to AsyncContextFrame (Stephen Belanger) #55552 * (SEMVER-MAJOR) runtime deprecate SlowBuffer (Rafael Gonzaga) #55175 net: * (SEMVER-MAJOR) make _setSimultaneousAccepts() end-of-life deprecated (Yagiz Nizipli) #57550 repl: * (SEMVER-MAJOR) runtime deprecate instantiating without new (Aviv Keller) #54869 src: * (SEMVER-MAJOR) update GetForegroundTaskRunner override (Etienne Pierre-doray) #55014 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 134 (Michaël Zasso) #55014 * (SEMVER-MAJOR) drop --experimental-permission in favour of --permission (Rafael Gonzaga) #56240 * (SEMVER-MAJOR) add async context frame to AsyncResource (Gerhard Stöbich) #56082 * (SEMVER-MAJOR) nuke deprecated and un-used enum members in `OptionEnvvarSettings` (Juan José) #53079 stream: * (SEMVER-MAJOR) catch and forward error from dest.write (jakecastelli) #55270 test: * (SEMVER-MAJOR) disable fast API call count checks (Michaël Zasso) #55014 test_runner: * (SEMVER-MAJOR) remove promises returned by t.test() (Colin Ihrig) #56664 * (SEMVER-MAJOR) remove promises returned by test() (Colin Ihrig) #56664 * (SEMVER-MAJOR) automatically wait for subtests to finish (Colin Ihrig) #56664 timers: * (SEMVER-MAJOR) check for immediate instance in clearImmediate (Gürgün Dayıoğlu) #57069 * (SEMVER-MAJOR) set several methods EOL (Yagiz Nizipli) #56966 tls: * (SEMVER-MAJOR) remove deprecated tls.createSecurePair (Jonas) #57361 * (SEMVER-MAJOR) make server.prototype.setOptions end-of-life (Yagiz Nizipli) #57339 tools: * (SEMVER-MAJOR) update V8 gypfiles for 13.0 (Michaël Zasso) #55014 url: * (SEMVER-MAJOR) expose urlpattern as global (Jonas) #56950 * (SEMVER-MAJOR) runtime deprecate url.parse (Yagiz Nizipli) #55017 zlib: * (SEMVER-MAJOR) deprecate classes usage without `new` (Yagiz Nizipli) #55718 PR-URL: TBD

Semver-Major Commits: buffer: * (SEMVER-MAJOR) make `buflen` in integer range (zhenweijin) #51821 build: * (SEMVER-MAJOR) bump supported macOS version to 13.5 (Michaël Zasso) #57115 * (SEMVER-MAJOR) increase minimum Xcode version to 16.1 (Michaël Zasso) #56824 * (SEMVER-MAJOR) link V8 with atomic library (Michaël Zasso) #55014 * (SEMVER-MAJOR) remove support for ppc 32-bit (Michaël Zasso) #55014 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #55014 child_process: * (SEMVER-MAJOR) deprecate passing `args` to `spawn` and `execFile` (Daniel Venable) #57199 deps: * (SEMVER-MAJOR) V8: cherry-pick f915fa4c9f41 (Olivier Flückiger) #55014 * (SEMVER-MAJOR) V8: cherry-pick 0d5d6e71bbb0 (Yagiz Nizipli) #55014 * (SEMVER-MAJOR) V8: cherry-pick 0c11feeeca4a (Michaël Zasso) #55014 * (SEMVER-MAJOR) define V8_PRESERVE_MOST as no-op on Windows (Stefan Stojanovic) #55014 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #55014 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #55014 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #55014 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #55014 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #55014 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #55014 * (SEMVER-MAJOR) update V8 to 13.0.245.25 (Michaël Zasso) #55014 * (SEMVER-MAJOR) upgrade npm to 11.0.0 (npm team) #56274 * (SEMVER-MAJOR) update undici to 7.0.0 (Node.js GitHub Bot) #56070 fs: * (SEMVER-MAJOR) remove ability to call truncate with fd (Yagiz Nizipli) #57567 * (SEMVER-MAJOR) remove `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #55862 * (SEMVER-MAJOR) deprecate passing invalid types in `fs.existsSync` (Carlos Espa) #55753 * (SEMVER-MAJOR) runtime deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #49686 * (SEMVER-MAJOR) remove `dirent.path` (Antoine du Hamel) #55548 lib: * (SEMVER-MAJOR) remove obsolete Cipher export (James M Snell) #57266 * (SEMVER-MAJOR) unexpose six process bindings (Michaël Zasso) #57149 * (SEMVER-MAJOR) make ALS default to AsyncContextFrame (Stephen Belanger) #55552 * (SEMVER-MAJOR) runtime deprecate SlowBuffer (Rafael Gonzaga) #55175 net: * (SEMVER-MAJOR) make _setSimultaneousAccepts() end-of-life deprecated (Yagiz Nizipli) #57550 repl: * (SEMVER-MAJOR) runtime deprecate instantiating without new (Aviv Keller) #54869 src: * (SEMVER-MAJOR) update GetForegroundTaskRunner override (Etienne Pierre-doray) #55014 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 134 (Michaël Zasso) #55014 * (SEMVER-MAJOR) drop --experimental-permission in favour of --permission (Rafael Gonzaga) #56240 * (SEMVER-MAJOR) add async context frame to AsyncResource (Gerhard Stöbich) #56082 * (SEMVER-MAJOR) nuke deprecated and un-used enum members in `OptionEnvvarSettings` (Juan José) #53079 stream: * (SEMVER-MAJOR) catch and forward error from dest.write (jakecastelli) #55270 test: * (SEMVER-MAJOR) disable fast API call count checks (Michaël Zasso) #55014 test_runner: * (SEMVER-MAJOR) remove promises returned by t.test() (Colin Ihrig) #56664 * (SEMVER-MAJOR) remove promises returned by test() (Colin Ihrig) #56664 * (SEMVER-MAJOR) automatically wait for subtests to finish (Colin Ihrig) #56664 timers: * (SEMVER-MAJOR) check for immediate instance in clearImmediate (Gürgün Dayıoğlu) #57069 * (SEMVER-MAJOR) set several methods EOL (Yagiz Nizipli) #56966 tls: * (SEMVER-MAJOR) remove deprecated tls.createSecurePair (Jonas) #57361 * (SEMVER-MAJOR) make server.prototype.setOptions end-of-life (Yagiz Nizipli) #57339 tools: * (SEMVER-MAJOR) update V8 gypfiles for 13.0 (Michaël Zasso) #55014 url: * (SEMVER-MAJOR) expose urlpattern as global (Jonas) #56950 * (SEMVER-MAJOR) runtime deprecate url.parse (Yagiz Nizipli) #55017 zlib: * (SEMVER-MAJOR) deprecate classes usage without `new` (Yagiz Nizipli) #55718 PR-URL: #57609

Semver-Major Commits: buffer: * (SEMVER-MAJOR) make `buflen` in integer range (zhenweijin) #51821 build: * (SEMVER-MAJOR) bump supported macOS version to 13.5 (Michaël Zasso) #57115 * (SEMVER-MAJOR) increase minimum Xcode version to 16.1 (Michaël Zasso) #56824 * (SEMVER-MAJOR) link V8 with atomic library (Michaël Zasso) #55014 * (SEMVER-MAJOR) remove support for ppc 32-bit (Michaël Zasso) #55014 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #55014 child_process: * (SEMVER-MAJOR) deprecate passing `args` to `spawn` and `execFile` (Daniel Venable) #57199 deps: * (SEMVER-MAJOR) V8: cherry-pick f915fa4c9f41 (Olivier Flückiger) #55014 * (SEMVER-MAJOR) V8: cherry-pick 0d5d6e71bbb0 (Yagiz Nizipli) #55014 * (SEMVER-MAJOR) V8: cherry-pick 0c11feeeca4a (Michaël Zasso) #55014 * (SEMVER-MAJOR) define V8_PRESERVE_MOST as no-op on Windows (Stefan Stojanovic) #55014 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #55014 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #55014 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #55014 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #55014 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #55014 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #55014 * (SEMVER-MAJOR) update V8 to 13.0.245.25 (Michaël Zasso) #55014 * (SEMVER-MAJOR) upgrade npm to 11.0.0 (npm team) #56274 * (SEMVER-MAJOR) update undici to 7.0.0 (Node.js GitHub Bot) #56070 fs: * (SEMVER-MAJOR) remove ability to call truncate with fd (Yagiz Nizipli) #57567 * (SEMVER-MAJOR) deprecate passing invalid types in `fs.existsSync` (Carlos Espa) #55753 * (SEMVER-MAJOR) runtime deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #49686 * (SEMVER-MAJOR) remove `dirent.path` (Antoine du Hamel) #55548 lib: * (SEMVER-MAJOR) remove obsolete Cipher export (James M Snell) #57266 * (SEMVER-MAJOR) unexpose six process bindings (Michaël Zasso) #57149 * (SEMVER-MAJOR) make ALS default to AsyncContextFrame (Stephen Belanger) #55552 * (SEMVER-MAJOR) runtime deprecate SlowBuffer (Rafael Gonzaga) #55175 net: * (SEMVER-MAJOR) make _setSimultaneousAccepts() end-of-life deprecated (Yagiz Nizipli) #57550 repl: * (SEMVER-MAJOR) runtime deprecate instantiating without new (Aviv Keller) #54869 src: * (SEMVER-MAJOR) update GetForegroundTaskRunner override (Etienne Pierre-doray) #55014 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 134 (Michaël Zasso) #55014 * (SEMVER-MAJOR) drop --experimental-permission in favour of --permission (Rafael Gonzaga) #56240 * (SEMVER-MAJOR) add async context frame to AsyncResource (Gerhard Stöbich) #56082 * (SEMVER-MAJOR) nuke deprecated and un-used enum members in `OptionEnvvarSettings` (Juan José) #53079 stream: * (SEMVER-MAJOR) catch and forward error from dest.write (jakecastelli) #55270 test: * (SEMVER-MAJOR) disable fast API call count checks (Michaël Zasso) #55014 test_runner: * (SEMVER-MAJOR) remove promises returned by t.test() (Colin Ihrig) #56664 * (SEMVER-MAJOR) remove promises returned by test() (Colin Ihrig) #56664 * (SEMVER-MAJOR) automatically wait for subtests to finish (Colin Ihrig) #56664 timers: * (SEMVER-MAJOR) check for immediate instance in clearImmediate (Gürgün Dayıoğlu) #57069 * (SEMVER-MAJOR) set several methods EOL (Yagiz Nizipli) #56966 tls: * (SEMVER-MAJOR) remove deprecated tls.createSecurePair (Jonas) #57361 * (SEMVER-MAJOR) make server.prototype.setOptions end-of-life (Yagiz Nizipli) #57339 tools: * (SEMVER-MAJOR) update V8 gypfiles for 13.0 (Michaël Zasso) #55014 url: * (SEMVER-MAJOR) expose urlpattern as global (Jonas) #56950 * (SEMVER-MAJOR) runtime deprecate url.parse (Yagiz Nizipli) #55017 zlib: * (SEMVER-MAJOR) deprecate classes usage without `new` (Yagiz Nizipli) #55718 PR-URL: #57609 Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Feb 8, 2025

anonrig force-pushed the yagiz/eol-timers-fns branch from 12fe2b9 to 3be2f72 Compare February 8, 2025 19:55

anonrig added the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 8, 2025

anonrig force-pushed the yagiz/eol-timers-fns branch 2 times, most recently from 4d86d75 to b565091 Compare February 8, 2025 20:06

anonrig added the needs-citgm PRs that need a CITGM CI run. label Feb 8, 2025

timers: set several methods EOL

e359ae6

anonrig force-pushed the yagiz/eol-timers-fns branch from b565091 to e359ae6 Compare February 8, 2025 20:09

jasnell approved these changes Feb 8, 2025

View reviewed changes

targos approved these changes Feb 8, 2025

View reviewed changes

RafaelGSS approved these changes Feb 8, 2025

View reviewed changes

RafaelGSS added the deprecations Issues and PRs related to deprecations. label Feb 8, 2025

anonrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-citgm PRs that need a CITGM CI run. labels Feb 8, 2025

This comment was marked as outdated.

Sign in to view

atlowChemi approved these changes Feb 9, 2025

View reviewed changes

marco-ippolito reviewed Feb 9, 2025

View reviewed changes

doc/api/deprecations.md Show resolved Hide resolved

marco-ippolito requested changes Feb 9, 2025

View reviewed changes

marco-ippolito removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 9, 2025

fixup! timers: set several methods EOL

d0e40a3

anonrig requested a review from marco-ippolito February 9, 2025 19:17

marco-ippolito reviewed Feb 9, 2025

View reviewed changes

doc/api/deprecations.md Outdated Show resolved Hide resolved

marco-ippolito reviewed Feb 9, 2025

View reviewed changes

doc/api/deprecations.md Outdated Show resolved Hide resolved

marco-ippolito reviewed Feb 9, 2025

View reviewed changes

doc/api/deprecations.md Outdated Show resolved Hide resolved

anonrig and others added 4 commits February 9, 2025 14:34

Update doc/api/deprecations.md

d4be015

Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com>

Update doc/api/deprecations.md

455b2ef

Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com>

Update doc/api/deprecations.md

8559006

Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com>

Update doc/api/deprecations.md

f94223f

Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com>

anonrig requested a review from marco-ippolito February 9, 2025 19:34

marco-ippolito approved these changes Feb 9, 2025

View reviewed changes

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 9, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 9, 2025

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 10, 2025

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 10, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 10, 2025

nodejs-github-bot merged commit 5d7091f into nodejs:main Feb 10, 2025
69 checks passed

RafaelGSS mentioned this pull request Mar 24, 2025

2025-04-23, Version 24.0.0 (Current) #57609

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

timers: set several methods EOL #56966

timers: set several methods EOL #56966

anonrig commented Feb 8, 2025 •

edited

Loading

nodejs-github-bot commented Feb 8, 2025

codecov bot commented Feb 8, 2025 •

edited

Loading

anonrig commented Feb 8, 2025

RafaelGSS commented Feb 8, 2025

This comment was marked as outdated.

atlowChemi Feb 9, 2025

anonrig Feb 9, 2025

nodejs-github-bot commented Feb 9, 2025

marco-ippolito left a comment •

edited

Loading

anonrig commented Feb 9, 2025

nodejs-github-bot commented Feb 9, 2025 •

edited by jasnell

Loading

nodejs-github-bot commented Feb 10, 2025

PR-URL: #56966
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

[detached HEAD 935381ce72] Update doc/api/deprecations.md
Author: Yagiz Nizipli <yagiz@nizipli.com>
Date: Sun Feb 9 14:34:43 2025 -0500
1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Feb 10, 2025

timers: set several methods EOL #56966

timers: set several methods EOL #56966

Conversation

anonrig commented Feb 8, 2025 • edited Loading

nodejs-github-bot commented Feb 8, 2025

codecov bot commented Feb 8, 2025 • edited Loading

Codecov Report

anonrig commented Feb 8, 2025

RafaelGSS commented Feb 8, 2025

This comment was marked as outdated.

atlowChemi Feb 9, 2025

Choose a reason for hiding this comment

anonrig Feb 9, 2025

Choose a reason for hiding this comment

nodejs-github-bot commented Feb 9, 2025

marco-ippolito left a comment • edited Loading

Choose a reason for hiding this comment

anonrig commented Feb 9, 2025

nodejs-github-bot commented Feb 9, 2025 • edited by jasnell Loading

nodejs-github-bot commented Feb 10, 2025

PR-URL: #56966 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

[detached HEAD 935381ce72] Update doc/api/deprecations.md Author: Yagiz Nizipli <yagiz@nizipli.com> Date: Sun Feb 9 14:34:43 2025 -0500 1 file changed, 1 insertion(+), 1 deletion(-) Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Feb 10, 2025

anonrig commented Feb 8, 2025 •

edited

Loading

codecov bot commented Feb 8, 2025 •

edited

Loading

marco-ippolito left a comment •

edited

Loading

nodejs-github-bot commented Feb 9, 2025 •

edited by jasnell

Loading

PR-URL: #56966
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

[detached HEAD 935381ce72] Update doc/api/deprecations.md
Author: Yagiz Nizipli <yagiz@nizipli.com>
Date: Sun Feb 9 14:34:43 2025 -0500
1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.