Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: drop --experimental-permission in favour of --permission #56240

Merged
merged 1 commit into from
Jan 3, 2025
Merged

src: drop --experimental-permission in favour of --permission #56240

merged 1 commit into from
Jan 3, 2025
+0 −2

Conversation

RafaelGSS
Copy link
Member

Refs: #56201

@RafaelGSS RafaelGSS added semver-major PRs that contain breaking changes and should be released in the next major version. permission Issues and PRs related to the Permission Model labels Dec 12, 2024
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Dec 12, 2024
@targos
Copy link
Member

targos commented Dec 12, 2024

Can you avoid using a flag name that doesn't exist in the commit message?

@RafaelGSS RafaelGSS changed the title src: drop --experimental-pm in favour of --permission src: drop --experimental-permission in favour of --permission Dec 12, 2024
@RafaelGSS RafaelGSS force-pushed the drop-experimental-from-permission-flag branch from 6ece60e to 6d7dfa8 Compare December 12, 2024 15:17
@RafaelGSS
Copy link
Member Author

RafaelGSS commented Dec 12, 2024 •
edited
Loading

Can you avoid using a flag name that doesn't exist in the commit message?

I think linter will complain, just updated

@RafaelGSS
Copy link
Member Author

Depends on: #56239

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 24, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 24, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64198/

@RafaelGSS
Copy link
Member Author

I need to rebase it on main. Will do it right after the holidays.

@RafaelGSS RafaelGSS force-pushed the drop-experimental-from-permission-flag branch from 6d7dfa8 to 5e8003d Compare January 2, 2025 13:48
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 2, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 2, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64290/

@codecov Codecov
Copy link

codecov bot commented Jan 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.54%. Comparing base (98d4ebc) to head (5e8003d).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #56240   +/-   ##
=======================================
  Coverage   88.53%   88.54%           
=======================================
  Files         657      657           
  Lines      190741   190740    -1     
  Branches    36607    36611    +4     
=======================================
+ Hits       168881   168893   +12     
+ Misses      15036    15031    -5     
+ Partials     6824     6816    -8
Files with missing lines Coverage Δ
src/node_options.cc 87.90% <ø> (-0.02%) ⬇️

... and 25 files with indirect coverage changes

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64298/

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 3, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 3, 2025
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/56240
✔  Done loading data for nodejs/node/pull/56240
----------------------------------- PR info ------------------------------------
Title      src: drop --experimental-permission in favour of --permission (#56240)
Author     Rafael Gonzaga <rafael.nunu@hotmail.com> (@RafaelGSS)
Branch     RafaelGSS:drop-experimental-from-permission-flag -> nodejs:main
Labels     c++, semver-major, needs-ci, permission
Commits    1
 - src: drop --experimental-permission in favour of --permission
Committers 1
 - RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/56240
Refs: https://github.com/nodejs/node/pull/56201
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/56240
Refs: https://github.com/nodejs/node/pull/56201
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - src: drop --experimental-permission in favour of --permission
   ℹ  This PR was created on Thu, 12 Dec 2024 15:09:20 GMT
   ✔  Approvals: 4
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56240#pullrequestreview-2500132554
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/56240#pullrequestreview-2502457189
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/56240#pullrequestreview-2503634697
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/56240#pullrequestreview-2522146356
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-01-02T20:39:19Z: https://ci.nodejs.org/job/node-test-pull-request/64298/
- Querying data for job/node-test-pull-request/64298/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/12598760537

@RafaelGSS
Copy link
Member Author

Could someone re-approve? I had to rebase it on top of main.

@RafaelGSS RafaelGSS removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jan 3, 2025
@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 3, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 3, 2025
@nodejs-github-bot nodejs-github-bot merged commit bf3bc4e into nodejs:main Jan 3, 2025
69 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in bf3bc4e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertcanaltin mertcanaltin mertcanaltin approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@RafaelGSS @targos @nodejs-github-bot @jasnell @lpinca @anonrig @marco-ippolito @mertcanaltin