-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
src: fix -Wshadow warning
#53885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
codebytere:remove-shadowed-variable
Jul 24, 2024
Merged
src: fix -Wshadow warning
#53885
nodejs-github-bot
merged 1 commit into
nodejs:main
from
codebytere:remove-shadowed-variable
Jul 24, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d94fd5 to
adc2a57
Compare
targos
approved these changes
Jul 17, 2024
anonrig
approved these changes
Jul 17, 2024
tniessen
approved these changes
Jul 17, 2024
lpinca
approved these changes
Jul 18, 2024
Collaborator
Member
Author
|
Haven't landed anything in a while so double checking - is this |
Member
|
Yes, indeed :) |
Member
|
It looks ready to me! You can add the |
Collaborator
|
Landed in e440540 |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In utils.h's
ERROR_AND_ABORTmacro, rename the static local variableargsto avoid -Wshadow warnings in code that callsERROR_AND_ABORT(). This allows Electron to remove a patch.Relevant console output: