Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 12.4 #52465

Closed
wants to merge 15 commits into from
Closed

deps: update V8 to 12.4 #52465

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d887f85
deps: update V8 to 12.4.254.14
targos Apr 19, 2024
e4c6f08
build: reset embedder string to "-node.0"
targos Apr 19, 2024
8d1bbf8
src: update NODE_MODULE_VERSION to 127
targos Apr 19, 2024
88a4285
deps: always define V8_EXPORT_PRIVATE as no-op
targos Sep 21, 2022
a41d78c
deps: silence irrelevant V8 warning
targos Jun 21, 2022
1999abf
deps: disable V8 concurrent sparkplug compilation
targos Apr 6, 2023
6be9104
deps: avoid compilation error with ASan
targos Jul 31, 2023
915255b
deps: remove usage of a C++20 feature from V8
targos Aug 10, 2023
c09d25f
deps: patch V8 to avoid duplicated zlib symbol
targos Sep 16, 2023
2aa1874
deps: silence internal V8 deprecation warning
targos Mar 11, 2024
486bbc8
build: compile with C++20 support on Windows
StefanStojanovic Apr 21, 2024
55deada
deps: patch V8 to support compilation with MSVC
StefanStojanovic Apr 21, 2024
e5a2b47
deps: V8: revert CL 5331688
targos Apr 21, 2024
5d0cc1b
deps: V8: cherry-pick cd10ad7cdbe5
joyeecheung Apr 14, 2024
a9c7011
tools: update V8 gypfiles for 12.4
targos Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: disable V8 concurrent sparkplug compilation 
It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: #47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: #47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@targos
targos committed Apr 19, 2024
commit 1999abff080fe81ba3051c2725fa4b3791b8ff50
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.2',
'v8_embedder_string': '-node.3',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/flags/flag-definitions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,7 +978,7 @@ DEFINE_BOOL(baseline_batch_compilation, true, "batch compile Sparkplug code")
DEFINE_BOOL_READONLY(concurrent_sparkplug, false,
"compile Sparkplug code in a background thread")
#else
DEFINE_BOOL(concurrent_sparkplug, ENABLE_SPARKPLUG_BY_DEFAULT,
DEFINE_BOOL(concurrent_sparkplug, false,
"compile Sparkplug code in a background thread")
DEFINE_WEAK_IMPLICATION(future, concurrent_sparkplug)
DEFINE_NEG_IMPLICATION(predictable, concurrent_sparkplug)
Expand Down