Skip to content

deps: update V8 to 12.4 #52465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 4 additions & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,10 @@
'VCCLCompilerTool': {
'AdditionalOptions': [
'/Zc:__cplusplus',
'-std:c++17'
# The following option enables c++20 on Windows. This is needed for V8 v12.4+
'-std:c++20',
# The following option reduces the "error C1060: compiler is out of heap space"
'/Zm2000',
],
'BufferSecurityCheck': 'true',
'DebugInformationFormat': 1, # /Z7 embed info in .obj files
Expand Down
8 changes: 7 additions & 1 deletion deps/v8/.clang-format
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,13 @@
BasedOnStyle: Google
DerivePointerAlignment: false
MaxEmptyLinesToKeep: 1
IfMacros: ['IF', 'IF_NOT', 'ELSE', 'ELSE_IF']
IfMacros:
- IF
- IF_NOT
Macros:
# Make clang-format think TurboShaft `ELSE` expands to just `else`, so that
# it formats well alongside `if`
- ELSE=else
StatementMacros:
- DECL_CAST
- DECL_VERIFIER
3 changes: 3 additions & 0 deletions deps/v8/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -134,3 +134,6 @@ bazel-v8
!/third_party/abseil-cpp
/third_party/abseil-cpp/.github
/third_party/abseil-cpp/ci
!/third_party/fp16
/third_party/fp16/src/*
!/third_party/fp16/src/include
3 changes: 3 additions & 0 deletions deps/v8/AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ Benjamin Tan <demoneaux@gmail.com>
Bert Belder <bertbelder@gmail.com>
Brendon Tiszka <btiszka@gmail.com>
Brice Dobry <brice.dobry@futurewei.com>
Bruno Pitrus <brunopitrus@hotmail.com>
Burcu Dogan <burcujdogan@gmail.com>
Caitlin Potter <caitpotter88@gmail.com>
Chao Wang <chao.w@rioslab.org>
Expand Down Expand Up @@ -109,6 +110,7 @@ Deepak Mohan <hop2deep@gmail.com>
Deon Dior <diaoyuanjie@gmail.com>
Derek Tu <derek.t@rioslab.org>
Divy Srivastava <dj.srivastava23@gmail.com>
Dmitry Bezhetskov <dima00782@gmail.com>
Dominic Chen <d.c.ddcc@gmail.com>
Dominic Farolini <domfarolino@gmail.com>
Douglas Crosher <dtc-v8@scieneer.com>
Expand Down Expand Up @@ -232,6 +234,7 @@ Peter Varga <pvarga@inf.u-szeged.hu>
Peter Wong <peter.wm.wong@gmail.com>
PhistucK <phistuck@gmail.com>
Pierrick Bouvier <pierrick.bouvier@linaro.org>
Punith B Nayak <npunith125@gmail.com>
Rafal Krypa <rafal@krypa.net>
Raul Tambre <raul@tambre.ee>
Ray Glover <ray@rayglover.net>
Expand Down
36 changes: 28 additions & 8 deletions deps/v8/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -674,6 +674,7 @@ filegroup(
name = "v8_flags",
srcs = [
"src/flags/flag-definitions.h",
"src/flags/flags-impl.h",
"src/flags/flags.h",
] + select({
"is_v8_enable_webassembly": ["src/wasm/wasm-feature-flags.h"],
Expand Down Expand Up @@ -802,7 +803,6 @@ filegroup(
"src/base/timezone-cache.h",
"src/base/utils/random-number-generator.cc",
"src/base/utils/random-number-generator.h",
"src/base/v8-fallthrough.h",
"src/base/vector.h",
"src/base/virtual-address-space.cc",
"src/base/virtual-address-space.h",
Expand Down Expand Up @@ -1540,6 +1540,7 @@ filegroup(
"src/extensions/trigger-failure-extension.cc",
"src/extensions/trigger-failure-extension.h",
"src/flags/flag-definitions.h",
"src/flags/flags-impl.h",
"src/flags/flags.cc",
"src/flags/flags.h",
"src/handles/global-handles.cc",
Expand Down Expand Up @@ -1569,8 +1570,8 @@ filegroup(
"src/heap/base-space.h",
"src/heap/base/active-system-pages.cc",
"src/heap/base/active-system-pages.h",
"src/heap/basic-memory-chunk.cc",
"src/heap/basic-memory-chunk.h",
"src/heap/memory-chunk-metadata.cc",
"src/heap/memory-chunk-metadata.h",
"src/heap/code-range.cc",
"src/heap/code-range.h",
"src/heap/trusted-range.cc",
Expand Down Expand Up @@ -1687,11 +1688,11 @@ filegroup(
"src/heap/memory-allocator.h",
"src/heap/memory-balancer.cc",
"src/heap/memory-balancer.h",
"src/heap/mutable-page.cc",
"src/heap/mutable-page.h",
"src/heap/memory-chunk.cc",
"src/heap/memory-chunk.h",
"src/heap/memory-chunk-header.cc",
"src/heap/memory-chunk-header.h",
"src/heap/memory-chunk-inl.h",
"src/heap/mutable-page-inl.h",
"src/heap/memory-chunk-layout.cc",
"src/heap/memory-chunk-layout.h",
"src/heap/memory-measurement.cc",
Expand Down Expand Up @@ -2805,6 +2806,8 @@ filegroup(
"src/wasm/function-body-decoder-impl.h",
"src/wasm/function-compiler.cc",
"src/wasm/function-compiler.h",
"src/wasm/fuzzing/random-module-generation.cc",
"src/wasm/fuzzing/random-module-generation.h",
"src/wasm/graph-builder-interface.cc",
"src/wasm/graph-builder-interface.h",
"src/wasm/inlining-tree.h",
Expand Down Expand Up @@ -3144,6 +3147,7 @@ filegroup(
"src/compiler/phase.h",
"src/compiler/pipeline.cc",
"src/compiler/pipeline.h",
"src/compiler/pipeline-data-inl.h",
"src/compiler/pipeline-statistics.cc",
"src/compiler/pipeline-statistics.h",
"src/compiler/processed-feedback.h",
Expand Down Expand Up @@ -3213,6 +3217,7 @@ filegroup(
"src/compiler/turboshaft/graph-builder.h",
"src/compiler/turboshaft/graph-visualizer.cc",
"src/compiler/turboshaft/graph-visualizer.h",
"src/compiler/turboshaft/js-generic-lowering-reducer.h",
"src/compiler/turboshaft/index.h",
"src/compiler/turboshaft/instruction-selection-phase.cc",
"src/compiler/turboshaft/instruction-selection-phase.h",
Expand All @@ -3234,6 +3239,7 @@ filegroup(
"src/compiler/turboshaft/machine-lowering-phase.cc",
"src/compiler/turboshaft/machine-lowering-phase.h",
"src/compiler/turboshaft/machine-lowering-reducer-inl.h",
"src/compiler/turboshaft/maglev-early-lowering-reducer-inl.h",
"src/compiler/turboshaft/maglev-graph-building-phase.cc",
"src/compiler/turboshaft/maglev-graph-building-phase.h",
"src/compiler/turboshaft/machine-optimization-reducer.h",
Expand Down Expand Up @@ -3479,6 +3485,7 @@ filegroup(
"src/builtins/setup-builtins-internal.cc",
"src/builtins/torque-csa-header-includes.h",
"src/codegen/code-stub-assembler.cc",
"third_party/v8/codegen/fp16-inl.h",
"src/codegen/code-stub-assembler-inl.h",
"src/codegen/code-stub-assembler.h",
"src/heap/setup-heap-internal.cc",
Expand Down Expand Up @@ -3678,6 +3685,18 @@ filegroup(
}),
)

v8_library(
name = "lib_fp16",
srcs = ["third_party/fp16/src/include/fp16.h"],
hdrs = [
"third_party/fp16/src/include/fp16/fp16.h",
"third_party/fp16/src/include/fp16/bitcasts.h",
],
includes = [
"third_party/fp16/src/include",
],
)

filegroup(
name = "v8_bigint",
srcs = [
Expand Down Expand Up @@ -4167,6 +4186,7 @@ v8_library(
":noicu/generated_torque_definitions",
],
deps = [
":lib_fp16",
":v8_libbase",
"//external:base_trace_event_common",
"//external:absl_btree",
Expand Down Expand Up @@ -4223,11 +4243,11 @@ alias(

v8_library(
name = "v8_vtune",
srcs = glob([
srcs = [
"src/third_party/vtune/v8-vtune.h",
"src/third_party/vtune/vtune-jit.cc",
"src/third_party/vtune/vtune-jit.h",
]),
],
copts = ["-I"],
deps = [
":core_lib_noicu",
Expand Down
Loading