[v18.x backport] fs: introduce dirent.parentPath
#51021
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is to replace `dirent.path` using a name that's less likely to create confusion. `dirent.path` value has not been stable, moving it to a different property name should avoid breaking some upgrading user expectations. PR-URL: nodejs#50976 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: LiviaMedeiros <livia@cirno.name>
nodejs-github-bot
added
fs
PR-URL: nodejs#51020 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Refs: nodejs#51020 PR-URL: nodejs#51059 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
richardlau
approved these changes
Mar 18, 2024
richardlau
pushed a commit
that referenced
this pull request
Mar 18, 2024
The goal is to replace `dirent.path` using a name that's less likely to create confusion. `dirent.path` value has not been stable, moving it to a different property name should avoid breaking some upgrading user expectations. PR-URL: #50976 Backport-PR-URL: #51021 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: LiviaMedeiros <livia@cirno.name>
richardlau
pushed a commit
that referenced
this pull request
Mar 18, 2024
Member
|
Landed in 96514a8...194ff6a. |
sonsurim
pushed a commit
to sonsurim/node
that referenced
this pull request
Jul 21, 2024
…addir' The issue was caused by a modification in PR nodejs#51021 , which was working on including the parentPath in the documentation and modifying the path to display the filepath. I have retained the content related to the documentation and removed the filepath part. Fixes: nodejs#52441 Co-authored-by: daeyoen <6630703+daeyeon@users.noreply.github.com> Co-authored-by: injae-kim <injae-kim@users.noreply.github.com>"
sonsurim
pushed a commit
to sonsurim/node
that referenced
this pull request
Jul 21, 2024
The issue was caused by a modification in PR nodejs#51021, which included changes to the documentation for parentPath and modifications to display the filepath. I have retained the content related to the documentation and removed the filepath part. Fixes: nodejs#52441 Co-authored-by: injae-kim <injae-kim@users.noreply.github.com>
sonsurim
pushed a commit
to sonsurim/node
that referenced
this pull request
Jul 21, 2024
The issue was caused by a modification in PR nodejs#51021, which included changes to the documentation for parentPath and modifications to display the filepath. I have retained the content related to the documentation and removed the filepath part. Fixes: nodejs#52441 Co-authored-by: injae-kim <injae-kim@users.noreply.github.com>
sonsurim
pushed a commit
to sonsurim/node
that referenced
this pull request
Jul 21, 2024
The issue was caused by a modification in PR nodejs#51021, which included changes to the documentation for parentPath and modifications to display the file path. I have retained the content related to the documentation and removed the filepath part. Fixes: nodejs#52441 Co-authored-by: injae-kim <injae-kim@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to replace
dirent.pathusing a name that's less likely to create confusion.dirent.pathvalue has not been stable, moving it to a different property name should avoid breaking some upgrading user expectations.PR-URL: #50976
Reviewed-By: Ethan Arrowood ethan@arrowood.dev
Reviewed-By: LiviaMedeiros livia@cirno.name