Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 96514a8b9fdbd19e4bf7171d4ab935c4c9c7f973
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 194ff6a40f9a9655c6403e1d7d7048490d78fc77
Choose a head ref
  • 3 commits
  • 5 files changed
  • 1 contributor

Commits on Mar 18, 2024

  1. fs: introduce dirent.parentPath 

    The goal is to replace `dirent.path` using a name that's less likely to
create confusion.
`dirent.path` value has not been stable, moving it to a different
property name should avoid breaking some upgrading user expectations.

PR-URL: #50976
Backport-PR-URL: #51021
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
    @aduh95 @richardlau
    aduh95 authored and richardlau committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    26e8f77 View commit details
    Browse the repository at this point in the history

  2. doc: deprecate dirent.path 

    PR-URL: #51020
Backport-PR-URL: #51021
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
PR-URL: #50976
    @aduh95 @richardlau
    aduh95 authored and richardlau committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    0f09267 View commit details
    Browse the repository at this point in the history

  3. doc: add deprecation notice to dirent.path 

    Refs: #51020
PR-URL: #51059
Backport-PR-URL: #51021
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
PR-URL: #50976
    @aduh95 @richardlau
    aduh95 authored and richardlau committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    194ff6a View commit details
    Browse the repository at this point in the history
Loading