Closed
Conversation
Contributor
|
Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve. |
lpinca
approved these changes
Oct 31, 2023
lukekarrys
approved these changes
Oct 31, 2023
Collaborator
24 tasks
Collaborator
Collaborator
25 tasks
Collaborator
Member
|
The AIX failure looks like it might be a regression in node-gyp@10.0.0: 06:47:36 gyp ERR! stack TypeError: findAccessibleSync is not a function
06:47:36 gyp ERR! stack at runGyp (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/deps/npm/node_modules/node-gyp/lib/configure.js:153:21)
06:47:36 gyp ERR! stack at findConfigs (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/deps/npm/node_modules/node-gyp/lib/configure.js:85:14)
06:47:36 gyp ERR! stack at findConfigs (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/deps/npm/node_modules/node-gyp/lib/configure.js:101:12)
06:47:36 gyp ERR! stack at async run (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/deps/npm/node_modules/node-gyp/bin/node-gyp.js:81:18)
06:47:36 gyp ERR! System AIX 7.2
06:47:36 gyp ERR! command "/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/node" "/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/deps/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--directory=/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/benchmark/napi/define_properties" |
Contributor
|
That method got moved in this commit and |
3 tasks
Member
I think nodejs/node-gyp#2936 should fix it. |
Contributor
Author
|
Closing in favor of #50531 |
This was referenced Nov 3, 2023
This was referenced Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains changes from:
npm@10.2.1npm@10.2.2This PR replaces: nodejs/node#50258
10.2.1
10.2.1 (2023-10-18)
Bug Fixes
35c92fe#6902 Add check to pkg command to deal with empty values (#6902) (@NeonArray)5b6172f#6895 logout from custom registry (@wraithgar)8423d4f#6895 delete auth from proper location on logout (@wraithgar)0cfe9de#6873 audit: spelling error in message (#6873) (@Fdawgs)Documentation
5142735#6894 update npm build description (#6894) (@siemhesda)2e4b4ad#6861 npm publish content modification (#6861) (@jpg619)Dependencies
96e1637#6915cmd-shim@6.0.2(#6915)b405da1#6899bin-links@4.0.3ef69d36#6895npm-registry-fetch@16.1.0337c903#6882spdx-license-ids@3.0.16e6b0be7#6882socks-proxy-agent@8.0.2ee6892e#6882readable-stream@4.4.261c3ee9#6882minipass@7.0.414d31fd#6882is-core-module@2.13.003f3d2e#6882https-proxy-agent@7.0.2e0163c6#6882are-we-there-yet@4.0.1fca804a#6882ci-info@3.9.06af582f#6882npm-install-checks@6.3.0@npmcli/config@8.0.110.2.2
10.2.2 (2023-10-31)
Bug Fixes
8ed6d28#6910 make npm link respect --no-save (#6910) (@Santoshraj2)eacec5f#6941 add back bin/node-gyp-bin/node-gyp files (#6941) (@lukekarrys)b776753#6928 Grammar mistake in authentication error message (#6928) (@Gekuro, gek)Documentation
c422a01#6924 use markdown links instead of html (@lukekarrys)dd03aa0#6921 add v9 and above for lockfile version 3 (#6921) (@MikeMcC399)Dependencies
dfb6298#6937node-gyp@10.0.0(#6937)@npmcli/arborist@7.2.1libnpmdiff@6.0.3libnpmexec@7.0.3libnpmfund@5.0.1libnpmpack@6.0.3libnpmversion@5.0.1