fix: use local util for findAccessibleSync()#2936
Merged
lukekarrys merged 1 commit intonodejs:mainfrom Nov 2, 2023
Merged
Conversation
The `findAccessibleSync()` function is in the local `util` module instead of Node.js' builtin `util` module.
Member
Author
|
Took me a while to figure out how to get citgm-smoker-nobuild to run with this PR[1]:
[1]: I had to use for some reason citgm fails to find tests if run with |
Contributor
|
You've got good eyes, I did NOT see the |
Member
Author
That's because it was missing 😆. |
Member
|
Thank you @richardlau! I've published |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm run lint && npm testpassesDescription of change
The
findAccessibleSync()function is in the localutilmodule instead of Node.js' builtinutilmodule.Refs: nodejs/node#50493 (comment)
Existing tests should cover this, but only on AIX or z/OS, neither of which are available on GitHub Actions (and neither of those OSes are a supported platform for running a self-hosted runner).