fs: improve error performance for writeSync

[pluris]

I worked on it because it seemed like there was still work left to do in nodejs/performance#106.

                                              confidence improvement accuracy (*)    (**)   (***)
fs/bench-writeSync.js n=100000 type='invalid'        ***    116.41 %       ±9.35% ±12.49% ±16.36%
fs/bench-writeSync.js n=100000 type='valid'                   0.46 %       ±6.13%  ±8.16% ±10.62%

Be aware that when doing many comparisons the risk of a false-positive result increases.
In this case, there are 2 comparisons, you can thus expect the following amount of false-positive results:
  0.10 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.02 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)

Refs: nodejs/performance#106

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55187/

[anonrig]

@pluris the tests are failing

[pluris]

@anonrig After rebasing and checking, there seems to be a problem. I will fix it and let you know. thank you

[pluris]

Something is weird. It seems like a fail occurs in parallel.test-release-changelog.
It seems to be happening in other PR as well. (#50361)
Could it be related to the recent commit that changed the CHANGELOG file?

[richardlau]

Something is weird. It seems like a fail occurs in parallel.test-release-changelog. It seems to be happening in other PR as well. (#50361) Could it be related to the recent commit that changed the CHANGELOG file?

#50373. Being fixed by #50375. Will need a fresh (not resumed) CI run to pick up the change when it lands on main.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55210/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55241/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56175/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56521/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56550/

[aduh95]

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1490/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56597/

[PodaruDragos]

hey guys, is there anything that's blocking this one out ?