-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: fix node_version.h #50375
src: fix node_version.h #50375
Conversation
Fast-track has been requested by @joyeecheung. Please 👍 to approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the version actually be 22.0.0
?
Yes, I think we're missing a step for semver major releases in the release process to bump the major version on |
Something is wrong with the test, if I change it to 22.0.0:
|
@joyeecheung you probably need to fix the IS_RELEASE macro at the same time. I think the bug slipped through because both mistakes happened. |
Maybe we should just skip the test when it's not run on a release? |
Oh, I see, it was supposed to skip, but NODE_VERSION_IS_RELEASE wasn't updated either. |
- Fix the version for main branch as 22.0.0 - Fix the NODE_VERSION_IS_RELEASE flag for the main branch This would allow test/parallel/test-release-changelog.js to pass again on the main branch.
06fd739
to
c770105
Compare
Fast-track has been requested by @joyeecheung. Please 👍 to approve. |
Landed in 89a26b4 |
- Fix the version for main branch as 22.0.0 - Fix the NODE_VERSION_IS_RELEASE flag for the main branch This would allow test/parallel/test-release-changelog.js to pass again on the main branch. PR-URL: nodejs#50375 Fixes: nodejs#50373 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This would allow test/parallel/test-release-changelog.js
to pass again on the main branch.
Fixes: #50373