Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add information about Node-API versions >=9 #50168

Closed
wants to merge 15 commits into from

Conversation

mhdawson
Copy link
Member

No description provided.

Signed-off-by: Michael Dawson <midawson@redhat.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/node-api

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Oct 12, 2023
@mhdawson
Copy link
Member Author

@legendecas can you review to confirm I've gotten this correct.

doc/api/n-api.md Outdated Show resolved Hide resolved
doc/api/n-api.md Outdated Show resolved Hide resolved
doc/api/n-api.md Outdated Show resolved Hide resolved
mhdawson and others added 2 commits October 13, 2023 15:48
Signed-off-by: Michael Dawson <midawson@redhat.com>
doc/api/n-api.md Outdated Show resolved Hide resolved
mhdawson and others added 2 commits October 17, 2023 14:00
Co-authored-by: Alex Strizhak <alexei.mifrill.strizhak@gmail.com>
doc/api/n-api.md Outdated Show resolved Hide resolved
doc/api/n-api.md Outdated Show resolved Hide resolved
doc/api/n-api.md Outdated Show resolved Hide resolved
doc/api/n-api.md Outdated Show resolved Hide resolved
doc/api/n-api.md Outdated Show resolved Hide resolved
doc/api/n-api.md Outdated Show resolved Hide resolved
doc/api/n-api.md Outdated Show resolved Hide resolved
doc/api/n-api.md Outdated Show resolved Hide resolved
mhdawson and others added 8 commits October 20, 2023 09:34
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
@mhdawson
Copy link
Member Author

@gabrielschulhof thanks for the suggestions, pulled them all in.

@mhdawson
Copy link
Member Author

@gabrielschulhof @vmoroz believe it is ready for rev-review.

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

mhdawson added a commit that referenced this pull request Oct 25, 2023
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #50168
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@mhdawson
Copy link
Member Author

Landed in 7d30667

@mhdawson mhdawson closed this Oct 25, 2023
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#50168
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #50168
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #50168
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants