Skip to content

[v16.x] build, deps, tools: avoid excessive LTO, PGO, debug information #49066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[v16.x] build, deps, tools: avoid excessive LTO, PGO, debug information #49066

wants to merge 3 commits into from

Conversation

@rockdrilla
Copy link
Contributor

@rockdrilla rockdrilla commented Aug 8, 2023

This PR is backport of #49063 for "v16.x" branch.

Signed-off-by: Konstantin Demin rockdrilla@gmail.com

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 8, 2023

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. i18n-api Issues and PRs related to the i18n implementation. icu Issues and PRs related to the ICU dependency. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. tools Issues and PRs related to the tools directory. v16.x v8 engine Issues and PRs related to the V8 dependency. labels Aug 8, 2023
@rockdrilla
build, deps, tools: avoid excessive LTO
b0906d2 
Don't link intermediate executables with LTO in order to speed up
overall build time.

Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
@rockdrilla
build, deps, tools: avoid excessive PGO
a9d391d 
Don't build intermediate executables with PGO in order to speed up
overall build time.

Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
@rockdrilla
build, tools: avoid extra debug information
c481224 
Don't build intermediate executables with debug information in order
to save some disk space during build.

Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
@rockdrilla rockdrilla marked this pull request as draft August 8, 2023 09:55
@richardlau
Copy link
Member

richardlau commented Aug 24, 2023

This is unlikely to land on Node.js 16 given that it reaches End-of-Life in a few weeks on 11 September 2023.

@richardlau richardlau mentioned this pull request Aug 24, 2023
Closed
@rockdrilla
Copy link
Contributor Author

rockdrilla commented Aug 24, 2023

Got it, thanks!

@rockdrilla rockdrilla closed this Aug 24, 2023
@rockdrilla rockdrilla deleted the build-flags-v16.x branch September 16, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. i18n-api Issues and PRs related to the i18n implementation. icu Issues and PRs related to the ICU dependency. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rockdrilla @nodejs-github-bot @richardlau