Skip to content

[v16.x] doc: include git add -f to include folder - #49004

Closed
RafaelGSS wants to merge 1 commit into
nodejs:v16.x-stagingfrom
RafaelGSS:doc/force-git-include-crypto
Closed

RafaelGSS wants to merge 1 commit into
nodejs:v16.x-stagingfrom
RafaelGSS:doc/force-git-include-crypto

Conversation

@RafaelGSS

Copy link
Copy Markdown
Member

Ref:

$ git add deps/openssl/openssl/include/openssl/opensslconf.h
The following paths are ignored by one of your .gitignore files:
deps/openssl/openssl/include/openssl/opensslconf.h
hint: Use -f if you really want to add them.
hint: Turn this message off by running
hint: "git config advice.addIgnoredFile false"

The .gitignore from quictls/openssl is read by git so we need to force include it

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@RafaelGSS RafaelGSS added the v16.x label Aug 3, 2023
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Aug 3, 2023
@RafaelGSS RafaelGSS changed the title doc: include git add -f to include folder [v16.x] doc: include git add -f to include folder Aug 3, 2023
@RafaelGSS
RafaelGSS force-pushed the doc/force-git-include-crypto branch from 097fecb to 8858fc2 Compare August 11, 2023 23:25
@richardlau

Copy link
Copy Markdown
Member

The .gitignore from quictls/openssl is read by git so we need to force include it

I don't object to the change being proposed by this PR, but it should be unnecessary -- the .gitignore file being referenced should have been removed by

% rm -rf openssl/.git* openssl/.travis*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants