Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check added for destroyed stream in onwrite function #48772

Closed
wants to merge 2 commits into from
Closed

Check added for destroyed stream in onwrite function #48772

wants to merge 2 commits into from

Conversation

Prateek462003
Copy link

fixes #39030

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 14, 2023
@ronag
Copy link
Member

ronag commented Jul 14, 2023

Missing test

mcollina
mcollina requested changes Jul 15, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test?

lib/internal/streams/writable.js
@@ -292,7 +292,7 @@ Writable.prototype.pipe = function() {

function _write(stream, chunk, encoding, cb) {
const state = stream._writableState;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please restore this

ronag
ronag requested changes Jul 15, 2023
View reviewed changes
Copy link
Member

@ronag ronag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a test. And this will cause unhandled exception.

@Prateek462003 Prateek462003 closed this by deleting the head repository Jul 19, 2023
@Prateek462003
Copy link
Author

i can't see a way to go solve this issue without changing the existing test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronag ronag ronag requested changes

@mcollina mcollina mcollina requested changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Writable does not check if stream has been destroyed during _final and _write
4 participants
@Prateek462003 @nodejs-github-bot @ronag @mcollina