Writable does not check if stream has been destroyed during _final and _write

[ronag]

Not sure if this is a problem but I think we should at least add a comment in the code that this case has been considered.

[targos]

@nodejs/streams

[mcollina]

I don't know to be honest as I don't want to make things too stringent. However adding a check is going to improve the developer experience.

What should the check do? Throw? emit 'error'?

[ronag]

I think:

1. cancel any further substeps
2. if stream was destroyed without error, override with error

[mcollina]

Should we tag this as good first issue?

[mdaj06]

@ronag Can i take this up?

[mcollina]

Go for it!

[Svanazar]

Hey! I was wondering about the status of this issue, and if I could try looking into it?

[mcollina]

Go for it!

[Svanazar]

I went through Writable.js, but I'm not sure where should the checks be added. Specifically, I found these to be already present:

• _write at line 321 checks for state.destroyed before going to the user-provided _write function
• _final seems to be called through prefinish which also checks for state.destroyed at line 718

I'll really appreciate some guidance on this