-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: keep the names in sorted order #4876
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The release team's names were not in the sorted order and 2. the old list of releasers' names were not in bold This patch fixes both of these issues
LGTM |
2 similar comments
LGTM |
LGTM |
silverwind
pushed a commit
that referenced
this pull request
Jan 26, 2016
1. The release team's names were not in the sorted order and 2. the old list of releasers' names were not in bold This patch fixes both of these issues PR-URL: #4876 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Thanks! Landed in 0a1859d. |
rvagg
pushed a commit
that referenced
this pull request
Jan 27, 2016
1. The release team's names were not in the sorted order and 2. the old list of releasers' names were not in bold This patch fixes both of these issues PR-URL: #4876 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
benjamingr
pushed a commit
to benjamingr/io.js
that referenced
this pull request
Jan 27, 2016
1. The release team's names were not in the sorted order and 2. the old list of releasers' names were not in bold This patch fixes both of these issues PR-URL: nodejs#4876 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg
pushed a commit
that referenced
this pull request
Feb 8, 2016
1. The release team's names were not in the sorted order and 2. the old list of releasers' names were not in bold This patch fixes both of these issues PR-URL: #4876 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Blocked from backporting until other Doc commits land on v4.x-staging |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 22, 2016
1. The release team's names were not in the sorted order and 2. the old list of releasers' names were not in bold This patch fixes both of these issues PR-URL: #4876 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 22, 2016
1. The release team's names were not in the sorted order and 2. the old list of releasers' names were not in bold This patch fixes both of these issues PR-URL: #4876 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
1. The release team's names were not in the sorted order and 2. the old list of releasers' names were not in bold This patch fixes both of these issues PR-URL: #4876 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
1. The release team's names were not in the sorted order and 2. the old list of releasers' names were not in bold This patch fixes both of these issues PR-URL: nodejs#4876 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
This was referenced Oct 16, 2022
This was referenced Oct 16, 2022
This was referenced Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes both of these issues
cc @nodejs/release