deps: update V8 to 11.6 by targos · Pull Request #48710 · nodejs/node

targos · 2023-07-09T10:29:38Z

No description provided.

nodejs-github-bot · 2023-07-09T10:29:43Z

Review requested:

@nodejs/gyp
@nodejs/v8-update

nodejs-github-bot · 2023-07-09T10:34:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52660/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/5437/

targos · 2023-07-09T10:58:40Z

test-asan build failure was identified in canary, but not fixed yet.

In file included from ../deps/v8/src/init/setup-isolate-full.cc:8:
In file included from ../deps/v8/src/heap/heap-inl.h:32:
In file included from ../deps/v8/src/heap/new-spaces-inl.h:12:
In file included from ../deps/v8/src/heap/paged-spaces-inl.h:13:
In file included from ../deps/v8/src/objects/objects-inl.h:32:
In file included from ../deps/v8/src/objects/js-proxy-inl.h:8:
In file included from ../deps/v8/src/objects/instance-type-inl.h:11:
In file included from ../deps/v8/src/objects/map-inl.h:9:
In file included from ../deps/v8/src/objects/api-callbacks-inl.h:13:
In file included from ../deps/v8/src/objects/js-objects-inl.h:18:
In file included from ../deps/v8/src/objects/lookup-inl.h:14:
In file included from ../deps/v8/src/heap/factory-inl.h:13:
In file included from ../deps/v8/src/execution/isolate-inl.h:9:
In file included from ../deps/v8/src/objects/contexts-inl.h:17:
../deps/v8/src/objects/ordered-hash-table-inl.h:210:3: error: member reference type 'Tagged' is not a pointer
  WRITE_BARRIER(*this, entry_offset, value);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/v8/src/objects/object-macros.h:514:50: note: expanded from macro 'WRITE_BARRIER'
    CombinedWriteBarrier(object, Tagged(object)->RawField(offset), value, \
                                 ~~~~~~~~~~~~~~  ^
1 error generated.
make[2]: *** [tools/v8_gypfiles/v8_init.target.mk:182: /home/runner/work/node/node/out/Release/obj.target/v8_init/deps/v8/src/init/setup-isolate-full.o] Error 1

@nodejs/cpp-reviewers

nodejs-github-bot · 2023-07-10T08:08:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52680/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/5438/

targos · 2023-07-10T13:24:38Z

V8 CI is broken (looks like we're still trying to run it with Python 2.7)

nodejs-github-bot · 2023-07-10T13:26:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52682/

richardlau · 2023-07-10T13:32:23Z

V8 CI is broken (looks like we're still trying to run it with Python 2.7)

Yes, also reported in #48660 (comment).

I tried a quick patch to try to get the CI to use Python 3 over the weekend and it looks like we're missing some required Python modules on the Python 3 installation: https://ci.nodejs.org/job/node-test-commit-v8-linux/5435/

Original commit message: Fix mistake in the skip branch of test/mjsunit/regress-1320641.js It was doing a `string.test(regex)` which was wrong. It's supposed to be `regex.test(string)`. It wasn't caught in the CI because the skip path is not normally taken in the V8 CI. Change-Id: Id1bdab5bbc41968bba8adc1cb3664e8f95fb5d72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4697855 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#89044} Refs: v8/v8@9f4b769 PR-URL: nodejs#48830 Refs: v8/v8@c1a54d5 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>

Original commit message: [cppgc] expose wrapper descriptor on CppHeap This makes it possible for embedders to: 1. Avoid creating wrapper objects that happen to have a layout that leads V8 to consider the object cppgc-managed while it's not. Refs: nodejs#43521 2. Create cppgc-managed wrapper objects when they do not own the CppHeap. Refs: nodejs#45704 Bug: v8:13960 Change-Id: If31f4d56c5ead59dc0d56f937494d23d631f7438 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4598833 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#88490} Refs: v8/v8@9327503 PR-URL: nodejs#48660 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

Accept a new `step` break message.

`--no-harmony-sharedarraybuffer` was removed from V8 but it's still possible to disable the feature with `--enable-sharedarraybuffer-per-context`.

targos · 2023-07-31T12:36:18Z

cdebfb6 fixed it on my mac.

nodejs-github-bot · 2023-07-31T12:36:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53020/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/5485/

targos · 2023-08-01T05:30:39Z

We're back to the zlib-related error:

https://ci.nodejs.org/job/node-test-commit-linux-containered/38647/nodes=ubuntu1804_sharedlibs_shared_x64/console

16:46:43 /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/v8_zlib/deps/v8/third_party/zlib/cpu_features.o:(.bss.x86_cpu_enable_avx512+0x0): multiple definition of `x86_cpu_enable_avx512'

https://ci.nodejs.org/job/node-test-commit-smartos/50446/nodes=smartos20-64/console

16:48:20 ld: fatal: symbol 'x86_cpu_enable_avx512' is multiply-defined:
16:48:20 	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/obj.target/deps/zlib/libzlib.a(cpu_features.o) type=OBJT; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/obj.target/tools/v8_gypfiles/libv8_zlib.a(cpu_features.o) type=OBJT);

targos · 2023-08-07T13:42:17Z

/cc @nodejs/tsc This is essentially blocked on one compiler issue that I don't know how to handle (see above comment).

gengjiawen · 2023-08-16T02:51:24Z

We're back to the zlib-related error:

ci.nodejs.org/job/node-test-commit-linux-containered/38647/nodes=ubuntu1804_sharedlibs_shared_x64/console

16:46:43 /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/v8_zlib/deps/v8/third_party/zlib/cpu_features.o:(.bss.x86_cpu_enable_avx512+0x0): multiple definition of `x86_cpu_enable_avx512'

ci.nodejs.org/job/node-test-commit-smartos/50446/nodes=smartos20-64/console

16:48:20 ld: fatal: symbol 'x86_cpu_enable_avx512' is multiply-defined:
16:48:20 	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/obj.target/deps/zlib/libzlib.a(cpu_features.o) type=OBJT; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/obj.target/tools/v8_gypfiles/libv8_zlib.a(cpu_features.o) type=OBJT);

I suppose #47493 should help in this case.

targos · 2023-08-16T06:45:27Z

Yeah, but that PR is unfortunately stale.

targos · 2023-09-16T08:29:06Z

Replaced by #49639

targos mentioned this pull request Jul 9, 2023

deps: update V8 to 11.5 #48456

Closed

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jul 9, 2023

targos added semver-major PRs that contain breaking changes and should be released in the next major version. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 9, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2023

targos added the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label Jul 9, 2023

targos mentioned this pull request Jul 9, 2023

Broken V8 build in test-asan job nodejs/node-v8#251

Closed

This comment was marked as resolved.

Sign in to view

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 10, 2023

targos force-pushed the v8-116 branch from 3a38b3c to 8056ca0 Compare July 10, 2023 07:58

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 10, 2023

targos force-pushed the v8-116 branch from 8056ca0 to f2d9283 Compare July 10, 2023 13:04

nodejs deleted a comment from nodejs-github-bot Jul 10, 2023

joyeecheung mentioned this pull request Jul 10, 2023

Speeding up v8 heap snapshots v8/v8.dev#702

Merged

richardlau mentioned this pull request Jul 10, 2023

V8 CI is broken #48728

Closed

joyeecheung and others added 10 commits July 31, 2023 14:35

tools: update V8 gypfiles for 11.4

a16e7bd

tools: add new V8 headers to distribution

6513a2c

lib: update usage of always on Atomics API

28312e4

test: adapt debugger tests to V8 11.4

e717980

Accept a new `step` break message.

test: update flag to disable SharedArrayBuffer

bd4f22b

`--no-harmony-sharedarraybuffer` was removed from V8 but it's still possible to disable the feature with `--enable-sharedarraybuffer-per-context`.

tools: update V8 gypfiles for 11.5

dc8f280

test: adapt test-fs-write to V8 internal changes

46edced

tools: update V8 gypfiles for 11.6

3baa85b

targos force-pushed the v8-116 branch from 7731cba to 3baa85b Compare July 31, 2023 12:35

targos removed the build Issues and PRs related to build files or the CI. label Jul 31, 2023

github-actions bot mentioned this pull request Aug 1, 2023

CI Reliability 2023-08-01 nodejs/reliability#630

Open

21 tasks

nodejs deleted a comment from nodejs-github-bot Aug 1, 2023

This was referenced Aug 2, 2023

CI Reliability 2023-08-02 nodejs/reliability#631

Open

CI Reliability 2023-08-03 nodejs/reliability#632

Open

CI Reliability 2023-08-04 nodejs/reliability#633

Open

This was referenced Sep 13, 2023

Preparation for Node.js v21.0.0 #49638

Closed

deps: update V8 to 11.8 #49639

Closed

targos closed this Sep 16, 2023

targos deleted the v8-116 branch April 5, 2024 09:54

Uh oh!

Conversation

targos commented Jul 9, 2023

Uh oh!

nodejs-github-bot commented Jul 9, 2023

Uh oh!

nodejs-github-bot commented Jul 9, 2023 • edited by targos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Jul 9, 2023

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

nodejs-github-bot commented Jul 10, 2023 • edited by targos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Jul 10, 2023

Uh oh!

nodejs-github-bot commented Jul 10, 2023

Uh oh!

richardlau commented Jul 10, 2023

Uh oh!

targos commented Jul 31, 2023

Uh oh!

nodejs-github-bot commented Jul 31, 2023 • edited by targos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Aug 1, 2023

Uh oh!

targos commented Aug 7, 2023

Uh oh!

gengjiawen commented Aug 16, 2023

Uh oh!

targos commented Aug 16, 2023

Uh oh!

targos commented Sep 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

nodejs-github-bot commented Jul 9, 2023 •

edited by targos

Loading

nodejs-github-bot commented Jul 10, 2023 •

edited by targos

Loading

nodejs-github-bot commented Jul 31, 2023 •

edited by targos

Loading